r39611 - in /trunk/libmoosex-semiaffordanceaccessor-perl: Changes META.yml Makefile.PL README SIGNATURE debian/changelog lib/MooseX/SemiAffordanceAccessor.pm lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm t/basic.t t/pod-coverage.t t/pod.t
jawnsy-guest at users.alioth.debian.org
jawnsy-guest at users.alioth.debian.org
Thu Jul 9 22:48:55 UTC 2009
Author: jawnsy-guest
Date: Thu Jul 9 22:48:48 2009
New Revision: 39611
URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=39611
Log:
* New upstream release
+ Fixes bug (RT#47711)
+ Added a test
Modified:
trunk/libmoosex-semiaffordanceaccessor-perl/Changes
trunk/libmoosex-semiaffordanceaccessor-perl/META.yml
trunk/libmoosex-semiaffordanceaccessor-perl/Makefile.PL
trunk/libmoosex-semiaffordanceaccessor-perl/README
trunk/libmoosex-semiaffordanceaccessor-perl/SIGNATURE
trunk/libmoosex-semiaffordanceaccessor-perl/debian/changelog
trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor.pm
trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm
trunk/libmoosex-semiaffordanceaccessor-perl/t/basic.t
trunk/libmoosex-semiaffordanceaccessor-perl/t/pod-coverage.t
trunk/libmoosex-semiaffordanceaccessor-perl/t/pod.t
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/Changes?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/Changes (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/Changes Thu Jul 9 22:48:48 2009
@@ -1,3 +1,10 @@
+0.04 2009-07-09
+
+- This module unconditionally deleted the "is" parameter, which meant
+ it broke any use of "is => 'bare'". Reported by Jerome Quelin. Fixed
+ by Jesse Luehrs. RT #47711.
+
+
0.03 2008-08-30
- Renamed to MooseX::SemiAffordanceAccessor because it no longer
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/META.yml?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/META.yml (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/META.yml Thu Jul 9 22:48:48 2009
@@ -1,6 +1,6 @@
---
name: MooseX-SemiAffordanceAccessor
-version: 0.03
+version: 0.04
author:
- 'Dave Rolsky, C<< <autarch at urth.org> >>'
abstract: Name your accessors foo() and set_foo()
@@ -14,10 +14,10 @@
provides:
MooseX::SemiAffordanceAccessor:
file: lib/MooseX/SemiAffordanceAccessor.pm
- version: 0.03
+ version: 0.04
MooseX::SemiAffordanceAccessor::Role::Attribute:
file: lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm
-generated_by: Module::Build version 0.2808
+generated_by: Module::Build version 0.280801
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.2.html
version: 1.2
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/Makefile.PL?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/Makefile.PL (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/Makefile.PL Thu Jul 9 22:48:48 2009
@@ -1,4 +1,4 @@
-# Note: this file was auto-generated by Module::Build::Compat version 0.03
+# Note: this file was auto-generated by Module::Build::Compat version 0.2808_01
unless (eval "use Module::Build::Compat 0.02; 1" ) {
print "This module requires Module::Build to install itself.\n";
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/README
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/README?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/README (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/README Thu Jul 9 22:48:48 2009
@@ -23,12 +23,12 @@
module.
AUTHOR
- Dave Rolsky, "<autarch at urth.org>"
+ Dave Rolsky, `<autarch at urth.org>'
BUGS
Please report any bugs or feature requests to
- "bug-moosex-semiaffordanceaccessor at rt.cpan.org", or through the web
- interface at <http://rt.cpan.org>. I will be notified, and then you'll
+ `bug-moosex-semiaffordanceaccessor at rt.cpan.org', or through the web
+ interface at http://rt.cpan.org. I will be notified, and then you'll
automatically be notified of progress on your bug as I make changes.
COPYRIGHT & LICENSE
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/SIGNATURE
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/SIGNATURE?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/SIGNATURE (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/SIGNATURE Thu Jul 9 22:48:48 2009
@@ -15,20 +15,20 @@
Hash: SHA1
SHA1 78fc95c3d53b62fd626f0badcf814099bc72c73f Build.PL
-SHA1 5c27f1ceb729bf222ac99f7f16840e50735db21f Changes
+SHA1 3c3e5e5936be3ddee3a85ac0f4e1ab24b470f06b Changes
SHA1 62cc78a0dacd69ba1788ed81e17f98b1814dd076 MANIFEST
-SHA1 05c68f37ad0fdbd7dc5c15a92ff54c9d953d8a23 META.yml
-SHA1 cd14ada78fb37a0d926edd86eddcdf7f939de582 Makefile.PL
-SHA1 f84260ebc6b22dbf4b272741c34e4b9a7264d729 README
-SHA1 5507c702ba99de1eaa92af2fc139a00f68bb62c1 lib/MooseX/SemiAffordanceAccessor.pm
-SHA1 61d394f1a15bf2f1ae8ec3509756dd42364d4f0c lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm
-SHA1 f341573921f6e86b4cf227d1dfe75f75b469b8c4 t/basic.t
-SHA1 1e31329479c8a8c8d4c4de1382e89dc8c85ea68b t/pod-coverage.t
-SHA1 cec881e89926d320475f9de2b7fad02c2169f510 t/pod.t
+SHA1 705da2e3e4ec814ead7f1f1e8eace7706f611178 META.yml
+SHA1 f44a610f611cc4333f9a9b52873bc5a35fb7ffb3 Makefile.PL
+SHA1 74b93c3cc06b835c9dff321adddb7021886990c4 README
+SHA1 62e2a8da88598c0f9cf4a17996889bd020bdd47d lib/MooseX/SemiAffordanceAccessor.pm
+SHA1 846db0cf97ea1c8a81b2c75bf56355338b9f6829 lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm
+SHA1 a85e72be1c379c704478b97357c80d2d99ba4753 t/basic.t
+SHA1 f3fba045fd37191b8d320fd560736065f72c8a99 t/pod-coverage.t
+SHA1 d1ff551e8c5994f38860cbc8b16103139e307996 t/pod.t
-----BEGIN PGP SIGNATURE-----
-Version: GnuPG v1.4.6 (GNU/Linux)
+Version: GnuPG v1.4.9 (GNU/Linux)
-iD8DBQFIuho53Or3ZzQuifMRAor+AJ42ueoJTUxP7bjSjcCm4db0CvlIbACg4HBK
-YkUulzuXtoyBOVS7MSAXogI=
-=XUUS
+iEYEARECAAYFAkpV3tcACgkQIgMCsV8qvRILAQCeIz6Srfi8PStUL7Vp02O0kW7V
+tIQAnAhnf5DcOswHKiHInTNFhZvEhVbG
+=DGyK
-----END PGP SIGNATURE-----
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/debian/changelog?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/debian/changelog (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/debian/changelog Thu Jul 9 22:48:48 2009
@@ -1,8 +1,13 @@
-libmoosex-semiaffordanceaccessor-perl (0.03-2) UNRELEASED; urgency=low
+libmoosex-semiaffordanceaccessor-perl (0.04-1) UNRELEASED; urgency=low
+ * New upstream release
+ + Fixes bug (RT#47711)
+ + Added a test
+
+ [ Nathan Handler ]
* debian/watch: Update to ignore development releases.
- -- Nathan Handler <nhandler at ubuntu.com> Sat, 06 Jun 2009 01:36:28 +0000
+ -- Jonathan Yu <frequency at cpan.org> Thu, 09 Jul 2009 13:46:59 -0400
libmoosex-semiaffordanceaccessor-perl (0.03-1) unstable; urgency=low
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor.pm?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor.pm (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor.pm Thu Jul 9 22:48:48 2009
@@ -3,7 +3,7 @@
use strict;
use warnings;
-our $VERSION = '0.03';
+our $VERSION = '0.04';
use Moose 0.5504 ();
use Moose::Exporter;
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/lib/MooseX/SemiAffordanceAccessor/Role/Attribute.pm Thu Jul 9 22:48:48 2009
@@ -18,6 +18,7 @@
if ( $options->{is} eq 'ro' )
{
$options->{reader} = $name;
+ delete $options->{is};
}
elsif ( $options->{is} eq 'rw' )
{
@@ -30,9 +31,8 @@
}
$options->{writer} = $prefix . q{_} . $name;
+ delete $options->{is};
}
-
- delete $options->{is};
}
};
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/t/basic.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/t/basic.t?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/t/basic.t (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/t/basic.t Thu Jul 9 22:48:48 2009
@@ -1,7 +1,7 @@
use strict;
use warnings;
-use Test::More tests => 12;
+use Test::More tests => 21;
{
@@ -34,6 +34,26 @@
has '_private' => ( is => 'rw' );
}
+{
+ package SAA3;
+
+ use Moose;
+ use MooseX::SemiAffordanceAccessor;
+
+ has 'ro' => ( is => 'ro' );
+ has 'thing' => ( is => 'rw', reader => 'get_thing' );
+ has 'thing2' => ( is => 'rw', writer => 'set_it' );
+}
+
+{
+ package SAA4;
+
+ use Moose;
+ use MooseX::SemiAffordanceAccessor;
+
+ has bare => ( is => 'bare' );
+}
+
ok( Standard->can('thing'), 'Standard->thing() exists' );
ok( ! Standard->can('set_thing'), 'Standard->set_thing() does not exist' );
@@ -49,3 +69,14 @@
ok( SAA2->can('set_thing'), 'SAA2->set_thing() exists' );
ok( SAA2->can('_private'), 'SAA2->_private() exists' );
ok( SAA2->can('_set_private'), 'SAA2->_set_private() exists' );
+
+ok( SAA3->can('ro'), 'SAA3->ro exists' );
+ok( ! SAA3->can('set_ro'), 'SAA3->set_ro does not exist' );
+ok( SAA3->can('thing'), 'SAA3->thing exists' );
+ok( ! SAA3->can('set_thing'), 'SAA3->set_thing does not exist' );
+ok( SAA3->can('thing2'), 'SAA3->thing2 exists' );
+ok( ! SAA3->can('set_thing2'), 'SAA3->set_thing2 does not exist' );
+ok( SAA3->can('set_it'), 'SAA3->set_it does exist' );
+
+ok( ! SAA4->can('bare'), 'SAA4->bare does not exist' );
+ok( ! SAA4->can('set_bare'), 'SAA4->set_bare does not exist' );
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/t/pod-coverage.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/t/pod-coverage.t?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/t/pod-coverage.t (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/t/pod-coverage.t Thu Jul 9 22:48:48 2009
@@ -5,7 +5,7 @@
plan skip_all => 'This test is only run for the module author'
- unless -d '.svn' || $ENV{IS_MAINTAINER};
+ unless -d '.git' || $ENV{IS_MAINTAINER};
eval "use Test::Pod::Coverage 1.04";
plan skip_all => "Test::Pod::Coverage 1.04 required for testing POD coverage"
Modified: trunk/libmoosex-semiaffordanceaccessor-perl/t/pod.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmoosex-semiaffordanceaccessor-perl/t/pod.t?rev=39611&op=diff
==============================================================================
--- trunk/libmoosex-semiaffordanceaccessor-perl/t/pod.t (original)
+++ trunk/libmoosex-semiaffordanceaccessor-perl/t/pod.t Thu Jul 9 22:48:48 2009
@@ -5,7 +5,7 @@
plan skip_all => 'This test is only run for the module author'
- unless -d '.svn' || $ENV{IS_MAINTAINER};
+ unless -d '.git' || $ENV{IS_MAINTAINER};
eval "use Test::Pod 1.14";
plan skip_all => "Test::Pod 1.14 required for testing POD" if $@;
More information about the Pkg-perl-cvs-commits
mailing list