r32337 - in /trunk/libclass-c3-perl: ChangeLog MANIFEST META.yml Makefile.PL README debian/changelog debian/control debian/watch inc/Module/AutoInstall.pm inc/Module/Install/AutoInstall.pm inc/Module/Install/Include.pm lib/Class/C3.pm lib/Class/C3/next.pm

eloy at users.alioth.debian.org eloy at users.alioth.debian.org
Fri Mar 27 10:34:01 UTC 2009


Author: eloy
Date: Fri Mar 27 10:33:46 2009
New Revision: 32337

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=32337
Log:
  * New upstream release
  * debian/control: increase Standards-Version 3.8.1 (no changes), update
    description.
  * debian/watch: updated to latest schema


Removed:
    trunk/libclass-c3-perl/inc/Module/AutoInstall.pm
    trunk/libclass-c3-perl/inc/Module/Install/AutoInstall.pm
    trunk/libclass-c3-perl/inc/Module/Install/Include.pm
Modified:
    trunk/libclass-c3-perl/ChangeLog
    trunk/libclass-c3-perl/MANIFEST
    trunk/libclass-c3-perl/META.yml
    trunk/libclass-c3-perl/Makefile.PL
    trunk/libclass-c3-perl/README
    trunk/libclass-c3-perl/debian/changelog
    trunk/libclass-c3-perl/debian/control
    trunk/libclass-c3-perl/debian/watch
    trunk/libclass-c3-perl/lib/Class/C3.pm
    trunk/libclass-c3-perl/lib/Class/C3/next.pm

Modified: trunk/libclass-c3-perl/ChangeLog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/ChangeLog?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/ChangeLog (original)
+++ trunk/libclass-c3-perl/ChangeLog Fri Mar 27 10:33:46 2009
@@ -1,4 +1,10 @@
 Revision history for Perl extension Class::C3.
+
+0.21 Wed, Mar 25, 2009
+    - Remove fake Build.PL. Module::Install doesn't support that anymore.
+      (Florian Ragwitz)
+    - Stop using auto_instal in Makefile.PL. Its use is strongly discouraged.
+      (Closes RT#38051, RT#44541) (Simon Bertrang)
 
 0.20 Mon, Dec 8, 2008
     - Prevent redefined warnings when Class::C3 is loaded explicitly after

Modified: trunk/libclass-c3-perl/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/MANIFEST?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/MANIFEST (original)
+++ trunk/libclass-c3-perl/MANIFEST Fri Mar 27 10:33:46 2009
@@ -1,11 +1,8 @@
 ChangeLog
-inc/Module/AutoInstall.pm
 inc/Module/Install.pm
-inc/Module/Install/AutoInstall.pm
 inc/Module/Install/Base.pm
 inc/Module/Install/Can.pm
 inc/Module/Install/Fetch.pm
-inc/Module/Install/Include.pm
 inc/Module/Install/Makefile.pm
 inc/Module/Install/Metadata.pm
 inc/Module/Install/Win32.pm

Modified: trunk/libclass-c3-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/META.yml?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/META.yml (original)
+++ trunk/libclass-c3-perl/META.yml Fri Mar 27 10:33:46 2009
@@ -18,10 +18,10 @@
 provides:
   Class::C3:
     file: lib/Class/C3.pm
-    version: 0.20
+    version: 0.21
 requires:
   Algorithm::C3: 0.06
   Scalar::Util: 1.10
 resources:
   license: http://dev.perl.org/licenses/
-version: 0.20
+version: 0.21

Modified: trunk/libclass-c3-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/Makefile.PL?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/Makefile.PL (original)
+++ trunk/libclass-c3-perl/Makefile.PL Fri Mar 27 10:33:46 2009
@@ -20,5 +20,4 @@
 }
 
 auto_provides;
-auto_install;
 WriteAll;

Modified: trunk/libclass-c3-perl/README
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/README?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/README (original)
+++ trunk/libclass-c3-perl/README Fri Mar 27 10:33:46 2009
@@ -3,22 +3,22 @@
 
 SYNOPSIS
         package A;
-        use Class::C3;     
+        use Class::C3;
         sub hello { 'A::hello' }
 
         package B;
         use base 'A';
-        use Class::C3;     
+        use Class::C3;
 
         package C;
         use base 'A';
-        use Class::C3;     
+        use Class::C3;
 
         sub hello { 'C::hello' }
 
         package D;
         use base ('B', 'C');
-        use Class::C3;    
+        use Class::C3;
 
         # Classic Diamond MI pattern
         #    <A>
@@ -28,16 +28,16 @@
         #    <D>
 
         package main;
-        
-    # initializez the C3 module 
+
+        # initializez the C3 module
         # (formerly called in INIT)
-        Class::C3::initialize();  
+        Class::C3::initialize();
 
         print join ', ' => Class::C3::calculateMRO('Diamond_D') # prints D, B, C, A
 
         print D->hello() # prints 'C::hello' instead of the standard p5 'A::hello'
-        
-    D->can('hello')->();          # can() also works correctly
+
+        D->can('hello')->();          # can() also works correctly
         UNIVERSAL::can('D', 'hello'); # as does UNIVERSAL::can()
 
 DESCRIPTION
@@ -117,15 +117,15 @@
           package Foo;
           use Class::C3;
           # ... Foo methods here
-          
-  package Bar;
+
+          package Bar;
           use Class::C3;
           use base 'Foo';
           # ... Bar methods here
-          
-  package main;
-          
-  Class::C3::initialize(); # now it is safe to use Foo and Bar
+
+          package main;
+
+          Class::C3::initialize(); # now it is safe to use Foo and Bar
 
         This function used to be called automatically for you in the INIT
         phase of the perl compiler, but that lead to warnings if this module
@@ -161,27 +161,27 @@
       <B>   <C>
         \   /
          <D>
-      
-  package A;
-      use c3; 
-      sub foo { 'A::foo' }       
-     
-  package B;
-      use base 'A'; 
-      use c3;     
-      sub foo { 'B::foo => ' . (shift)->next::method() }       
-     
-  package B;
-      use base 'A'; 
-      use c3;    
-      sub foo { 'C::foo => ' . (shift)->next::method() }   
-     
-  package D;
-      use base ('B', 'C'); 
-      use c3; 
-      sub foo { 'D::foo => ' . (shift)->next::method() }   
-      
-  print D->foo; # prints out "D::foo => B::foo => C::foo => A::foo"
+
+      package A;
+      use c3;
+      sub foo { 'A::foo' }
+
+      package B;
+      use base 'A';
+      use c3;
+      sub foo { 'B::foo => ' . (shift)->next::method() }
+
+      package B;
+      use base 'A';
+      use c3;
+      sub foo { 'C::foo => ' . (shift)->next::method() }
+
+      package D;
+      use base ('B', 'C');
+      use c3;
+      sub foo { 'D::foo => ' . (shift)->next::method() }
+
+      print D->foo; # prints out "D::foo => B::foo => C::foo => A::foo"
 
     A few things to note. First, we do not require you to add on the method
     name to the "next::method" call (this is unlike "NEXT::" and "SUPER::"

Modified: trunk/libclass-c3-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/debian/changelog?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/debian/changelog (original)
+++ trunk/libclass-c3-perl/debian/changelog Fri Mar 27 10:33:46 2009
@@ -1,3 +1,12 @@
+libclass-c3-perl (0.21-1) unstable; urgency=low
+
+  * New upstream release
+  * debian/control: increase Standards-Version 3.8.1 (no changes), update
+    description.
+  * debian/watch: updated to latest schema
+ 
+ -- Krzysztof Krzyżaniak (eloy) <eloy at debian.org>  Fri, 27 Mar 2009 11:26:52 +0100
+
 libclass-c3-perl (0.20-1) unstable; urgency=low
 
   * New upstream release

Modified: trunk/libclass-c3-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/debian/control?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/debian/control (original)
+++ trunk/libclass-c3-perl/debian/control Fri Mar 27 10:33:46 2009
@@ -5,7 +5,7 @@
 Build-Depends-Indep: perl (>= 5.8.0-7), libtest-exception-perl (>= 0.15), libtest-pod-perl, libtest-pod-coverage-perl, libsub-name-perl, libalgorithm-c3-perl (>= 0.05), libclass-c3-xs-perl
 Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
 Uploaders: Krzysztof Krzyżaniak (eloy) <eloy at debian.org>
-Standards-Version: 3.8.0.1
+Standards-Version: 3.8.1
 Homepage: http://search.cpan.org/dist/Class-C3/
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libclass-c3-perl/
 Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libclass-c3-perl/
@@ -16,9 +16,9 @@
 Depends: ${perl:Depends}, ${misc:Depends}, libtest-exception-perl (>= 0.15), libalgorithm-c3-perl (>= 0.05)
 Recommends: libclass-c3-xs-perl
 Description:  A pragma to use the C3 method resolution order algortihm
- Class::C3 is currently an experimental pragma to change Perl 5's standard 
- method resolution order from depth-first left-to-right (a.k.a - pre-order) 
- to the more sophisticated C3 method resolution order.
+ Class::C3 is pragma to change Perl 5's standard method resolution order from
+ depth-first left-to-right (a.k.a - pre-order) to the more sophisticated
+ C3 method resolution order.
  .
  C3 is the name of an algorithm which aims to provide a sane method resolution 
  order under multiple inheritence. It was first introduced in the langauge 

Modified: trunk/libclass-c3-perl/debian/watch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/debian/watch?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/debian/watch (original)
+++ trunk/libclass-c3-perl/debian/watch Fri Mar 27 10:33:46 2009
@@ -1,3 +1,2 @@
-# format version number, currently 2; this line is compulsory!
-version=2
-http://www.cpan.org/modules/by-module/Class/Class-C3-([\d\.]+).tar.gz
+version=3
+http://search.cpan.org/dist/Class-C3/ .*/Class-C3-v?(\d[\d_.]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)

Modified: trunk/libclass-c3-perl/lib/Class/C3.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/lib/Class/C3.pm?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/lib/Class/C3.pm (original)
+++ trunk/libclass-c3-perl/lib/Class/C3.pm Fri Mar 27 10:33:46 2009
@@ -4,7 +4,7 @@
 use strict;
 use warnings;
 
-our $VERSION = '0.20';
+our $VERSION = '0.21';
 
 our $C3_IN_CORE;
 our $C3_XS;
@@ -28,7 +28,7 @@
     }
 }
 
-# this is our global stash of both 
+# this is our global stash of both
 # MRO's and method dispatch tables
 # the structure basically looks like
 # this:
@@ -60,7 +60,7 @@
     return if $TURN_OFF_C3;
     mro::set_mro($class, 'c3') if $C3_IN_CORE;
 
-    # make a note to calculate $class 
+    # make a note to calculate $class
     # during INIT phase
     $MRO{$class} = undef unless exists $MRO{$class};
 }
@@ -93,12 +93,12 @@
 sub uninitialize {
     # why bother if we don't have anything ...
     %next::METHOD_CACHE = ();
-    return unless keys %MRO;    
+    return unless keys %MRO;
     if($C3_IN_CORE) {
         mro::set_mro($_, 'dfs') for keys %MRO;
     }
     else {
-        _remove_method_dispatch_tables();    
+        _remove_method_dispatch_tables();
         $_initialized = 0;
     }
 }
@@ -125,15 +125,15 @@
     $MRO{$class} = { MRO => \@MRO };
     my $has_overload_fallback;
     my %methods;
-    # NOTE: 
+    # NOTE:
     # we do @MRO[1 .. $#MRO] here because it
     # makes no sense to interogate the class
-    # which you are calculating for. 
+    # which you are calculating for.
     foreach my $local (@MRO[1 .. $#MRO]) {
-        # if overload has tagged this module to 
+        # if overload has tagged this module to
         # have use "fallback", then we want to
-        # grab that value 
-        $has_overload_fallback = ${"${local}::()"} 
+        # grab that value
+        $has_overload_fallback = ${"${local}::()"}
             if !defined $has_overload_fallback && defined ${"${local}::()"};
         foreach my $method (grep { defined &{"${local}::$_"} } keys %{"${local}::"}) {
             # skip if already overriden in local class
@@ -143,17 +143,17 @@
                 code => \&{"${local}::$method"}
             } unless exists $methods{$method};
         }
-    }    
+    }
     # now stash them in our %MRO table
-    $MRO{$class}->{methods} = \%methods; 
-    $MRO{$class}->{has_overload_fallback} = $has_overload_fallback;        
+    $MRO{$class}->{methods} = \%methods;
+    $MRO{$class}->{has_overload_fallback} = $has_overload_fallback;
 }
 
 sub _apply_method_dispatch_tables {
     return if $C3_IN_CORE;
     foreach my $class (keys %MRO) {
         _apply_method_dispatch_table($class);
-    }     
+    }
 }
 
 sub _apply_method_dispatch_table {
@@ -169,7 +169,7 @@
             ${"${class}::$method"} = $$orig if defined $$orig;
         }
         *{"${class}::$method"} = $MRO{$class}->{methods}->{$method}->{code};
-    }    
+    }
 }
 
 sub _remove_method_dispatch_tables {
@@ -183,19 +183,19 @@
     return if $C3_IN_CORE;
     my $class = shift;
     no strict 'refs';
-    delete ${"${class}::"}{"()"} if $MRO{$class}->{has_overload_fallback};    
+    delete ${"${class}::"}{"()"} if $MRO{$class}->{has_overload_fallback};
     foreach my $method (keys %{$MRO{$class}->{methods}}) {
         delete ${"${class}::"}{$method}
-            if defined *{"${class}::${method}"}{CODE} && 
-               (*{"${class}::${method}"}{CODE} eq $MRO{$class}->{methods}->{$method}->{code});       
+            if defined *{"${class}::${method}"}{CODE} &&
+               (*{"${class}::${method}"}{CODE} eq $MRO{$class}->{methods}->{$method}->{code});
     }
 }
 
 sub calculateMRO {
     my ($class, $merge_cache) = @_;
 
-    return Algorithm::C3::merge($class, sub { 
-        no strict 'refs'; 
+    return Algorithm::C3::merge($class, sub {
+        no strict 'refs';
         @{$_[0] . '::ISA'};
     }, $merge_cache);
 }
@@ -228,22 +228,22 @@
 =head1 SYNOPSIS
 
     package A;
-    use Class::C3;     
+    use Class::C3;
     sub hello { 'A::hello' }
 
     package B;
     use base 'A';
-    use Class::C3;     
+    use Class::C3;
 
     package C;
     use base 'A';
-    use Class::C3;     
+    use Class::C3;
 
     sub hello { 'C::hello' }
 
     package D;
     use base ('B', 'C');
-    use Class::C3;    
+    use Class::C3;
 
     # Classic Diamond MI pattern
     #    <A>
@@ -253,34 +253,34 @@
     #    <D>
 
     package main;
-    
-    # initializez the C3 module 
+
+    # initializez the C3 module
     # (formerly called in INIT)
-    Class::C3::initialize();  
+    Class::C3::initialize();
 
     print join ', ' => Class::C3::calculateMRO('Diamond_D') # prints D, B, C, A
 
     print D->hello() # prints 'C::hello' instead of the standard p5 'A::hello'
-    
+
     D->can('hello')->();          # can() also works correctly
     UNIVERSAL::can('D', 'hello'); # as does UNIVERSAL::can()
 
 =head1 DESCRIPTION
 
-This is pragma to change Perl 5's standard method resolution order from depth-first left-to-right 
-(a.k.a - pre-order) to the more sophisticated C3 method resolution order. 
+This is pragma to change Perl 5's standard method resolution order from depth-first left-to-right
+(a.k.a - pre-order) to the more sophisticated C3 method resolution order.
 
 =head2 What is C3?
 
 C3 is the name of an algorithm which aims to provide a sane method resolution order under multiple
 inheritence. It was first introduced in the langauge Dylan (see links in the L<SEE ALSO> section),
-and then later adopted as the prefered MRO (Method Resolution Order) for the new-style classes in 
-Python 2.3. Most recently it has been adopted as the 'canonical' MRO for Perl 6 classes, and the 
+and then later adopted as the prefered MRO (Method Resolution Order) for the new-style classes in
+Python 2.3. Most recently it has been adopted as the 'canonical' MRO for Perl 6 classes, and the
 default MRO for Parrot objects as well.
 
 =head2 How does C3 work.
 
-C3 works by always preserving local precendence ordering. This essentially means that no class will 
+C3 works by always preserving local precendence ordering. This essentially means that no class will
 appear before any of it's subclasses. Take the classic diamond inheritence pattern for instance:
 
      <A>
@@ -289,8 +289,8 @@
     \   /
      <D>
 
-The standard Perl 5 MRO would be (D, B, A, C). The result being that B<A> appears before B<C>, even 
-though B<C> is the subclass of B<A>. The C3 MRO algorithm however, produces the following MRO 
+The standard Perl 5 MRO would be (D, B, A, C). The result being that B<A> appears before B<C>, even
+though B<C> is the subclass of B<A>. The C3 MRO algorithm however, produces the following MRO
 (D, B, C, A), which does not have this same issue.
 
 This example is fairly trival, for more complex examples and a deeper explaination, see the links in
@@ -298,11 +298,11 @@
 
 =head2 How does this module work?
 
-This module uses a technique similar to Perl 5's method caching. When C<Class::C3::initialize> is 
-called, this module calculates the MRO of all the classes which called C<use Class::C3>. It then 
-gathers information from the symbol tables of each of those classes, and builds a set of method 
-aliases for the correct dispatch ordering. Once all these C3-based method tables are created, it 
-then adds the method aliases into the local classes symbol table. 
+This module uses a technique similar to Perl 5's method caching. When C<Class::C3::initialize> is
+called, this module calculates the MRO of all the classes which called C<use Class::C3>. It then
+gathers information from the symbol tables of each of those classes, and builds a set of method
+aliases for the correct dispatch ordering. Once all these C3-based method tables are created, it
+then adds the method aliases into the local classes symbol table.
 
 The end result is actually classes with pre-cached method dispatch. However, this caching does not
 do well if you start changing your C<@ISA> or messing with class symbol tables, so you should consider
@@ -310,18 +310,18 @@
 
 =head1 OPTIONAL LOWERCASE PRAGMA
 
-This release also includes an optional module B<c3> in the F<opt/> folder. I did not include this in 
+This release also includes an optional module B<c3> in the F<opt/> folder. I did not include this in
 the regular install since lowercase module names are considered I<"bad"> by some people. However I
 think that code looks much nicer like this:
 
   package MyClass;
   use c3;
-  
+
 The the more clunky:
 
   package MyClass;
   use Class::C3;
-  
+
 But hey, it's your choice, thats why it is optional.
 
 =head1 FUNCTIONS
@@ -334,31 +334,31 @@
 
 =item B<initialize>
 
-This B<must be called> to initalize the C3 method dispatch tables, this module B<will not work> if 
-you do not do this. It is advised to do this as soon as possible B<after> loading any classes which 
+This B<must be called> to initalize the C3 method dispatch tables, this module B<will not work> if
+you do not do this. It is advised to do this as soon as possible B<after> loading any classes which
 use C3. Here is a quick code example:
-  
+
   package Foo;
   use Class::C3;
   # ... Foo methods here
-  
+
   package Bar;
   use Class::C3;
   use base 'Foo';
   # ... Bar methods here
-  
+
   package main;
-  
+
   Class::C3::initialize(); # now it is safe to use Foo and Bar
 
-This function used to be called automatically for you in the INIT phase of the perl compiler, but 
-that lead to warnings if this module was required at runtime. After discussion with my user base 
-(the L<DBIx::Class> folks), we decided that calling this in INIT was more of an annoyance than a 
-convience. I apologize to anyone this causes problems for (although i would very suprised if I had 
-any other users other than the L<DBIx::Class> folks). The simplest solution of course is to define 
-your own INIT method which calls this function. 
-
-NOTE: 
+This function used to be called automatically for you in the INIT phase of the perl compiler, but
+that lead to warnings if this module was required at runtime. After discussion with my user base
+(the L<DBIx::Class> folks), we decided that calling this in INIT was more of an annoyance than a
+convience. I apologize to anyone this causes problems for (although i would very suprised if I had
+any other users other than the L<DBIx::Class> folks). The simplest solution of course is to define
+your own INIT method which calls this function.
+
+NOTE:
 
 If C<initialize> detects that C<initialize> has already been executed, it will L</uninitialize> and
 clear the MRO cache first.
@@ -366,7 +366,7 @@
 =item B<uninitialize>
 
 Calling this function results in the removal of all cached methods, and the restoration of the old Perl 5
-style dispatch order (depth-first, left-to-right). 
+style dispatch order (depth-first, left-to-right).
 
 =item B<reinitialize>
 
@@ -376,8 +376,8 @@
 
 =head1 METHOD REDISPATCHING
 
-It is always useful to be able to re-dispatch your method call to the "next most applicable method". This 
-module provides a pseudo package along the lines of C<SUPER::> or C<NEXT::> which will re-dispatch the 
+It is always useful to be able to re-dispatch your method call to the "next most applicable method". This
+module provides a pseudo package along the lines of C<SUPER::> or C<NEXT::> which will re-dispatch the
 method along the C3 linearization. This is best show with an examples.
 
   # a classic diamond MI pattern ...
@@ -386,41 +386,41 @@
   <B>   <C>
     \   /
      <D>
-  
+
   package A;
-  use c3; 
-  sub foo { 'A::foo' }       
- 
+  use c3;
+  sub foo { 'A::foo' }
+
   package B;
-  use base 'A'; 
-  use c3;     
-  sub foo { 'B::foo => ' . (shift)->next::method() }       
- 
+  use base 'A';
+  use c3;
+  sub foo { 'B::foo => ' . (shift)->next::method() }
+
   package B;
-  use base 'A'; 
-  use c3;    
-  sub foo { 'C::foo => ' . (shift)->next::method() }   
- 
+  use base 'A';
+  use c3;
+  sub foo { 'C::foo => ' . (shift)->next::method() }
+
   package D;
-  use base ('B', 'C'); 
-  use c3; 
-  sub foo { 'D::foo => ' . (shift)->next::method() }   
-  
+  use base ('B', 'C');
+  use c3;
+  sub foo { 'D::foo => ' . (shift)->next::method() }
+
   print D->foo; # prints out "D::foo => B::foo => C::foo => A::foo"
 
-A few things to note. First, we do not require you to add on the method name to the C<next::method> 
-call (this is unlike C<NEXT::> and C<SUPER::> which do require that). This helps to enforce the rule 
-that you cannot dispatch to a method of a different name (this is how C<NEXT::> behaves as well). 
-
-The next thing to keep in mind is that you will need to pass all arguments to C<next::method> it can 
-not automatically use the current C<@_>. 
+A few things to note. First, we do not require you to add on the method name to the C<next::method>
+call (this is unlike C<NEXT::> and C<SUPER::> which do require that). This helps to enforce the rule
+that you cannot dispatch to a method of a different name (this is how C<NEXT::> behaves as well).
+
+The next thing to keep in mind is that you will need to pass all arguments to C<next::method> it can
+not automatically use the current C<@_>.
 
 If C<next::method> cannot find a next method to re-dispatch the call to, it will throw an exception.
 You can use C<next::can> to see if C<next::method> will succeed before you call it like so:
 
-  $self->next::method(@_) if $self->next::can; 
-
-Additionally, you can use C<maybe::next::method> as a shortcut to only call the next method if it exists. 
+  $self->next::method(@_) if $self->next::can;
+
+Additionally, you can use C<maybe::next::method> as a shortcut to only call the next method if it exists.
 The previous example could be simply written as:
 
   $self->maybe::next::method(@_);
@@ -429,9 +429,9 @@
 
 =head1 CAVEATS
 
-This module used to be labeled as I<experimental>, however it has now been pretty heavily tested by 
-the good folks over at L<DBIx::Class> and I am confident this module is perfectly usable for 
-whatever your needs might be. 
+This module used to be labeled as I<experimental>, however it has now been pretty heavily tested by
+the good folks over at L<DBIx::Class> and I am confident this module is perfectly usable for
+whatever your needs might be.
 
 But there are still caveats, so here goes ...
 
@@ -440,7 +440,7 @@
 =item Use of C<SUPER::>.
 
 The idea of C<SUPER::> under multiple inheritence is ambigious, and generally not recomended anyway.
-However, it's use in conjuntion with this module is very much not recommended, and in fact very 
+However, it's use in conjuntion with this module is very much not recommended, and in fact very
 discouraged. The recommended approach is to instead use the supplied C<next::method> feature, see
 more details on it's usage above.
 
@@ -448,37 +448,37 @@
 
 It is the author's opinion that changing C<@ISA> at runtime is pure insanity anyway. However, people
 do it, so I must caveat. Any changes to the C<@ISA> will not be reflected in the MRO calculated by this
-module, and therefor probably won't even show up. If you do this, you will need to call C<reinitialize> 
+module, and therefor probably won't even show up. If you do this, you will need to call C<reinitialize>
 in order to recalulate B<all> method dispatch tables. See the C<reinitialize> documentation and an example
 in F<t/20_reinitialize.t> for more information.
 
 =item Adding/deleting methods from class symbol tables.
 
-This module calculates the MRO for each requested class by interogatting the symbol tables of said classes. 
-So any symbol table manipulation which takes place after our INIT phase is run will not be reflected in 
-the calculated MRO. Just as with changing the C<@ISA>, you will need to call C<reinitialize> for any 
+This module calculates the MRO for each requested class by interogatting the symbol tables of said classes.
+So any symbol table manipulation which takes place after our INIT phase is run will not be reflected in
+the calculated MRO. Just as with changing the C<@ISA>, you will need to call C<reinitialize> for any
 changes you make to take effect.
 
 =item Calling C<next::method> from methods defined outside the class
 
-There is an edge case when using C<next::method> from within a subroutine which was created in a different 
-module than the one it is called from. It sounds complicated, but it really isn't. Here is an example which 
+There is an edge case when using C<next::method> from within a subroutine which was created in a different
+module than the one it is called from. It sounds complicated, but it really isn't. Here is an example which
 will not work correctly:
 
   *Foo::foo = sub { (shift)->next::method(@_) };
 
-The problem exists because the anonymous subroutine being assigned to the glob C<*Foo::foo> will show up 
-in the call stack as being called C<__ANON__> and not C<foo> as you might expect. Since C<next::method> 
-uses C<caller> to find the name of the method it was called in, it will fail in this case. 
-
-But fear not, there is a simple solution. The module C<Sub::Name> will reach into the perl internals and 
+The problem exists because the anonymous subroutine being assigned to the glob C<*Foo::foo> will show up
+in the call stack as being called C<__ANON__> and not C<foo> as you might expect. Since C<next::method>
+uses C<caller> to find the name of the method it was called in, it will fail in this case.
+
+But fear not, there is a simple solution. The module C<Sub::Name> will reach into the perl internals and
 assign a name to an anonymous subroutine for you. Simply do this:
-    
+
   use Sub::Name 'subname';
   *Foo::foo = subname 'Foo::foo' => sub { (shift)->next::method(@_) };
 
-and things will Just Work. Of course this is not always possible to do, but to be honest, I just can't 
-manage to find a workaround for it, so until someone gives me a working patch this will be a known 
+and things will Just Work. Of course this is not always possible to do, but to be honest, I just can't
+manage to find a workaround for it, so until someone gives me a working patch this will be a known
 limitation of this module.
 
 =back
@@ -541,19 +541,19 @@
 
 =item L<http://www.call-with-current-continuation.org/eggs/c3.html>
 
-=back 
+=back
 
 =head1 ACKNOWLEGEMENTS
 
 =over 4
 
-=item Thanks to Matt S. Trout for using this module in his module L<DBIx::Class> 
+=item Thanks to Matt S. Trout for using this module in his module L<DBIx::Class>
 and finding many bugs and providing fixes.
 
-=item Thanks to Justin Guenther for making C<next::method> more robust by handling 
+=item Thanks to Justin Guenther for making C<next::method> more robust by handling
 calls inside C<eval> and anon-subs.
 
-=item Thanks to Robert Norris for adding support for C<next::can> and 
+=item Thanks to Robert Norris for adding support for C<next::can> and
 C<maybe::next::method>.
 
 =back
@@ -571,6 +571,6 @@
 L<http://www.iinteractive.com>
 
 This library is free software; you can redistribute it and/or modify
-it under the same terms as Perl itself. 
+it under the same terms as Perl itself.
 
 =cut

Modified: trunk/libclass-c3-perl/lib/Class/C3/next.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libclass-c3-perl/lib/Class/C3/next.pm?rev=32337&op=diff
==============================================================================
--- trunk/libclass-c3-perl/lib/Class/C3/next.pm (original)
+++ trunk/libclass-c3-perl/lib/Class/C3/next.pm Fri Mar 27 10:33:46 2009
@@ -1,5 +1,5 @@
 package  # hide me from PAUSE
-    next; 
+    next;
 
 use strict;
 use warnings;
@@ -16,7 +16,7 @@
     my $class    = blessed($self) || $self;
     my $indirect = caller() =~ /^(?:next|maybe::next)$/;
     my $level = $indirect ? 2 : 1;
-     
+
     my ($method_caller, $label, @label);
     while ($method_caller = (caller($level++))[3]) {
       @label = (split '::', $method_caller);
@@ -28,25 +28,25 @@
 
     my $method;
 
-    my $caller   = join '::' => @label;    
-    
+    my $caller   = join '::' => @label;
+
     $method = $METHOD_CACHE{"$class|$caller|$label"} ||= do {
-        
+
         my @MRO = Class::C3::calculateMRO($class);
-        
+
         my $current;
         while ($current = shift @MRO) {
             last if $caller eq $current;
         }
-        
+
         no strict 'refs';
         my $found;
         foreach my $class (@MRO) {
-            next if (defined $Class::C3::MRO{$class} && 
-                     defined $Class::C3::MRO{$class}{methods}{$label});          
+            next if (defined $Class::C3::MRO{$class} &&
+                     defined $Class::C3::MRO{$class}{methods}{$label});
             last if (defined ($found = *{$class . '::' . $label}{CODE}));
         }
-    
+
         $found;
     };
 
@@ -60,7 +60,7 @@
 sub can { method($_[0]) }
 
 package  # hide me from PAUSE
-    maybe::next; 
+    maybe::next;
 
 use strict;
 use warnings;
@@ -101,6 +101,6 @@
 L<http://www.iinteractive.com>
 
 This library is free software; you can redistribute it and/or modify
-it under the same terms as Perl itself. 
+it under the same terms as Perl itself.
 
 =cut




More information about the Pkg-perl-cvs-commits mailing list