r53099 - in /trunk/dh-make-perl: TODO lib/DhMakePerl.pm

dmn at users.alioth.debian.org dmn at users.alioth.debian.org
Sat Feb 20 21:20:16 UTC 2010


Author: dmn
Date: Sat Feb 20 21:20:10 2010
New Revision: 53099

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=53099
Log:
convert $oldest_perl_version to a (constant) class method

this thing really should usue Debian::Control::FromCPAN

Modified:
    trunk/dh-make-perl/TODO
    trunk/dh-make-perl/lib/DhMakePerl.pm

Modified: trunk/dh-make-perl/TODO
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/dh-make-perl/TODO?rev=53099&op=diff
==============================================================================
--- trunk/dh-make-perl/TODO (original)
+++ trunk/dh-make-perl/TODO Sat Feb 20 21:20:10 2010
@@ -29,3 +29,4 @@
   in non-'3.0 (quilt)' source formats
 * Don't add libmodule-build-perl to Build-Depends if Makefile.PL is also
   present, if its not just Module::Build::Compat
+* --make should use Debian::Control::FromCPAN for dependencies

Modified: trunk/dh-make-perl/lib/DhMakePerl.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/dh-make-perl/lib/DhMakePerl.pm?rev=53099&op=diff
==============================================================================
--- trunk/dh-make-perl/lib/DhMakePerl.pm (original)
+++ trunk/dh-make-perl/lib/DhMakePerl.pm Sat Feb 20 21:20:10 2010
@@ -71,7 +71,7 @@
 # TODO:
 # * get more info from the package (maybe using CPAN methods)
 
-my ($oldest_perl_version, $debstdversion, $priority,
+my ($debstdversion, $priority,
     $section,             $depends,       $bdepends,
     $bdependsi,           $maintainer,    $arch,
     $closes,              $date,
@@ -86,7 +86,7 @@
 
 # this is the version in 'oldstable'. No much point on depending on something
 # older
-$oldest_perl_version = '5.8.8-7';
+use constant oldest_perl_version => '5.8.8-7';
 
 $bdependsi = Debian::Dependencies->new("perl");
 $arch      = 'all';
@@ -1105,7 +1105,10 @@
             print "= $module is a core module\n" if $self->cfg->verbose;
 
             $dep = Debian::Dependency->new( 'perl', $ver );
-            $debs->add($dep) if $dep->satisfies( "perl (>= $oldest_perl_version)" );
+            $debs->add($dep)
+                if $dep->satisfies(
+                        "perl (>= " . $self->oldest_perl_version . ")"
+                );
 
             next;
         }




More information about the Pkg-perl-cvs-commits mailing list