r58939 - in /trunk/libmediawiki-api-perl: Changes META.yml debian/changelog lib/MediaWiki/API.pm

[ansgar-guest at users.alioth.debian.org]

Author: ansgar-guest
Date: Sun Jun  6 05:17:33 2010
New Revision: 58939

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=58939
Log:
New upstream release.

Modified:
    trunk/libmediawiki-api-perl/Changes
    trunk/libmediawiki-api-perl/META.yml
    trunk/libmediawiki-api-perl/debian/changelog
    trunk/libmediawiki-api-perl/lib/MediaWiki/API.pm

Modified: trunk/libmediawiki-api-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmediawiki-api-perl/Changes?rev=58939&op=diff
==============================================================================
--- trunk/libmediawiki-api-perl/Changes (original)
+++ trunk/libmediawiki-api-perl/Changes Sun Jun  6 05:17:33 2010
@@ -1,4 +1,9 @@
 Revision history for MediaWiki-API
+
+0.32    2010-06-05
+        Config options passed when creating a new instance of the mediawiki api object were overwritten with default
+        values. Now fixed. Thanks to Brian for reporting this problem. Note the version number has been bumped twice
+        since I forgot to update this changes file for 0.31. oops.
 
 0.30    2010-04-08
         MediaWiki >= 1.15.3 and MediaWiki >= 1.16.0beta2 now require a login token to be sent when logging in. Please

Modified: trunk/libmediawiki-api-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmediawiki-api-perl/META.yml?rev=58939&op=diff
==============================================================================
--- trunk/libmediawiki-api-perl/META.yml (original)
+++ trunk/libmediawiki-api-perl/META.yml Sun Jun  6 05:17:33 2010
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name:               MediaWiki-API
-version:            0.30
+version:            0.32
 abstract:           Provides a Perl interface to the MediaWiki API (http://www.mediawiki.org/wiki/API)
 author:
     - Jools Wills <buzz at exotica.org.uk>

Modified: trunk/libmediawiki-api-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmediawiki-api-perl/debian/changelog?rev=58939&op=diff
==============================================================================
--- trunk/libmediawiki-api-perl/debian/changelog (original)
+++ trunk/libmediawiki-api-perl/debian/changelog Sun Jun  6 05:17:33 2010
@@ -1,3 +1,9 @@
+libmediawiki-api-perl (0.32-1) unstable; urgency=low
+
+  * New upstream release.
+
+ -- Ansgar Burchardt <ansgar at 43-1.org>  Sun, 06 Jun 2010 11:45:39 +0900
+
 libmediawiki-api-perl (0.30-1) unstable; urgency=low
 
   * New upstream release.

Modified: trunk/libmediawiki-api-perl/lib/MediaWiki/API.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libmediawiki-api-perl/lib/MediaWiki/API.pm?rev=58939&op=diff
==============================================================================
--- trunk/libmediawiki-api-perl/lib/MediaWiki/API.pm (original)
+++ trunk/libmediawiki-api-perl/lib/MediaWiki/API.pm Sun Jun  6 05:17:33 2010
@@ -40,11 +40,11 @@
 
 =head1 VERSION
 
-Version 0.30
-
-=cut
-
-our $VERSION  = "0.30";
+Version 0.32
+
+=cut
+
+our $VERSION  = "0.32";
 
 =head1 SYNOPSIS
 
@@ -168,6 +168,13 @@
 sub new {
 
   my ($class, $config) = @_;
+  
+  # if no config passed make a new hash reference and get the default configuration parameters
+  $config = {} if ! defined $config;
+  my $defconfig = _get_config_defaults();
+
+  $config = {%$defconfig, %$config};
+
   my $self = { config => $config  };
 
   my $ua = LWP::UserAgent->new();
@@ -181,22 +188,29 @@
   my $json = JSON->new->utf8()->max_depth(10) ;
   $self->{json} = $json;
 
-  # initialise some defaults
+  # initialise error code values
   $self->{error}->{code} = 0;
   $self->{error}->{details} = '';
   $self->{error}->{stacktrace} = '';
 
-  $self->{config}->{retries} = DEF_RETRIES;
-  $self->{config}->{retry_delay} = DEF_RETRY_DELAY;
-
-  $self->{config}->{max_lag} = DEF_MAX_LAG;
-  $self->{config}->{max_lag_retries} = DEF_MAX_LAG_RETRIES;
-  $self->{config}->{max_lag_delay} = DEF_MAX_LAG_DELAY;
-  
-  $self->{config}->{use_http_get} = USE_HTTP_GET;
-
   bless ($self, $class);
   return $self;
+}
+
+# returns a hashref with configuration defaults
+sub _get_config_defaults {
+  my %config;
+
+  $config{retries} = DEF_RETRIES;
+  $config{retry_delay} = DEF_RETRY_DELAY;
+
+  $config{max_lag} = DEF_MAX_LAG;
+  $config{max_lag_retries} = DEF_MAX_LAG_RETRIES;
+  $config{max_lag_delay} = DEF_MAX_LAG_DELAY;
+  
+  $config{use_http_get} = USE_HTTP_GET;
+
+  return \%config;
 }
 
 =head2 MediaWiki::API->login( $query_hashref )