r69760 - in /branches/upstream/libnet-twitter-perl/current: ./ lib/Net/ lib/Net/Twitter/ lib/Net/Twitter/Role/ lib/Net/Twitter/Role/API/ t/

jawnsy-guest at users.alioth.debian.org jawnsy-guest at users.alioth.debian.org
Sat Feb 26 16:10:41 UTC 2011


Author: jawnsy-guest
Date: Sat Feb 26 16:10:21 2011
New Revision: 69760

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=69760
Log:
[svn-upgrade] new version libnet-twitter-perl (3.15000)

Modified:
    branches/upstream/libnet-twitter-perl/current/Changes
    branches/upstream/libnet-twitter-perl/current/META.yml
    branches/upstream/libnet-twitter-perl/current/Makefile.PL
    branches/upstream/libnet-twitter-perl/current/README
    branches/upstream/libnet-twitter-perl/current/lib/Net/Identica.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pod
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/API.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Core.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/OAuth.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/Lists.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/REST.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/Legacy.pm
    branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Search.pm
    branches/upstream/libnet-twitter-perl/current/t/lookup_users.t

Modified: branches/upstream/libnet-twitter-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/Changes?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/Changes (original)
+++ branches/upstream/libnet-twitter-perl/current/Changes Sat Feb 26 16:10:21 2011
@@ -1,3 +1,7 @@
+3.15000 2011-02-25
+    - added Lists API method members_create_all (alias add_list_members)
+    - added tests dependency: Test::Exception (closes RT #65786)
+
 3.14003 2011-02-07
     - Fixed: trends_location (closes RT #65506)
     - Added parameters trim_user, include_entities, include_rts (frank cuny, closes RT #62542)

Modified: branches/upstream/libnet-twitter-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/META.yml?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/META.yml (original)
+++ branches/upstream/libnet-twitter-perl/current/META.yml Sat Feb 26 16:10:21 2011
@@ -4,6 +4,7 @@
   - 'Marc Mims <marc at questright.com> (@semifor on Twitter)'
 build_requires:
   ExtUtils::MakeMaker: 6.42
+  Test::Exception: 0
   Test::More: 0.88
 configure_requires:
   ExtUtils::MakeMaker: 6.42
@@ -55,4 +56,4 @@
   homepage: http://github.com/semifor/Net-Twitter
   license: http://dev.perl.org/licenses/
   repository: git://github.com/semifor/Net-Twitter.git
-version: 3.14003
+version: 3.15000

Modified: branches/upstream/libnet-twitter-perl/current/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/Makefile.PL?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/Makefile.PL (original)
+++ branches/upstream/libnet-twitter-perl/current/Makefile.PL Sat Feb 26 16:10:21 2011
@@ -44,6 +44,7 @@
 requires    'URI::Escape';
 requires    'Try::Tiny'                 => 0.03;
 
+test_requires 'Test::Exception';
 test_requires 'Test::More' => 0.88; # for done_testing
 
 # Don't rely on the JSON::Any requirement to pull in a suitable JSON backend.

Modified: branches/upstream/libnet-twitter-perl/current/README
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/README?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/README (original)
+++ branches/upstream/libnet-twitter-perl/current/README Sat Feb 26 16:10:21 2011
@@ -2,7 +2,7 @@
     Net::Twitter - A perl interface to the Twitter API
 
 VERSION
-    This document describes Net::Twitter version 3.14003
+    This document describes Net::Twitter version 3.15000
 
 SYNOPSIS
       use Net::Twitter;
@@ -1749,6 +1749,21 @@
 
         Returns:
 
+    members_create_all
+    members_create_all(user, list_id)
+    alias: add_list_members
+
+        Parameters: user, list_id, screen_name, user_id
+        Required: user, list_id
+
+        Adds multiple users "id" to the list. Users are specified with the
+        "screen_name" or "user_id" parameter with a reference to an ARRAY of
+        values.
+
+        Returns a reference the added user as a hash reference.
+
+        Returns: ArrayRef[User]
+
     subscribe_list
     subscribe_list(user, list_id)
 

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Identica.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Identica.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Identica.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Identica.pm Sat Feb 26 16:10:21 2011
@@ -2,7 +2,7 @@
 use Moose;
 
 # use *all* digits for fBSD ports
-our $VERSION = '3.14003';
+our $VERSION = '3.15000';
 $VERSION     = eval $VERSION; # numify for warning-free dev releases
 
 extends 'Net::Twitter::Core';

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pm Sat Feb 26 16:10:21 2011
@@ -11,7 +11,7 @@
 );
 
 # use *all* digits for fBSD ports
-our $VERSION = '3.14003';
+our $VERSION = '3.15000';
 
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 
@@ -21,7 +21,7 @@
 # with the 'Legacy' trait.
 
 # transform_trait and resolve_traits stolen from MooseX::Traits
-my $transform_trait = sub {
+sub _transform_trait {
     my ($class, $name) = @_;
     my $namespace = $class->meta->find_attribute_by_name('_trait_namespace');
     my $base;
@@ -35,39 +35,39 @@
     return $name unless $base;
     return $1 if $name =~ /^[+](.+)$/;
     return "$base\::$name";
-};
+}
 
-my $resolve_traits = sub {
+sub _resolve_traits {
     my ($class, @traits) = @_;
     return map {
-        my $transformed = $class->$transform_trait($_);
+        my $transformed = $class->_transform_trait($_);
         Class::MOP::load_class($transformed);
         $transformed;
     } @traits;
-};
+}
 
-my $isa = sub {
+sub _isa {
     my $self = shift;
     my $isa  = shift;
 
     return $isa eq __PACKAGE__ || $self->SUPER::isa($isa)
 };
 
-my $create_anon_class = sub {
+sub _create_anon_class {
     my ($superclasses, $traits, $immutable, $package) = @_;
 
     my $meta;
     $meta = Net::Twitter::Core->meta->create_anon_class(
         superclasses => $superclasses,
         roles        => $traits,
-        methods      => { meta => sub { $meta }, isa => $isa },
+        methods      => { meta => sub { $meta }, isa => \&_isa },
         cache        => 1,
         package      => $package,
     );
     $meta->make_immutable(inline_constructor => $immutable);
 
     return $meta;
-};
+}
 
 sub new {
     my $class = shift;
@@ -93,10 +93,10 @@
     my $package_suffix = 'with__' . join '__',
        map { (my $part = $_) =~ s/::/_/g; $part =~ s/\W//; $part } sort @$traits;
 
-    $traits = [ $class->$resolve_traits(@$traits) ];
+    $traits = [ $class->_resolve_traits(@$traits) ];
 
     my $superclasses = [ 'Net::Twitter::Core' ];
-    my $meta = $create_anon_class->($superclasses, $traits, 1, __PACKAGE__ . '::' . $package_suffix);
+    my $meta = _create_anon_class($superclasses, $traits, 1, __PACKAGE__ . '::' . $package_suffix);
 
     # create a Net::Twitter::Core object with roles applied
     my $new = $meta->name->new(%args);
@@ -104,7 +104,7 @@
     # rebless it to include a superclass, if we're being subclassed
     if ( $class ne __PACKAGE__ ) {
         unshift @$superclasses, $class;
-        my $final_meta = $create_anon_class->(
+        my $final_meta = _create_anon_class(
             $superclasses, $traits, 0, join '::', $class, __PACKAGE__, $package_suffix
         );
         bless $new, $final_meta->name;

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pod
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pod?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pod (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter.pod Sat Feb 26 16:10:21 2011
@@ -4,7 +4,7 @@
 
 =head1 VERSION
 
-This document describes Net::Twitter version 3.14003
+This document describes Net::Twitter version 3.15000
 
 =head1 SYNOPSIS
 
@@ -2571,6 +2571,30 @@
 
 Returns: 
 
+=item B<members_create_all>
+
+=item B<members_create_all(user, list_id)>
+
+
+=item alias: add_list_members
+
+
+=over 4
+
+=item Parameters: user, list_id, screen_name, user_id
+
+=item Required: user, list_id
+
+=back
+
+Adds multiple users C<id> to the list. Users are specified with the C<screen_name>
+or C<user_id> parameter with a reference to an ARRAY of values.
+
+Returns a reference the added user as a hash reference.
+
+
+Returns: ArrayRef[User]
+
 =item B<subscribe_list>
 
 =item B<subscribe_list(user, list_id)>

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/API.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/API.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/API.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/API.pm Sat Feb 26 16:10:21 2011
@@ -42,6 +42,11 @@
 
         # copy callers args since we may add ->{source}
         my $args = ref $_[-1] eq 'HASH' ? { %{pop @_} } : {};
+
+        # flatten array arguments
+        for ( qw/user_id screen_name/ ) {
+            $args->{$_} = join ',' => @{ $args->{$_} } if ref $args->{$_} eq 'ARRAY';
+        }
 
         croak sprintf "$name expected %d args", scalar @$arg_names if @_ > @$arg_names;
 

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Core.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Core.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Core.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Core.pm Sat Feb 26 16:10:21 2011
@@ -18,7 +18,7 @@
 use namespace::autoclean;
 
 # use *all* digits for fBSD ports
-our $VERSION = '3.14003';
+our $VERSION = '3.15000';
 
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/OAuth.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/OAuth.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/OAuth.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/OAuth.pm Sat Feb 26 16:10:21 2011
@@ -2,7 +2,7 @@
 use Moose;
 
 # use *all* digits for fBSD ports
-our $VERSION = '3.14003';
+our $VERSION = '3.15000';
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 
 extends  'Net::Twitter::Core';

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/Lists.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/Lists.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/Lists.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/Lists.pm Sat Feb 26 16:10:21 2011
@@ -33,6 +33,7 @@
   $user_or_undef = $nt->list_members($owner, $list_id, { id => $user_id });
 
   $user = $nt->add_list_member($owner, $list_id, $user_id);
+  $users = $nt->add_list_members($owner, $list_id, { screen_name => \@screen_names });
 
   $user = $nt->delete_list_member($owner, $list_id, $user_id);
   $user = $nt->remove_list_member($owner, $list_id, $user_id);
@@ -247,6 +248,21 @@
     required    => [qw/user list_id id/],
     description => <<'EOT',
 Adds the user identified by C<id> to the list.
+
+Returns a reference the added user as a hash reference.
+EOT
+);
+
+twitter_api_method members_create_all => (
+    aliases     => [qw/add_list_members/],
+    path        => ':user/:list_id/members/create_all',
+    method      => 'POST',
+    returns     => 'ArrayRef[User]',
+    params      => [qw/user list_id screen_name user_id/],
+    required    => [qw/user list_id/],
+    description => <<'EOT',
+Adds multiple users C<id> to the list. Users are specified with the C<screen_name>
+or C<user_id> parameter with a reference to an ARRAY of values.
 
 Returns a reference the added user as a hash reference.
 EOT

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/REST.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/REST.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/REST.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/API/REST.pm Sat Feb 26 16:10:21 2011
@@ -2,17 +2,18 @@
 use Moose::Role;
 use Net::Twitter::API;
 use DateTime::Format::Strptime;
+use URI;
 
 requires qw/ua username password credentials/;
 
-my $build_api_host = sub {
+has apiurl          => ( isa => 'Str', is => 'ro', default => 'http://api.twitter.com/1'  );
+has apihost         => ( isa => 'Str', is => 'ro', lazy => 1, builder => '_build_apihost' );
+has apirealm        => ( isa => 'Str', is => 'ro', default => 'Twitter API'               );
+
+sub _build_apihost {
     my $uri = URI->new(shift->apiurl);
     join ':', $uri->host, $uri->port;
-};
-
-has apiurl          => ( isa => 'Str', is => 'ro', default => 'http://api.twitter.com/1'  );
-has apihost         => ( isa => 'Str', is => 'ro', lazy => 1, default => $build_api_host  );
-has apirealm        => ( isa => 'Str', is => 'ro', default => 'Twitter API'               );
+}
 
 after BUILD => sub {
     my $self = shift;
@@ -1085,7 +1086,7 @@
 
 );
 
-# new in 3.14003 2010-10-19
+# new in 3.15000 2010-10-19
 
 twitter_api_method account_totals => (
     path        => 'account/totals',
@@ -1238,22 +1239,6 @@
 
 );
 
-for ( qw/lookup_users lookup_friendships/ ) {
-    around $_ => sub {
-        my $orig = shift;
-        my $self = shift;
-
-        my $args = ref $_[-1] eq 'HASH' ? pop @_ : {};
-        $args = { %$args, @_ };
-
-        for ( qw/screen_name user_id/ ) {
-            $args->{$_} = join(',' => @{ $args->{$_} }) if ref $args->{$_} eq 'ARRAY';
-        }
-
-        return $orig->($self, $args);
-    };
-}
-
 1;
 
 __END__

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/Legacy.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/Legacy.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/Legacy.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Role/Legacy.pm Sat Feb 26 16:10:21 2011
@@ -10,15 +10,14 @@
     WrapError
 /;
 
-my $set_error_return_val = sub {
+has arrayref_on_error => ( isa => 'Bool', is => 'rw', default => 0, trigger => \&_set_error_return_val );
+has twittervision     => ( isa => 'Bool', is => 'rw', default => 0 );
+
+sub _set_error_return_val {
     my $self = shift;
 
     $self->_error_return_val($self->arrayref_on_error ? [] : undef);
-};
-
-has arrayref_on_error => ( isa => 'Bool', is => 'rw', default => 0,
-                           trigger => sub { shift->$set_error_return_val } );
-has twittervision     => ( isa => 'Bool', is => 'rw', default => 0 );
+}
 
 # Legacy Net::Twitter does not make the call unless twittervision is true.
 # Bug or feature?

Modified: branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Search.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Search.pm?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Search.pm (original)
+++ branches/upstream/libnet-twitter-perl/current/lib/Net/Twitter/Search.pm Sat Feb 26 16:10:21 2011
@@ -2,7 +2,7 @@
 use Moose;
 
 # use *all* digits for fBSD ports
-our $VERSION = '3.14003';
+our $VERSION = '3.15000';
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 
 extends 'Net::Twitter::Core';

Modified: branches/upstream/libnet-twitter-perl/current/t/lookup_users.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libnet-twitter-perl/current/t/lookup_users.t?rev=69760&op=diff
==============================================================================
--- branches/upstream/libnet-twitter-perl/current/t/lookup_users.t (original)
+++ branches/upstream/libnet-twitter-perl/current/t/lookup_users.t Sat Feb 26 16:10:21 2011
@@ -13,32 +13,32 @@
 my @tests = (
     {
         args   => [ { user_id => '1234,6543,3333' } ],
-        expect => { user_id => [ 1234, 6543, 3333 ] },
+        expect => { user_id => '1234,6543,3333' },
         name   => 'hash: comma delimited',
     },
     {
-        args   => [ user_id => '1234,6543,3333' ],
-        expect => { user_id => [ 1234, 6543, 3333 ] },
+        args   => [ { user_id => '1234,6543,3333' } ],
+        expect => { user_id => '1234,6543,3333' },
         name   => 'list: comma delimited',
     },
     {
         args   => [ { user_id => [ 1234, 6543, 3333 ] } ],
-        expect => { user_id => [ 1234, 6543, 3333 ] },
+        expect => { user_id => '1234,6543,3333' },
         name   => 'hash: arrayref',
     },
     {
         args   => [ { screen_name => 'fred,barney,wilma' } ],
-        expect => { screen_name => [qw/fred barney wilma/] },
+        expect => { screen_name => 'fred,barney,wilma' },
         name   => 'hash: comma delimited',
     },
     {
-        args   => [ screen_name => ['fred', 'barney', 'wilma'] ],
-        expect => { screen_name => [qw/fred barney wilma/] },
+        args   => [ { screen_name => ['fred', 'barney', 'wilma'] } ],
+        expect => { screen_name => 'fred,barney,wilma' },
         name   => 'list: arrayref',
     },
     {
-        args   => [ screen_name => ['fred', 'barney' ], user_id => '4321,6789' ],
-        expect => { screen_name => [qw/fred barney/], user_id => [ 4321, 6789 ] },
+        args   => [ { screen_name => ['fred', 'barney' ], user_id => '4321,6789' } ],
+        expect => { screen_name => 'fred,barney', user_id => '4321,6789' },
         name   => 'list: arrayref screen_name and comma delimited user_id',
     },
 );
@@ -63,7 +63,7 @@
 
     my %query = $req->uri->query_form;
     for my $arg ( keys %{ $test->{expect} } ) {
-        cmp_bag([ split /,/, $query{$arg} ], $test->{expect}{$arg}, "$test->{name} [$arg]");
+        is $query{$arg}, $test->{expect}{$arg}, "$test->{name} [$arg]";
     }
 }
 




More information about the Pkg-perl-cvs-commits mailing list