r76855 - in /trunk/libcurses-ui-perl/debian/patches: 01_remove_solaris_hack.patch 02_feedkeys.patch

[dmn at users.alioth.debian.org]

Author: dmn
Date: Fri Jul  1 09:23:30 2011
New Revision: 76855

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=76855
Log:
describe two patches from antgel

Modified:
    trunk/libcurses-ui-perl/debian/patches/01_remove_solaris_hack.patch
    trunk/libcurses-ui-perl/debian/patches/02_feedkeys.patch

Modified: trunk/libcurses-ui-perl/debian/patches/01_remove_solaris_hack.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcurses-ui-perl/debian/patches/01_remove_solaris_hack.patch?rev=76855&op=diff
==============================================================================
--- trunk/libcurses-ui-perl/debian/patches/01_remove_solaris_hack.patch (original)
+++ trunk/libcurses-ui-perl/debian/patches/01_remove_solaris_hack.patch Fri Jul  1 09:23:30 2011
@@ -1,4 +1,25 @@
-## 01_remove_solaris_hack.patch by  <antony.gelberg at gmail.com>
+Description: no force-feeding keys
+ I have a reasonably large application that uses Curses::UI and
+ Curses::UI::POE.  When keyboard input is buffered because the app is
+ blocking, things get out of sync when the app returns - keys get "lost"
+ and the app is thereafter "one key behind".
+ .
+ The problem was eventually narrowed down to the following part of UI.pm:
+ .
+ # See if there are pending keys on input. If I do not
+ # feed them to the application in this way, the screen
+ # hangs in case I do a lot of input on my Solaris
+ # machine.
+    $key = $self->get_key(0);
+    $self->feedkey($key) unless $key eq '-1';
+ .
+ This is something of a hack.  On my Linux machine, commenting out the
+ above causes correct behaviour, whereby keypresses are buffered and
+ dealt with when the app returns from its blocking behaviour.  Are you
+ sure this isn't a workaround for a Solaris "feature"?
+Author: Antony Gelberg <antony.gelberg at gmail.com>
+Bug: https://rt.cpan.org/Ticket/Display.html?id=51625
+Forwarded: yes
 
 --- a/lib/Curses/UI.pm
 +++ b/lib/Curses/UI.pm

Modified: trunk/libcurses-ui-perl/debian/patches/02_feedkeys.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcurses-ui-perl/debian/patches/02_feedkeys.patch?rev=76855&op=diff
==============================================================================
--- trunk/libcurses-ui-perl/debian/patches/02_feedkeys.patch (original)
+++ trunk/libcurses-ui-perl/debian/patches/02_feedkeys.patch Fri Jul  1 09:23:30 2011
@@ -1,4 +1,11 @@
-## 02_flushkeys.patch by  <antony.gelberg at gmail.com>
+Description: do not flush in feedkey()
+ In a similar vein to #51625, there is an extraneous function call that
+ breaks input when keys are buffered.  The call to flushkeys() from
+ feedkey() simply throws keys away for no discernable reason.  Removing
+ the call fixes the problem, at least on my system.
+Author: Antony Gelberg <antony.gelberg at gmail.com>
+Bug: https://rt.cpan.org/Ticket/Display.html?id=51644
+Forwarded: yes
 
 --- a/lib/Curses/UI.pm
 +++ b/lib/Curses/UI.pm