r71401 - in /trunk/libtest-html-w3c-perl/debian: changelog patches/diag_html.patch patches/series

[periapt-guest at users.alioth.debian.org]

Author: periapt-guest
Date: Mon Mar 14 13:21:12 2011
New Revision: 71401

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=71401
Log:
Handle case where no sensible output returned from validator.
Previously this caused the 'diag_html' method to crash. (Closes: #618335)

Added:
    trunk/libtest-html-w3c-perl/debian/patches/diag_html.patch
Modified:
    trunk/libtest-html-w3c-perl/debian/changelog
    trunk/libtest-html-w3c-perl/debian/patches/series

Modified: trunk/libtest-html-w3c-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libtest-html-w3c-perl/debian/changelog?rev=71401&op=diff
==============================================================================
--- trunk/libtest-html-w3c-perl/debian/changelog (original)
+++ trunk/libtest-html-w3c-perl/debian/changelog Mon Mar 14 13:21:12 2011
@@ -1,3 +1,10 @@
+libtest-html-w3c-perl (0.03-2) UNRELEASED; urgency=low
+
+  * Handle case where no sensible output returned from validator.
+    Previously this caused the 'diag_html' method to crash. (Closes: #618335)
+
+ -- Nicholas Bamber <nicholas at periapt.co.uk>  Mon, 14 Mar 2011 13:05:06 +0000
+
 libtest-html-w3c-perl (0.03-1) unstable; urgency=low
 
   * Initial Release. (Closes: #608824)

Added: trunk/libtest-html-w3c-perl/debian/patches/diag_html.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libtest-html-w3c-perl/debian/patches/diag_html.patch?rev=71401&op=file
==============================================================================
--- trunk/libtest-html-w3c-perl/debian/patches/diag_html.patch (added)
+++ trunk/libtest-html-w3c-perl/debian/patches/diag_html.patch Mon Mar 14 13:21:12 2011
@@ -1,0 +1,26 @@
+Author: Nicholas Bamber <nicholas at periapt.co.uk>
+Subject: Invalid response from service not handled correctly
+Last-Update: 2011-03-14
+
+--- a/lib/Test/HTML/W3C.pm
++++ b/lib/Test/HTML/W3C.pm
+@@ -224,10 +224,15 @@
+ sub diag_html {
+     my $tb = __PACKAGE__->builder();
+     if ($show_detail) {
+-        my @errs = $v->errors();
+-        my $e;
+-        foreach my $error ( @{$v->errors()} ) {
+-             $e .= sprintf("%s at line %d\n", $error->msg, $error->line);
++        my $e = "";
++        if ($v->errors()) {
++            my @errs = @{$v->errors()};
++            foreach my $error ( @errs ) {
++                $e .= sprintf("%s at line %d\n", $error->msg, $error->line);
++            }
++        }
++        else {
++            $e .= $v->validator_error;
+         }
+         $tb->diag($e);
+     } else {

Modified: trunk/libtest-html-w3c-perl/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libtest-html-w3c-perl/debian/patches/series?rev=71401&op=diff
==============================================================================
--- trunk/libtest-html-w3c-perl/debian/patches/series (original)
+++ trunk/libtest-html-w3c-perl/debian/patches/series Mon Mar 14 13:21:12 2011
@@ -1,1 +1,2 @@
 replace_boilerplate_text.patch
+diag_html.patch