r71740 - in /branches/upstream/libclass-c3-componentised-perl/current: Changes MANIFEST META.yml Makefile.PL lib/Class/C3/Componentised.pm t/03-unstable_dollar_underscore.t t/lib/DestroyDollarUnderscore.pm

jawnsy-guest at users.alioth.debian.org jawnsy-guest at users.alioth.debian.org
Sun Mar 20 12:11:20 UTC 2011 

Author: jawnsy-guest
Date: Sun Mar 20 12:10:57 2011
New Revision: 71740

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=71740
Log:
[svn-upgrade] new version libclass-c3-componentised-perl (1.0009)

Added:
    branches/upstream/libclass-c3-componentised-perl/current/t/03-unstable_dollar_underscore.t
    branches/upstream/libclass-c3-componentised-perl/current/t/lib/DestroyDollarUnderscore.pm
Modified:
    branches/upstream/libclass-c3-componentised-perl/current/Changes
    branches/upstream/libclass-c3-componentised-perl/current/MANIFEST
    branches/upstream/libclass-c3-componentised-perl/current/META.yml
    branches/upstream/libclass-c3-componentised-perl/current/Makefile.PL
    branches/upstream/libclass-c3-componentised-perl/current/lib/Class/C3/Componentised.pm

Modified: branches/upstream/libclass-c3-componentised-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/Changes?rev=71740&op=diff
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/Changes (original)
+++ branches/upstream/libclass-c3-componentised-perl/current/Changes Sun Mar 20 12:10:57 2011
@@ -1,4 +1,11 @@
 Revision history for Class-C3-Componentised
+
+1.0009   20 Mar 2011
+      - Stop importing Carp functions (and thus polluting the inheritor
+        namespaces)
+      - Make sure $_ is properly preserved even if the loaded module
+        is negligent enough to change it (RT#66661)
+      - Added missing copyright statement
 
 1.0008   24 Feb 2011
         Fix inject_base regression introduced during optimizations in

Modified: branches/upstream/libclass-c3-componentised-perl/current/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/MANIFEST?rev=71740&op=diff
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/MANIFEST (original)
+++ branches/upstream/libclass-c3-componentised-perl/current/MANIFEST Sun Mar 20 12:10:57 2011
@@ -15,6 +15,8 @@
 t/00-load.t
 t/01-basic.t
 t/02-explicit.t
+t/03-unstable_dollar_underscore.t
+t/lib/DestroyDollarUnderscore.pm
 t/lib/MyModule.pm
 t/lib/MyModule/ErrorComponent.pm
 t/lib/MyModule/OwnComponent.pm

Modified: branches/upstream/libclass-c3-componentised-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/META.yml?rev=71740&op=diff
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/META.yml (original)
+++ branches/upstream/libclass-c3-componentised-perl/current/META.yml Sun Mar 20 12:10:57 2011
@@ -4,7 +4,6 @@
   - 'Ash Berlin <ash at cpan.org>'
 build_requires:
   ExtUtils::MakeMaker: 6.42
-  FindBin: 0
 configure_requires:
   ExtUtils::MakeMaker: 6.42
 distribution_type: module
@@ -27,4 +26,4 @@
   perl: 5.6.2
 resources:
   license: http://dev.perl.org/licenses/
-version: 1.0008
+version: 1.0009

Modified: branches/upstream/libclass-c3-componentised-perl/current/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/Makefile.PL?rev=71740&op=diff
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/Makefile.PL (original)
+++ branches/upstream/libclass-c3-componentised-perl/current/Makefile.PL Sun Mar 20 12:10:57 2011
@@ -22,6 +22,4 @@
 # will need adjustment if the require is removed
 requires  'Class::C3' => '0.20';
 
-build_requires 'FindBin';
-
 WriteAll;

Modified: branches/upstream/libclass-c3-componentised-perl/current/lib/Class/C3/Componentised.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/lib/Class/C3/Componentised.pm?rev=71740&op=diff
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/lib/Class/C3/Componentised.pm (original)
+++ branches/upstream/libclass-c3-componentised-perl/current/lib/Class/C3/Componentised.pm Sun Mar 20 12:10:57 2011
@@ -47,9 +47,9 @@
 # Therefore leaving it in indefinitely.
 use MRO::Compat;
 
-use Carp;
-
-our $VERSION = 1.0008;
+use Carp ();
+
+our $VERSION = 1.0009;
 
 my $invalid_class = qr/(?: \b:\b | \:{3,} | \:\:$ )/x;
 
@@ -142,16 +142,16 @@
     return if ( *{"${f_class}::$_"}{CODE} );
   }
 
-
   # require always returns true on success
-  eval { require($file) } or do {
+  # ill-behaved modules might very well obliterate $_
+  eval { local $_; require($file) } or do {
 
     $@ = "Invalid class name '$f_class'" if $f_class =~ $invalid_class;
 
     if ($class->can('throw_exception')) {
       $class->throw_exception($@);
     } else {
-      croak $@;
+      Carp::croak $@;
     }
   };
 
@@ -232,12 +232,20 @@
   }
 }
 
-=head1 AUTHOR
-
-Matt S. Trout and the DBIx::Class team
+=head1 AUTHORS
+
+Matt S. Trout and the L<DBIx::Class team|DBIx::Class/CONTRIBUTORS>
 
 Pulled out into seperate module by Ash Berlin C<< <ash at cpan.org> >>
 
+Optimizations and overall bolt-tightening by Peter "ribasushi" Rabbitson
+C<< <ribasushi at cpan.org> >>
+
+=head1 COPYRIGHT
+
+Copyright (c) 2006 - 2011 the Class::C3::Componentised L</AUTHORS> as listed
+above.
+
 =head1 LICENSE
 
 You may distribute this code under the same terms as Perl itself.

Added: branches/upstream/libclass-c3-componentised-perl/current/t/03-unstable_dollar_underscore.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/t/03-unstable_dollar_underscore.t?rev=71740&op=file
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/t/03-unstable_dollar_underscore.t (added)
+++ branches/upstream/libclass-c3-componentised-perl/current/t/03-unstable_dollar_underscore.t Sun Mar 20 12:10:57 2011
@@ -1,0 +1,18 @@
+use strict;
+use warnings;
+
+use Class::C3::Componentised;
+use Test::More;
+use FindBin;
+
+use lib "$FindBin::Bin/lib";
+
+my @mods = 'DestroyDollarUnderscore';
+
+for (@mods) {
+  Class::C3::Componentised->ensure_class_loaded($_);
+}
+
+is_deeply(\@mods, [ 'DestroyDollarUnderscore' ], '$_ untouched');
+
+done_testing;

Added: branches/upstream/libclass-c3-componentised-perl/current/t/lib/DestroyDollarUnderscore.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libclass-c3-componentised-perl/current/t/lib/DestroyDollarUnderscore.pm?rev=71740&op=file
==============================================================================
--- branches/upstream/libclass-c3-componentised-perl/current/t/lib/DestroyDollarUnderscore.pm (added)
+++ branches/upstream/libclass-c3-componentised-perl/current/t/lib/DestroyDollarUnderscore.pm Sun Mar 20 12:10:57 2011
@@ -1,0 +1,8 @@
+package DestroyDollarUnderscore;
+
+use warnings;
+use strict;
+
+undef ($_);
+
+1;

More information about the Pkg-perl-cvs-commits mailing list