r74177 - /trunk/pperl/debian/changelog

[gregoa at users.alioth.debian.org]

Author: gregoa
Date: Tue May 10 16:48:13 2011
New Revision: 74177

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=74177
Log:
d/changelog: propose a fix for the intermittent test failure in t/11autoclose.t

Modified:
    trunk/pperl/debian/changelog

Modified: trunk/pperl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/pperl/debian/changelog?rev=74177&op=diff
==============================================================================
--- trunk/pperl/debian/changelog (original)
+++ trunk/pperl/debian/changelog Tue May 10 16:48:13 2011
@@ -2,6 +2,25 @@
 
    FIXME: tests fail leaving background processes when built outside of
    chroot (dam)
+   
+   The error is about:
+     ok(S_IMODE($mode), 0644);
+   My usual umask is 0002, with this setting I trigger the error; if I  
+   set "umask 0022" and then call dpkg-buildpackage, the test suite
+   passes. - Setting it in d/rules doesn't seem to help
+   
+   and this check is added in debian/patches/287119_no-umask0.patch because of
+   #287119
+   
+   my current guess is that the check is too strict ...; AIUI this is about
+   not creating world-writable files, so 664 and 644 should both be fine;
+   actually the patch removes changing the umask, so maybe we can save it and
+   check it's the same afterwards?
+   
+   after reading `perldoc perlfunc' --> stat(): the following seems to work:
+   - ok(S_IMODE($mode), 0644);
+   + ok(( $mode & S_IWOTH ) ? 0 : 1) # not world-writable
+   (passes with umask 0002 and 0022, fails with 0000)
    
   [ Damyan Ivanov ]
   * Take over for the Debian Perl Group on maintainer's request