[SCM] Debian branch, master, updated. debian/1.2.2-2-9-g4ee8d07

[Florian Schlichting]

The following commit has been merged in the master branch:
commit 4ee8d07348ceb759909bae32d3b3c62c2a87d985
Author: Florian Schlichting <fschlich at zedat.fu-berlin.de>
Date:   Mon Dec 10 22:05:04 2012 +0100

    back to UNRELEASED, TODO and comments added to changelog

diff --git a/debian/changelog b/debian/changelog
index 12c820b..b6b9b8d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,68 @@
-lemonldap-ng (1.2.2-3) unstable; urgency=low
+lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
+
+  TODO:
+  - debian/copyright:
+    + copyright information is incomplete, e.g.
+      lemonldap-ng-manager/example/skins/default/ui-darkness/jquery-ui-1.8.6.custom.css
+      or the files under scripts/
+    + the license information for e.g. jquery.cookie.js or the icons in
+      lemonldap-ng-portal/example/skins/common/apps/ does not agree with
+      what's documented in the source of those files / README
+    + there is no file in the source package that "Files: jquery.base64.js"
+      applies to (missing path or globbing)
+    + copyright-format 1.0 specifies that the *last* matching paragraph
+      applies (reverse sorting)
+  - debian/control:
+    + the short description does not fit the recommended "<package> is a ..."
+      format
+    + the long description is very short and not very informative. It does not
+      explain what "SSO" stands for, it could mention what authentication
+      sources are supported (probably LDAP, due to its name, any others?), and
+      it would be useful to know how it compares to other Single Sign-On system
+      such as Shibboleth or OpenID
+    + embedded code copies have been removed and replaced with links to their
+      standard location in the jquery* packages. Would it be helpful to provide
+      some sort of dependency on those packages? Also, the jquery* code removal
+      seems somewhat incomplete.
+  - there are a number of experimental lintian complaints about duplicate
+    files, mostly images. Perhaps these could be replaced with symlinks.
+  - I see that your fix for #694890 solves the piuparts issue, but I don't
+    understand why removing everything (and still setting
+    "HANDLERDIR=/var/lib/lemonldap-ng/handler/" during build) is the best
+    possible approach. "Apache configuration and default handler" sounds more
+    like a necessary component of a working application rather than just an
+    example? Perhaps you could give a little more rationale for what you're
+    doing in your commit messages... :-)
+  - you added a #DEBHELPER# token in the right place in the maintainer
+    scripts, but they still contain a second instance of that token in the
+    commented line at the top. I'm afraid this will result in breakage should
+    debhelper try to substitute a multi-line code block
+  - the custom version test for versions 0.9 and newer in
+    liblemonldap-ng-conf-perl.{config,postinst} could be made more robust
+    by using something like 'if dpkg --compare-versions $2 ge 0.9'
+  - debian/liblemonldap-ng-conf-perl.postinst and
+    debian/liblemonldap-ng-portal-perl.postinst contain commands to change
+    ownership and permissions. You have removed the unsafe "chown -R", but I
+    think all of that should be done at build time (from debian/rules), which
+    would also help to preserve local changes to those ownerships and
+    permissions, e.g. those which the admin configured using
+    dpkg-statoverride.
+  - README.Debian advises to make DNS related configuration changes to
+    /var/lib/lemonldap-ng/conf/lmConf-1 and
+    /var/lib/lemonldap-ng/test/index.pl. While the latter doesn't exist any
+    more, the former looks an awful lot like local configuration and thus
+    should be moved to /etc to preserve local changes over package upgrades.
+  - the webapps policy is still a draft document, but in its current state it
+    seems to mandate that what lemonldap-ng puts under /var/lib/lemonldap-ng be
+    put into /usr/share/<package> subdirectories, where some scripts already
+    seem to be symlinked from...??
+    (see: http://webapps-common.alioth.debian.org/draft/html/ch-issues.html)
+  - There is a substantial amount of examples, including (apparently several)
+    complete sites. To make it easier to access these in the beginning, would
+    it be a good idea to add an -examples package that ships these examples
+    along with an apache config as a working site?
+  - OK, take this with a grain of salt, some of it is less serious / more of
+    an idea or a suggestion than an error or a necessary todo item :-)
 
   * Remove recursive changes in debian/*.postinst (chown and chmod)
   * Remove /var/lib/lemonldap-ng/handler from dh_installdirs list

-- 
Debian