[SCM] Debian branch, master, updated. debian/1.2.2-2-15-g7313963

[Xavier Guimard]

The following commit has been merged in the master branch:
commit 73139634a9c58be9c1d3d42e396ee7558b5c97df
Author: Xavier Guimard <x.guimard at free.fr>
Date:   Tue Dec 11 21:58:42 2012 +0100

    Update TODO comments

diff --git a/debian/changelog b/debian/changelog
index b6b9b8d..322d02b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,27 +5,36 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
     + copyright information is incomplete, e.g.
       lemonldap-ng-manager/example/skins/default/ui-darkness/jquery-ui-1.8.6.custom.css
       or the files under scripts/
+      => Done
     + the license information for e.g. jquery.cookie.js or the icons in
       lemonldap-ng-portal/example/skins/common/apps/ does not agree with
       what's documented in the source of those files / README
+      => It's a README error that will be changed in the next version
     + there is no file in the source package that "Files: jquery.base64.js"
       applies to (missing path or globbing)
+      => it's here: lemonldap-ng-portal/example/skins/common/jquery.base64.js
     + copyright-format 1.0 specifies that the *last* matching paragraph
       applies (reverse sorting)
+      => Done
   - debian/control:
     + the short description does not fit the recommended "<package> is a ..."
       format
+      => Can you check what I've done ?
     + the long description is very short and not very informative. It does not
       explain what "SSO" stands for, it could mention what authentication
       sources are supported (probably LDAP, due to its name, any others?), and
       it would be useful to know how it compares to other Single Sign-On system
       such as Shibboleth or OpenID
+      => Done
     + embedded code copies have been removed and replaced with links to their
       standard location in the jquery* packages. Would it be helpful to provide
       some sort of dependency on those packages? Also, the jquery* code removal
       seems somewhat incomplete.
+      => Some jquery* libs are not up-to-date in Debian
+
   - there are a number of experimental lintian complaints about duplicate
     files, mostly images. Perhaps these could be replaced with symlinks.
+    => Done
   - I see that your fix for #694890 solves the piuparts issue, but I don't
     understand why removing everything (and still setting
     "HANDLERDIR=/var/lib/lemonldap-ng/handler/" during build) is the best
@@ -33,13 +42,17 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
     like a necessary component of a working application rather than just an
     example? Perhaps you could give a little more rationale for what you're
     doing in your commit messages... :-)
+    => Stored in my TODO list
   - you added a #DEBHELPER# token in the right place in the maintainer
     scripts, but they still contain a second instance of that token in the
     commented line at the top. I'm afraid this will result in breakage should
     debhelper try to substitute a multi-line code block
+    => Stupid error, done
   - the custom version test for versions 0.9 and newer in
     liblemonldap-ng-conf-perl.{config,postinst} could be made more robust
     by using something like 'if dpkg --compare-versions $2 ge 0.9'
+    => I've updated the comment, it's really < 1.0
+
   - debian/liblemonldap-ng-conf-perl.postinst and
     debian/liblemonldap-ng-portal-perl.postinst contain commands to change
     ownership and permissions. You have removed the unsafe "chown -R", but I
@@ -47,22 +60,37 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
     would also help to preserve local changes to those ownerships and
     permissions, e.g. those which the admin configured using
     dpkg-statoverride.
+    => Can you give me an example ? I've tried to use override_dh_fixperms
+       but I don't know if a lintian-overrides is recommended her to hide
+       warnings
+
   - README.Debian advises to make DNS related configuration changes to
     /var/lib/lemonldap-ng/conf/lmConf-1 and
     /var/lib/lemonldap-ng/test/index.pl. While the latter doesn't exist any
     more, the former looks an awful lot like local configuration and thus
     should be moved to /etc to preserve local changes over package upgrades.
+    => Not needed really: changes are stored in lmconf-2,... This file can be
+       modified by dpkg-reconfigure but is just needed to start the manager at
+       the first time: next, configuration are stored in a new file each time
+       it is saved (for accounting)
+
   - the webapps policy is still a draft document, but in its current state it
     seems to mandate that what lemonldap-ng puts under /var/lib/lemonldap-ng be
     put into /usr/share/<package> subdirectories, where some scripts already
     seem to be symlinked from...??
     (see: http://webapps-common.alioth.debian.org/draft/html/ch-issues.html)
+    => all files are symlinked from /usr/share/lemonldap-ng. Users can add
+       their custom skins and customed scripts in /var/lib/lemonldap-ng/
+       I thought it was compliant, wasn't it ?
+
   - There is a substantial amount of examples, including (apparently several)
     complete sites. To make it easier to access these in the beginning, would
     it be a good idea to add an -examples package that ships these examples
     along with an apache config as a working site?
+    => Stored in my TODO list
   - OK, take this with a grain of salt, some of it is less serious / more of
     an idea or a suggestion than an error or a necessary todo item :-)
+    => Thanks a lot for your help !
 
   * Remove recursive changes in debian/*.postinst (chown and chmod)
   * Remove /var/lib/lemonldap-ng/handler from dh_installdirs list
@@ -70,6 +98,9 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
   * Remove pre-defined MyHandler file. Now available from examples only
   * Move test application to examples directory
   * Update README.Debian file
+  * Replace duplicate files by links
+  * Update descriptions
+  * Update debian/copyright (missing entries)
 
  -- Xavier Guimard <x.guimard at free.fr>  Wed, 05 Dec 2012 06:25:56 +0100
 

-- 
Debian