[SCM] Debian branch, master, updated. debian/1.2.2-2-16-g5ab98b1

[Florian Schlichting]

The following commit has been merged in the master branch:
commit 5ab98b1d8363ef4d182b2ee6954533814a88d9f6
Author: Florian Schlichting <fschlich at zedat.fu-berlin.de>
Date:   Wed Dec 12 12:00:46 2012 +0100

    more comments added to d/changelog
    
    (feel free to remove the stuff you think you've resolved)

diff --git a/debian/changelog b/debian/changelog
index 322d02b..98bfd2d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,31 +6,50 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
       lemonldap-ng-manager/example/skins/default/ui-darkness/jquery-ui-1.8.6.custom.css
       or the files under scripts/
       => Done
+        - There is still a syntax problem: a .css file doesn't match
+          jquery-ui*.js, and even if it did, it would be overridden by the later
+          jquery*.js; 
+        - And what about scripts/DoxyGen/SQLFilter.pm? Please run 'grep -ri
+          copy' and make sure every copyright holder that comes up is covered
+          by debian/copyright
     + the license information for e.g. jquery.cookie.js or the icons in
       lemonldap-ng-portal/example/skins/common/apps/ does not agree with
       what's documented in the source of those files / README
       => It's a README error that will be changed in the next version
+        - that's ok, but while this hasn't been changed upstream perhaps add a
+          Comment: field to the respective paragraphs?
     + there is no file in the source package that "Files: jquery.base64.js"
       applies to (missing path or globbing)
       => it's here: lemonldap-ng-portal/example/skins/common/jquery.base64.js
+        - I know, but debian/copyright is meant to be machine-readable and the
+          pattern doesn't match. See second bullet point at
+          http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#files-field
     + copyright-format 1.0 specifies that the *last* matching paragraph
       applies (reverse sorting)
-      => Done
+      => Done (but introduced a new case I mentioned above)
   - debian/control:
     + the short description does not fit the recommended "<package> is a ..."
       format
       => Can you check what I've done ?
+        - you only put the "..." into the short description. So e.g. "OpenID, CAS
+          and SAML compatible Web-SSO system (common files)" for
+          liblemonldap-ng-conf-perl. (Did you only update the first package's
+          description on purpose?)
     + the long description is very short and not very informative. It does not
       explain what "SSO" stands for, it could mention what authentication
       sources are supported (probably LDAP, due to its name, any others?), and
       it would be useful to know how it compares to other Single Sign-On system
       such as Shibboleth or OpenID
       => Done
+        - s/ bu / be /
+        - better, but I still don't really know why I should use lemonldap-ng
+          rather than e.g. Shibboleth
     + embedded code copies have been removed and replaced with links to their
       standard location in the jquery* packages. Would it be helpful to provide
       some sort of dependency on those packages? Also, the jquery* code removal
       seems somewhat incomplete.
       => Some jquery* libs are not up-to-date in Debian
+        - ok, but could you have included the .css files as well?
 
   - there are a number of experimental lintian complaints about duplicate
     files, mostly images. Perhaps these could be replaced with symlinks.
@@ -52,6 +71,7 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
     liblemonldap-ng-conf-perl.{config,postinst} could be made more robust
     by using something like 'if dpkg --compare-versions $2 ge 0.9'
     => I've updated the comment, it's really < 1.0
+      - um, you did not?
 
   - debian/liblemonldap-ng-conf-perl.postinst and
     debian/liblemonldap-ng-portal-perl.postinst contain commands to change

-- 
Debian