[SCM] Debian branch, master, updated. debian/1.2.2-2-24-g9c37cfe
Xavier Guimard
x.guimard at free.fr
Sat Dec 22 08:17:49 UTC 2012
The following commit has been merged in the master branch:
commit 9c37cfe13fef5df20a2c7d48e21844a7d519b072
Author: Xavier Guimard <x.guimard at free.fr>
Date: Sat Dec 22 09:15:29 2012 +0100
Update d/ch and comment d/copy
diff --git a/debian/changelog b/debian/changelog
index 571ee6f..d0cd7bd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,58 +1,6 @@
lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
TODO:
- - debian/copyright:
- + the license information for e.g. jquery.cookie.js or the icons in
- lemonldap-ng-portal/example/skins/common/apps/ does not agree with
- what's documented in the source of those files / README
- => It's a README error that will be changed in the next version
- - that's ok, but while this hasn't been changed upstream perhaps add a
- Comment: field to the respective paragraphs?
- - debian/control:
- + the short description does not fit the recommended "<package> is a ..."
- format
- => Can you check what I've done ?
- - you only put the "..." into the short description. So e.g. "OpenID,
- CAS and SAML compatible Web-SSO system (common files)" for
- liblemonldap-ng-conf-perl. (Did you only update the first package's
- description on purpose?)
- + the long description is very short and not very informative. It does not
- explain what "SSO" stands for, it could mention what authentication
- sources are supported (probably LDAP, due to its name, any others?), and
- it would be useful to know how it compares to other Single Sign-On system
- such as Shibboleth or OpenID
- => Done
- - better, but I still don't really know why I should use lemonldap-ng
- rather than e.g. Shibboleth
- + embedded code copies have been removed and replaced with links to their
- standard location in the jquery* packages. Would it be helpful to provide
- some sort of dependency on those packages? Also, the jquery* code removal
- seems somewhat incomplete.
- => Some jquery* libs are not up-to-date in Debian
- - ok, but could you have included the .css files as well?
-
- - there are a number of experimental lintian complaints about duplicate
- files, mostly images. Perhaps these could be replaced with symlinks.
- => Done
- - I see that your fix for #694890 solves the piuparts issue, but I don't
- understand why removing everything (and still setting
- "HANDLERDIR=/var/lib/lemonldap-ng/handler/" during build) is the best
- possible approach. "Apache configuration and default handler" sounds more
- like a necessary component of a working application rather than just an
- example? Perhaps you could give a little more rationale for what you're
- doing in your commit messages... :-)
- => Stored in my TODO list
- - you added a #DEBHELPER# token in the right place in the maintainer
- scripts, but they still contain a second instance of that token in the
- commented line at the top. I'm afraid this will result in breakage should
- debhelper try to substitute a multi-line code block
- => Stupid error, done
- - the custom version test for versions 0.9 and newer in
- liblemonldap-ng-conf-perl.{config,postinst} could be made more robust
- by using something like 'if dpkg --compare-versions $2 ge 0.9'
- => I've updated the comment, it's really < 1.0
- - um, you did not?
-
- debian/liblemonldap-ng-conf-perl.postinst and
debian/liblemonldap-ng-portal-perl.postinst contain commands to change
ownership and permissions. You have removed the unsafe "chown -R", but I
@@ -64,16 +12,6 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
but I don't know if a lintian-overrides is recommended her to hide
warnings
- - README.Debian advises to make DNS related configuration changes to
- /var/lib/lemonldap-ng/conf/lmConf-1 and
- /var/lib/lemonldap-ng/test/index.pl. While the latter doesn't exist any
- more, the former looks an awful lot like local configuration and thus
- should be moved to /etc to preserve local changes over package upgrades.
- => Not needed really: changes are stored in lmconf-2,... This file can be
- modified by dpkg-reconfigure but is just needed to start the manager at
- the first time: next, configuration are stored in a new file each time
- it is saved (for accounting)
-
- the webapps policy is still a draft document, but in its current state it
seems to mandate that what lemonldap-ng puts under /var/lib/lemonldap-ng be
put into /usr/share/<package> subdirectories, where some scripts already
@@ -83,15 +21,6 @@ lemonldap-ng (1.2.2-3) UNRELEASED; urgency=low
their custom skins and customed scripts in /var/lib/lemonldap-ng/
I thought it was compliant, wasn't it ?
- - There is a substantial amount of examples, including (apparently several)
- complete sites. To make it easier to access these in the beginning, would
- it be a good idea to add an -examples package that ships these examples
- along with an apache config as a working site?
- => Stored in my TODO list
- - OK, take this with a grain of salt, some of it is less serious / more of
- an idea or a suggestion than an error or a necessary todo item :-)
- => Thanks a lot for your help !
-
* Remove recursive changes in debian/*.postinst (chown and chmod)
* Remove /var/lib/lemonldap-ng/handler from dh_installdirs list
(Closes: #694890)
diff --git a/debian/copyright b/debian/copyright
index 47e1905..e9f49a5 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -2,6 +2,7 @@ Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: lemonldap-ng
Upstream-Contact: Xavier Guimard <x.guimard at free.fr>
Source: http://forge.objectweb.org/project/showfiles.php?group_id=274
+Comment: this file has been updated using svn upstream version
Files: *
Copyright: 2004-2012, Xavier Guimard <x.guimard at free.fr>
--
Debian
More information about the Pkg-perl-cvs-commits
mailing list