[SCM] Debian branch, master, updated. debian/1.2.2-3-16-gffa70e0

[Florian Schlichting]

The following commit has been merged in the master branch:
commit ffa70e037930d1b4c6c12c09f1794e035e606ee5
Author: Florian Schlichting <fsfs at debian.org>
Date:   Mon Apr 8 00:12:03 2013 +0200

    back to UNRELEASED, TODO and comments added to changelog

diff --git a/debian/changelog b/debian/changelog
index 84ddb2e..52b6b9f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,64 @@
-lemonldap-ng (1.2.3-1) unstable; urgency=low
+lemonldap-ng (1.2.3-1) UNRELEASED; urgency=low
+
+  TODO:
+  - lemonldap-ng-portal/example/skins/common/portal.js adds a chunk of code
+    with the comment "Code from http://snipplr.com/view/29434/" - shouldn't
+    that be properly documented with copyrightholder and license?
+  - override_dh_fixperms: yes, that was what I meant - but please also remove
+    the corresponding chown/chmod in liblemonldap-ng-conf-perl.postinst and
+    liblemonldap-ng-portal-perl.postinst (and perhaps adjust the comment in
+    debian/rules?)
+  - lintian-overrides: please document in a comment at the top of the files
+    (this will be shown by lintian along with the override) why these
+    non-standard permissions are necessary (not just "for security reasons",
+    but what is protected, and from whom?)
+  - when fixing the #DEBHELPER# issue, you put '# Maintainer: ' in front of
+    the token. Why? In bash, this is a comment, so the first line that
+    #DEBHELPER# may be substituted with, will be commented out -> error. Also,
+    if it's substituted with an empty string like now, the Maintainer-comment
+    doesn't really have a meaning, no?
+  - please check if you can change the test for versions < 1.0 in
+    liblemonldap-ng-conf-perl.config to use dpkg --compare-versions like you
+    did in liblemonldap-ng-conf-perl.postinst
+  - I am not sure all package dependencies are complete and correct, but I got
+    confused and this may in part be an upstream problem. A thorough audit may
+    be useful?
+    Examples:
+      + does liblemonldap-ng-conf-perl need an additional dependency on
+        libcrypt-openssl-x509-perl? (seems to be used)
+      + does liblemonldap-ng-portal-perl need its dependency on
+        libauthen-captcha-perl? (not in META, was promoted from Suggests: to
+        Depends: in d/control)
+      + lemonldap-ng-handler does not have a dependency on
+        libapache-session-perl, but it's META.yml mentions
+        Apache::Session::Generate::MD5
+      + does lemonldap-ng-handler lack a suggests on libhttp-message-perl (for
+        HTTP::Message)?
+      + lemonldap-ng-handler's META.yml states that the build requires
+        Cache::Memcached, but libcache-memcached-perl was removed from B-D
+        -I?
+      + does B-D-I need a dependency on libconvert-pem-perl for
+        Lemonldap::NG::Manager (see warning in build log)?
+  - there are a few typos in the new long description paragraphs (same for
+    every package):     headers fors -> headers for
+                        are build    -> are built
+                        authorizated -> authorized
+
+  THINGS TO THINK ABOUT
+  (no need to fix for release, or at all - it's up to you / upstream)
+  - is it useful to ship omegat.files/* as part of the released tarball? Some
+    of them are very big, with lots of changes, and I wouldn't expect people
+    working on translations to use the tarball, but rather an SVN checkout
+    directly?
+  - does there need to be an upstream debian directory in the tarball -
+    wouldn't it be enough to have it in the VCS, but not package it? The
+    problem in this case is that changes that are made upstream are merged
+    into the master branch, even without conflicts, and they are not accounted
+    for by commits on the master branch, thus may escape the maintainer's
+    attention. Case in point: the "Merge tag 'upstream/1.2.3'" commit doesn't
+    just change debian/control, it also changes README.Debian but this is
+    somehow invisible! See also
+    http://wiki.debian.org/DebianMentorsFaq#What.27s_wrong_with_upstream_shipping_a_debian.2F_directory.3F
 
   [ Salvatore Bonaccorso ]
   * Change Vcs-Git to canonical URI (git://anonscm.debian.org)

-- 
Debian