[dh-make-perl] 02/04: use strict; use warnings; everywhere

[Damyan Ivanov]

This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository dh-make-perl.

commit 004edd48071c8ed39167e3ed56b91bbb1a87999a
Author: Damyan Ivanov <dmn at debian.org>
Date:   Fri Aug 9 14:11:31 2013 +0200

    use strict; use warnings; everywhere
    
    also ensure this doesn't change via t/critic.t
---
 lib/Debian/Control.pm               |    1 +
 lib/Debian/Control/FromCPAN.pm      |    2 ++
 lib/Debian/Control/Stanza.pm        |    1 +
 lib/Debian/Control/Stanza/Binary.pm |    1 +
 lib/Debian/Control/Stanza/Source.pm |    1 +
 lib/Debian/Rules.pm                 |    3 +++
 lib/DhMakePerl/Utils.pm             |    4 +++-
 t/critic.t                          |   17 +++++++++++++++++
 t/perlcriticrc                      |    4 ++++
 9 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/lib/Debian/Control.pm b/lib/Debian/Control.pm
index 3405abf..2ce1bd1 100644
--- a/lib/Debian/Control.pm
+++ b/lib/Debian/Control.pm
@@ -50,6 +50,7 @@ package Debian::Control;
 
 use base 'Class::Accessor';
 use strict;
+use warnings;
 
 our $VERSION = '0.77';
 
diff --git a/lib/Debian/Control/FromCPAN.pm b/lib/Debian/Control/FromCPAN.pm
index b583604..ea57603 100644
--- a/lib/Debian/Control/FromCPAN.pm
+++ b/lib/Debian/Control/FromCPAN.pm
@@ -14,8 +14,10 @@ Debian::Control::FromCPAN - fill F<debian/control> from unpacked CPAN distributi
 package Debian::Control::FromCPAN;
 
 use strict;
+use warnings;
 
 our $VERSION = '0.77';
+
 use Carp qw(croak);
 
 use base 'Debian::Control';
diff --git a/lib/Debian/Control/Stanza.pm b/lib/Debian/Control/Stanza.pm
index 6339ed3..eda234e 100644
--- a/lib/Debian/Control/Stanza.pm
+++ b/lib/Debian/Control/Stanza.pm
@@ -23,6 +23,7 @@ package Debian::Control::Stanza;
 require v5.10.0;
 
 use strict;
+use warnings;
 
 our $VERSION = '0.71';
 
diff --git a/lib/Debian/Control/Stanza/Binary.pm b/lib/Debian/Control/Stanza/Binary.pm
index 6c1dace..4599ec7 100644
--- a/lib/Debian/Control/Stanza/Binary.pm
+++ b/lib/Debian/Control/Stanza/Binary.pm
@@ -85,6 +85,7 @@ empty lines are replaced with dots.
 package Debian::Control::Stanza::Binary;
 
 use strict;
+use warnings;
 
 our $VERSION = '0.77';
 
diff --git a/lib/Debian/Control/Stanza/Source.pm b/lib/Debian/Control/Stanza/Source.pm
index a5a2317..1a83ebc 100644
--- a/lib/Debian/Control/Stanza/Source.pm
+++ b/lib/Debian/Control/Stanza/Source.pm
@@ -73,6 +73,7 @@ class upon construction.
 package Debian::Control::Stanza::Source;
 
 use strict;
+use warnings;
 
 our $VERSION = '0.73';
 
diff --git a/lib/Debian/Rules.pm b/lib/Debian/Rules.pm
index baae4d8..7bfe49d 100644
--- a/lib/Debian/Rules.pm
+++ b/lib/Debian/Rules.pm
@@ -1,5 +1,8 @@
 package Debian::Rules;
 
+use strict;
+use warnings;
+
 our $VERSION = '0.66';
 
 =head1 NAME
diff --git a/lib/DhMakePerl/Utils.pm b/lib/DhMakePerl/Utils.pm
index f503add..3caa0be 100644
--- a/lib/DhMakePerl/Utils.pm
+++ b/lib/DhMakePerl/Utils.pm
@@ -1,5 +1,7 @@
 package DhMakePerl::Utils;
 
+use strict;
+use warnings;
 
 our $VERSION = '0.71';
 
@@ -24,7 +26,7 @@ our @EXPORT_OK = qw(
     split_version_relation
 );
 
-use base Exporter;
+use base 'Exporter';
 
 use 5.10.0;
 
diff --git a/t/critic.t b/t/critic.t
new file mode 100644
index 0000000..a06bd4b
--- /dev/null
+++ b/t/critic.t
@@ -0,0 +1,17 @@
+use strict;
+use warnings;
+
+use Test::More;
+
+BEGIN {
+    eval { require Test::Perl::Critic; 1 }
+        or plan skip_all => 'Test::Perl::Critic required to criticise code';
+};
+
+use File::Spec;
+
+
+my $rcfile = File::Spec->catfile( 't', 'perlcriticrc' );
+Test::Perl::Critic->import( -profile => $rcfile );
+
+all_critic_ok( 'scripts', 'lib' );
diff --git a/t/perlcriticrc b/t/perlcriticrc
new file mode 100644
index 0000000..da783bb
--- /dev/null
+++ b/t/perlcriticrc
@@ -0,0 +1,4 @@
+only = 1
+include = Variables::ProhibitConditionalDeclarations
+include = TestingAndDebugging::RequireUseWarnings
+include = TestingAndDebugging::RequireUseStrict

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/dh-make-perl.git