[libtest-unit-perl] 01/01: Make test assert_deep_equals less fragile…

[Axel Beckert]

This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch master
in repository libtest-unit-perl.

commit fd5570d3b70db93dba0a5f45120078ba967c8fc1
Author: Axel Beckert <abe at deuxchevaux.org>
Date:   Thu Dec 26 02:20:10 2013 +0100

    Make test assert_deep_equals less fragile…
    
    … against hash randomization by adding valid variants
---
 debian/changelog                                    |  7 ++-----
 debian/patches/40_make-deep-test-less-fragile.patch | 21 +++++++++++++++++++++
 debian/patches/series                               |  1 +
 3 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 57ad9b6..0f96f5c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,10 +1,5 @@
 libtest-unit-perl (0.25-2) UNRELEASED; urgency=low
 
-  TODO:
-  * Fix occasional test suite failures in assert.t (maybe hash
-    randomization, possibly related to
-    https://rt.cpan.org/Public/Bug/Display.html?id=87017).  Developer
-    release (0.25_1325) doesn't help, so ignoring it for now.
 
   [ gregor herrmann ]
   * Change patch system from dpatch to quilt.
@@ -37,6 +32,8 @@ libtest-unit-perl (0.25-2) UNRELEASED; urgency=low
     5.14 or later. Add according version restriction to build-dependency.
   * Install (Tk)TestRunner.pl as examples, not into /usr/share/perl5/Test/
   * Add Makefile.old to debian/clean
+  * Add patch against test assert_deep_equals to make it less fragile
+    against hash randomization by adding valid variants.
 
  -- gregor herrmann <gregoa at debian.org>  Tue, 09 Oct 2007 22:32:29 +0200
 
diff --git a/debian/patches/40_make-deep-test-less-fragile.patch b/debian/patches/40_make-deep-test-less-fragile.patch
new file mode 100644
index 0000000..4fd4afe
--- /dev/null
+++ b/debian/patches/40_make-deep-test-less-fragile.patch
@@ -0,0 +1,21 @@
+Description: Add more variants to fragile test
+ This test was already marked by upstream as "may be fragile due to
+ recursion ordering" and it indeed is fragile. Fixes occasional test
+ suite failures due to hash randomization.
+Author: Axel Beckert <abe at debian.org>
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=87017
+
+Index: libtest-unit-perl/t/tlib/AssertTest.pm
+===================================================================
+--- libtest-unit-perl.orig/t/tlib/AssertTest.pm	2013-12-26 02:08:38.782689704 +0100
++++ libtest-unit-perl/t/tlib/AssertTest.pm	2013-12-26 02:13:11.136010021 +0100
+@@ -479,7 +479,8 @@
+                  },
+              }
+          ],
+-	 $differ->( 'HASH', 'not exist') => [$families{orig}, $families{bad_copy}], # test may be fragile due to recursion ordering?
++         # test is fragile due to hash randomization
++	 $differ->( 'HASH|John\sDoe', 'not\sexist|Baby\sDoll') => [$families{orig}, $families{bad_copy}],
+ 	 $differ->("'3'", "'5'") => [ [ \$H, 3 ], [ \$H2, 5 ] ],
+ 	 $differ->("'hello'", "'goodbye'") => [ { world => \$H }, { world => \$G } ],
+ 	 $differ->("'hello'", "'goodbye'") => [ [ \$H, "world" ], [ \$G, "world" ] ],
diff --git a/debian/patches/series b/debian/patches/series
index d30c441..ccf12ab 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 20_fix-defined-array-warnings.patch
 30_fix-xism-test-suite-failures.patch
+40_make-deep-test-less-fragile.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libtest-unit-perl.git