[libcgi-formbuilder-perl] 01/04: Add a patch fixing test failures with perl5.18. Closes: #720959

Damyan Ivanov dmn at moszumanska.debian.org
Fri Nov 29 14:37:48 UTC 2013


This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository libcgi-formbuilder-perl.

commit d3adad22fead507a2553c86f4b0aef226b8156f0
Author: Damyan Ivanov <dmn at debian.org>
Date:   Fri Nov 29 14:08:15 2013 +0000

    Add a patch fixing test failures with perl5.18. Closes: #720959
---
 debian/changelog                     |  3 +++
 debian/patches/perl5.18-hashes.patch | 33 +++++++++++++++++++++++++++++++++
 debian/patches/series                |  1 +
 3 files changed, 37 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index e658a23..b54a1f1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,9 @@ libcgi-formbuilder-perl (3.08-2) UNRELEASED; urgency=low
   * debian/copyright: migrate pre-1.0 format to 1.0 using "cme fix dpkg-
     copyright"
 
+  [ Damyan Ivanov ]
+  * Add a patch fixing test failures with perl5.18. Closes: #720959
+
  -- Salvatore Bonaccorso <carnil at debian.org>  Sun, 06 Jan 2013 21:58:10 +0100
 
 libcgi-formbuilder-perl (3.08-1) unstable; urgency=low
diff --git a/debian/patches/perl5.18-hashes.patch b/debian/patches/perl5.18-hashes.patch
new file mode 100644
index 0000000..03b00e7
--- /dev/null
+++ b/debian/patches/perl5.18-hashes.patch
@@ -0,0 +1,33 @@
+Description: tests fail due to Perl 5.18 hash randomization
+ With this patch the hashes are walked in alphabetic order during tests,
+ avoiding the failures.
+ .
+ This is not flagged forwarded, since RT is not used by upstream, and upstream
+ mailing list is a google group. Hopefuly others will look at RT.
+Author: Damyan Ivanov <dmn at debian.org>
+Forderded: no
+
+--- a/t/2c-template-tt2.t
++++ b/t/2c-template-tt2.t
+@@ -114,7 +114,8 @@ for (@test) {
+                );
+ 
+     # the ${mod} key twiddles fields
+-    while(my($f,$o) = each %{$_->{mod} || {}}) {
++    for my $f ( sort keys %{$_->{mod} || {}} ) {
++        my $o = $_->{mod}{$f};
+         $o->{name} = $f;
+         $form->field(%$o);
+     }
+--- a/t/1a-generate.t
++++ b/t/1a-generate.t
+@@ -579,7 +579,8 @@ for (@test) {
+                );
+ 
+     # the ${mod} key twiddles fields
+-    while(my($f,$o) = each %{$_->{mod} || {}}) {
++    for my $f ( sort keys %{$_->{mod} || {}} ) {
++        my $o = $_->{mod}{$f};
+         $o->{name} = $f;
+         $form->field(%$o);
+     }
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..bd24162
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+perl5.18-hashes.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libcgi-formbuilder-perl.git



More information about the Pkg-perl-cvs-commits mailing list