[padre] 01/06: add patch fixing usage of experimental 'given', causing failed 'no warnings' tests
Damyan Ivanov
dmn at alioth.debian.org
Wed Sep 25 20:41:36 UTC 2013
This is an automated email from the git hooks/post-receive script.
dmn pushed a commit to branch master
in repository padre.
commit 88e6951975852531ea641b4e4887fb6f4ae8cabc
Author: Damyan Ivanov <dmn at debian.org>
Date: Wed Sep 25 19:31:02 2013 +0000
add patch fixing usage of experimental 'given', causing failed 'no warnings' tests
Closes: #724150 -- FTBFS: tests failed
---
debian/patches/no-experimental.patch | 51 ++++++++++++++++++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 52 insertions(+)
diff --git a/debian/patches/no-experimental.patch b/debian/patches/no-experimental.patch
new file mode 100644
index 0000000..fe57655
--- /dev/null
+++ b/debian/patches/no-experimental.patch
@@ -0,0 +1,51 @@
+Description: replace experimental 'given' with plain old if-elsif-else
+ perl 5.18 warns about usage of 'given', causing failures of 'no warnings'
+ tests
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724150
+Author: Damyan Ivanov <dmn at debian.org>
+Forwarded: no
+
+--- a/lib/Padre/Wx/Dialog/PluginManager.pm
++++ b/lib/Padre/Wx/Dialog/PluginManager.pm
+@@ -220,11 +220,11 @@ sub refresh {
+ $position,
+ );
+
+- given ( $handle->status ) {
+- when ( $_ eq 'enabled' ) { $self->{list}->SetItemTextColour( $index, BLUE ); }
+- when ( $_ eq 'disabled' ) { $self->{list}->SetItemTextColour( $index, BLACK ); }
+- when ( $_ eq 'incompatible' ) { $self->{list}->SetItemTextColour( $index, DARK_GRAY ); }
+- when ( $_ eq 'error' ) { $self->{list}->SetItemTextColour( $index, RED ); }
++ for ( $handle->status ) {
++ if ( $_ eq 'enabled' ) { $self->{list}->SetItemTextColour( $index, BLUE ); }
++ elsif ( $_ eq 'disabled' ) { $self->{list}->SetItemTextColour( $index, BLACK ); }
++ elsif ( $_ eq 'incompatible' ) { $self->{list}->SetItemTextColour( $index, DARK_GRAY ); }
++ elsif ( $_ eq 'error' ) { $self->{list}->SetItemTextColour( $index, RED ); }
+ }
+
+ # $self->{list}->SetItem( $index, 0, $handle->plugin_name );
+--- a/lib/Padre/Wx/Panel/Debugger.pm
++++ b/lib/Padre/Wx/Panel/Debugger.pm
+@@ -903,18 +903,18 @@ sub _on_list_item_selected {
+ my $black_size = keys %{ $self->{var_val} };
+ my $blue_size = keys %{ $self->{local_values} };
+
+- given ($index) {
+- when ( $_ <= $black_size ) {
++ for ($index) {
++ if ( $_ <= $black_size ) {
+ $variable_value = $self->{var_val}->{$variable_name};
+ chomp $variable_value;
+ $main->{debugoutput}->debug_output_black( $variable_name . ' = ' . $variable_value );
+ }
+- when ( $_ <= ( $black_size + $blue_size ) ) {
++ elsif ( $_ <= ( $black_size + $blue_size ) ) {
+ $variable_value = $self->{local_values}->{$variable_name};
+ chomp $variable_value;
+ $main->{debugoutput}->debug_output_blue( $variable_name . ' = ' . $variable_value );
+ }
+- default {
++ else {
+ $variable_value = $self->{global_values}->{$variable_name};
+ chomp $variable_value;
+ $main->{debugoutput}->debug_output_dark_gray( $variable_name . ' = ' . $variable_value );
diff --git a/debian/patches/series b/debian/patches/series
index 9bcde9d..8096acd 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ fix-spelling
disable-tcp-server.patch
example-interpreter.patch
fix-mime-test
+no-experimental.patch
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/padre.git
More information about the Pkg-perl-cvs-commits
mailing list