[libconfig-model-dpkg-perl] 05/24: Dpkg::Dep: removed on_check_all_done cb

dod at debian.org dod at debian.org
Sun Apr 20 13:07:46 UTC 2014


This is an automated email from the git hooks/post-receive script.

dod pushed a commit to branch master
in repository libconfig-model-dpkg-perl.

commit 75cb7a992a0b7b4d370e04d389a7cc746db12b3c
Author: Dominique Dumont <dod at debian.org>
Date:   Mon Apr 14 20:59:31 2014 +0200

    Dpkg::Dep: removed on_check_all_done cb
---
 lib/Config/Model/Dpkg/Dependency.pm | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/lib/Config/Model/Dpkg/Dependency.pm b/lib/Config/Model/Dpkg/Dependency.pm
index 47b53d5..8864039 100644
--- a/lib/Config/Model/Dpkg/Dependency.pm
+++ b/lib/Config/Model/Dpkg/Dependency.pm
@@ -303,22 +303,13 @@ sub check_dependency {
     $async_log->debug("end for ",$self->composite_name) if $async_log->is_debug;
 
 	$self->check_depend_chain($apply_fix, \@dep_chain, $old ) ;
-	$self->on_check_all_done($apply_fix,\@dep_chain,$old, sub { $callback->(%args) if $callback; });
-}
-
-# this callback will be launched when all checks are done. this can be at
-# the 'end' call at this end of this sub if all calls of check_depend are
-# synchronous (which may be the case if all dependency informations are in cache)
-# or it can be in one of the call backs
-sub on_check_all_done {
-    my ($self, $apply_fix, $dep_chain, $old, $next) = @_ ;
 
     # "ideal" dependency is always computed, but it does not always change
-    my $new = $self->struct_to_dep(@$dep_chain);
+    my $new = $self->struct_to_dep(@dep_chain);
 
     if ( $logger->is_debug ) {
         my $new //= '<undef>';
-        $async_log->debug( "in on_check_all_done callback for ",
+        $async_log->debug( "end for ",
             $self->composite_name, " ($new) fix is $apply_fix" )
           if $async_log->is_debug;
         no warnings 'uninitialized';
@@ -329,7 +320,7 @@ sub on_check_all_done {
         no warnings 'uninitialized';
         $self->_store_fix( $old, $new ) if $apply_fix and $new ne $old;
     }
-    $next->();
+	$callback->(%args) if $callback;
 }
 
 sub check_debhelper_version {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libconfig-model-dpkg-perl.git



More information about the Pkg-perl-cvs-commits mailing list