[libconfig-model-dpkg-perl] 14/24: removed $on_perl_check_done from check_perl_lib_dep

dod at debian.org dod at debian.org
Sun Apr 20 13:07:47 UTC 2014


This is an automated email from the git hooks/post-receive script.

dod pushed a commit to branch master
in repository libconfig-model-dpkg-perl.

commit 361fc80308cd3f52a1cf4229201057d942d2ca05
Author: Dominique Dumont <dod at debian.org>
Date:   Thu Apr 17 19:37:44 2014 +0200

    removed $on_perl_check_done from check_perl_lib_dep
---
 lib/Config/Model/Dpkg/Dependency.pm | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/lib/Config/Model/Dpkg/Dependency.pm b/lib/Config/Model/Dpkg/Dependency.pm
index af05e4c..bec6725 100644
--- a/lib/Config/Model/Dpkg/Dependency.pm
+++ b/lib/Config/Model/Dpkg/Dependency.pm
@@ -468,18 +468,11 @@ sub check_perl_lib_dep {
     my @ideal_lib_dep ;
     my @ideal_dep_chain = (\@ideal_perl_dep);
 
-    my ($on_perl_check_done, $check_perl_lib, $get_perl_versions, $on_get_perl_versions) ;
+    my ($check_perl_lib, $get_perl_versions, $on_get_perl_versions) ;
 
     my ($v_normal) ;
 
 
-    $on_perl_check_done =  sub {
-        my $has_older_perl = shift ;
-        $async_log->debug("on_perl_check_done called") ;
-        push @ideal_perl_dep, '>=', $v_normal if $has_older_perl;
-        $check_perl_lib->($has_older_perl) ;
-    } ;
-
     $check_perl_lib = sub {
         my $has_older_perl = shift;
         $async_log->debug( "check_perl_lib called with dep_v " . ( $dep_v // 'undef' ) );
@@ -579,8 +572,11 @@ sub check_perl_lib_dep {
 			my $dep_str = $dep_name . ( defined $check_v ? ' ' . $check_v : '' );
 			$logger->debug("dual life $dep_str aka $dep_name_as_perl[0] found in Perl core $v_normal");
 		}
+
 		my @res = $self->check_versioned_dep(  ['perl', '>=', $v_normal] );
-		$on_perl_check_done->(@res);
+        my $has_older_perl = $res[0] ;
+        push @ideal_perl_dep, '>=', $v_normal if $has_older_perl;
+        $check_perl_lib->($has_older_perl) ;
 	}
 
     return $ret ;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libconfig-model-dpkg-perl.git



More information about the Pkg-perl-cvs-commits mailing list