[libmusicbrainz-discid-perl] 01/01: let libdiscid do the params check

Damyan Ivanov dmn at moszumanska.debian.org
Tue Aug 19 17:03:44 UTC 2014


This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository libmusicbrainz-discid-perl.

commit 6ef32fd04b128b83ec7e5b0df0e7f17c0a58507a
Author: Damyan Ivanov <dmn at debian.org>
Date:   Tue Aug 19 17:03:38 2014 +0000

    let libdiscid do the params check
---
 debian/patches/stack-corruption-discid_put.patch | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/debian/patches/stack-corruption-discid_put.patch b/debian/patches/stack-corruption-discid_put.patch
index 9d540ad..fe0b1ff 100644
--- a/debian/patches/stack-corruption-discid_put.patch
+++ b/debian/patches/stack-corruption-discid_put.patch
@@ -13,13 +13,17 @@ Bug-Debian: https://bugs.debian.org/758216
 
 --- a/lib/MusicBrainz/DiscID.xs
 +++ b/lib/MusicBrainz/DiscID.xs
-@@ -127,8 +127,8 @@ discid_put( disc, first_track, sectors,
+@@ -124,11 +124,12 @@ discid_put( disc, first_track, sectors,
+   DiscId *disc
+   int first_track
+   int sectors
++  int n_items = items;
    PREINIT:
  	  int i, last_track, offsets[100];
    CODE:
 -	  for (i=0;i<100;i++);
 -	      offsets[i] = 0;
-+    if (items > 102 ) croak("Maximum of 99 offsets exceeded");
++    if (items > 102 ) n_items = 102;  // rely on discid_put to return error
 +    memset(offsets, 0, sizeof(offsets));
      for (i=3; i<items; i++) {
          offsets[i-2] = (int)SvIV(ST(i));

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libmusicbrainz-discid-perl.git



More information about the Pkg-perl-cvs-commits mailing list