[libdbd-firebird-perl] 01/02: add patch from upstream Git disabling threaded events tests during automated testing Closes: #732324 -- FTBFS on i386

[Damyan Ivanov]

This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository libdbd-firebird-perl.

commit a3b62e45b50c2b54481940a94169b0b3543891fb
Author: Damyan Ivanov <dmn at debian.org>
Date:   Thu Jan 9 13:16:15 2014 +0000

    add patch from upstream Git disabling threaded events tests during automated testing Closes: #732324 -- FTBFS on i386
---
 debian/changelog                                |  3 ++
 debian/patches/series                           |  1 +
 debian/patches/skip-threaded-events-tests.patch | 51 +++++++++++++++++++++++++
 3 files changed, 55 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 6c74635..5aa5aee 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,9 @@ libdbd-firebird-perl (1.16-2) UNRELEASED; urgency=medium
   [ Damyan Ivanov ]
   * add arm64 to BAD_ARCH list on request from Noskaj
     "This is the only thing in the Ubuntu diff" on IRC
+  * add patch from upstream Git disabling threaded events tests during
+    automated testing
+    Closes: #732324 -- FTBFS on i386
 
   [ Xavier Guimard ]
   * Bump Standards-Version to 3.9.5
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..cb2d726
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+skip-threaded-events-tests.patch
diff --git a/debian/patches/skip-threaded-events-tests.patch b/debian/patches/skip-threaded-events-tests.patch
new file mode 100644
index 0000000..6be48c5
--- /dev/null
+++ b/debian/patches/skip-threaded-events-tests.patch
@@ -0,0 +1,51 @@
+From 0e6b1a2370f605dacfd9d5b85e26384879371a11 Mon Sep 17 00:00:00 2001
+From: Damyan Ivanov <dmn at debian.org>
+Date: Thu, 9 Jan 2014 13:04:12 +0000
+Subject: [PATCH] skip thread event tests under AUTOMATED_TESTING
+
+this causes failure to build in Debian (http://bugs.debian.org/732324)
+
+to trigger the crash, the test needs to be run in a loop, under
+a very heavy system load. Here's a oneliner:
+
+ ( export AUTOMATED_TESTING=1 ; C=0; while perl -Iblib/arch:blib/lib t/embed-80-event-ithreads.t; do C=$(( $C + 1 )); echo $C ; done )
+
+I inspected some coredumps, and the segfault is at different place
+every time, suggesting memory/stack corruption. Some of the backtraces
+had traces from firebird shutdown sequence (presumably caused by the
+embedded disconnect code) and some had tried to emit perl errors about
+attempts to free unreferenced scalars and such.
+
+My best guess for the core reason is the tricky concept of shutting
+down FB engine (just look for 'shutdown' at tracker.firebirdsql.org),
+which I guess sometimes doesn't play nicely with perl threads.
+
+If my guess is right, it is not 100% safe to establish/close
+connections via FirebirdEmbedded from perl threads.
+
+Of course, the root cause may as well be in perl (though with the same
+conclusion).
+
+I added a TODO note to enable the tests again when FB3 comes out. If
+it proves stable, we may enable the tests depending on FB version.
+---
+ t/80-event-ithreads.t | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/t/80-event-ithreads.t b/t/80-event-ithreads.t
+index d4c764f..82f474d 100644
+--- a/t/80-event-ithreads.t
++++ b/t/80-event-ithreads.t
+@@ -96,6 +96,9 @@ SKIP: {
+     skip "this $^O perl $] is not configured to support iThreads", $how_many if (!$Config{useithreads} || $] < 5.008);
+     skip "known problems under MSWin32 ActivePerl's iThreads", $how_many if $Config{osname} eq 'MSWin32';
+     skip "Perl version is older than 5.8.8", $how_many if $^V and $^V lt v5.8.8;
++    # TODO: try enabling this when firebird 3 is released stable
++    skip "thread tests unstable under load", $how_many
++        if $ENV{AUTOMATED_TESTING};
+     eval { require threads };
+     skip "unable to use threads;", $how_many if $@;
+ 
+-- 
+1.8.5.2
+

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libdbd-firebird-perl.git