[libtest-bdd-cucumber-perl] 38/52: filename creation is now portable

Intrigeri intrigeri at moszumanska.debian.org
Thu Jun 19 10:18:35 UTC 2014


This is an automated email from the git hooks/post-receive script.

intrigeri pushed a commit to annotated tag 0.19
in repository libtest-bdd-cucumber-perl.

commit 998972f53d5ab18fc4277a4097b9301a4156c7f9
Author: glauschwuffel <glauschwuffel at nomaden.org>
Date:   Sat May 31 12:33:53 2014 +0200

    filename creation is now portable
---
 lib/Test/BDD/Cucumber/.#I18n.pm |  1 -
 lib/Test/BDD/Cucumber/I18n.pm   | 14 ++++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/lib/Test/BDD/Cucumber/.#I18n.pm b/lib/Test/BDD/Cucumber/.#I18n.pm
deleted file mode 120000
index 61182e7..0000000
--- a/lib/Test/BDD/Cucumber/.#I18n.pm
+++ /dev/null
@@ -1 +0,0 @@
-glauschwuffel at GregorGoldbachMBP-2.local.265
\ No newline at end of file
diff --git a/lib/Test/BDD/Cucumber/I18n.pm b/lib/Test/BDD/Cucumber/I18n.pm
index 3e29711..6f38dd8 100644
--- a/lib/Test/BDD/Cucumber/I18n.pm
+++ b/lib/Test/BDD/Cucumber/I18n.pm
@@ -33,26 +33,24 @@ use Encode qw(encode);
 use JSON::XS;
 use utf8;
 use Ouch;
+use File::ShareDir qw( dist_dir );
+use File::Spec;
 
 use base 'Exporter';
 
 our @EXPORT_OK=qw(languages langdef has_language readable_keywords keyword_to_subname);
 
-use File::ShareDir qw( dist_dir );
-
-my $dir=dist_dir('My-Dist');       # dir with files from $dist/share
-my $filename=$dir.'/i18n.json'; # TODO FileSpec
+my $dir=dist_dir('My-Dist');
+my $filename=File::Spec->catfile($dir, 'i18n.json');
 ouch 'i18n_error', 'I18n file does not exist', $filename unless -e $filename;
 my $success=open(my $fh, '<', $filename);
 ouch 'i18n_error', "Unable to open i18n file: $!", $filename unless $success;
 
-# Parse keywords hash for all supported languages from the DATA segment
-#my $json      = join '', (<DATA>);
+# Parse keywords hash for all supported languages from the JSON file
 my $json      = join '', (<$fh>);
-#my $json_utf8 = encode('UTF-8', $json);
 my $langdefs  = decode_json( $json );
 
-# strip asterisks from the keyword definitions since they don't work anyway
+# strip asterisks from the keyword definitions since they don't work yet
 for my $language ( languages() ) {
   my $langdef=langdef($language);
     for my $key ( keys %$langdef ) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libtest-bdd-cucumber-perl.git



More information about the Pkg-perl-cvs-commits mailing list