[libhttp-throwable-perl] 01/02: require Package::Variant 1.002000 or later
Jonas Smedegaard
dr at jones.dk
Tue Aug 11 09:55:34 UTC 2015
This is an automated email from the git hooks/post-receive script.
js pushed a commit to annotated tag 0.024
in repository libhttp-throwable-perl.
commit 3ca41aafcdda1066e97be2c18a07527851808770
Author: Ricardo Signes <rjbs at cpan.org>
Date: Mon Aug 10 08:46:12 2015 -0400
require Package::Variant 1.002000 or later
based on report
http://www.cpantesters.org/cpan/report/4bb61f6c-6bf5-1014-87ce-3fdc1c0426fa
and subsequent testing
also, provide better error message in tester when the thrown
exception isn't an object
---
Changes | 1 +
lib/HTTP/Throwable/Variant.pm | 2 +-
t/lib/Test/HT.pm | 13 ++++++++++---
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/Changes b/Changes
index c6c0977..88f33f5 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,7 @@
Revision history for Perl extension HTTP::Throwable
{{$NEXT}}
+ - update Package::Variant requirement based on CPAN testers reports
0.023 2015-08-08 09:08:51-04:00 America/New_York
- fix one last bit of Moose that snuck through
diff --git a/lib/HTTP/Throwable/Variant.pm b/lib/HTTP/Throwable/Variant.pm
index 6c13569..e3f690e 100644
--- a/lib/HTTP/Throwable/Variant.pm
+++ b/lib/HTTP/Throwable/Variant.pm
@@ -3,7 +3,7 @@ package HTTP::Throwable::Variant;
use strict;
use warnings;
-use Package::Variant
+use Package::Variant 1.002000
importing => ['Moo', 'MooX::StrictConstructor'],
subs => [ qw(extends with) ];
diff --git a/t/lib/Test/HT.pm b/t/lib/Test/HT.pm
index 78da3d7..1be4f98 100644
--- a/t/lib/Test/HT.pm
+++ b/t/lib/Test/HT.pm
@@ -3,7 +3,7 @@ use strict;
use warnings;
use HTTP::Throwable::Factory;
-use Scalar::Util qw(reftype);
+use Scalar::Util qw(blessed reftype);
use Test::Deep qw(cmp_deeply bag);
use Test::Fatal;
use Test::More;
@@ -51,8 +51,15 @@ sub ht_test {
$factory_class->throw($identifier, $arg);
};
- ok( $err->does('HTTP::Throwable') );
- ok( $err->does('Throwable') );
+ if (ok( blessed($err), "thrown exception is an object")) {
+ ok( $err->does('HTTP::Throwable') );
+ ok( $err->does('Throwable') );
+ } else {
+ diag "want: a blessed exception object";
+ diag "have: $err";
+
+ die "further testing would be useless";
+ }
if (my $code = $extra->{code}) {
is($err->status_code, $code, "got expected status code");
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libhttp-throwable-perl.git
More information about the Pkg-perl-cvs-commits
mailing list