[openpgp-applet] 52/61: Perl::Critic - correct severe violations

Clement Hermann nodens at nodens.org
Tue Aug 18 18:51:45 UTC 2015


This is an automated email from the git hooks/post-receive script.

nodens-guest pushed a commit to annotated tag OpenPGP_Applet-0.9
in repository openpgp-applet.

commit 1f30a1787fc08a52a8349e91ea3cc1bbe9e33e12
Author: Clément Hermann (nodens) <nodens at nodens.org>
Date:   Sat Dec 6 21:57:41 2014 +0100

    Perl::Critic - correct severe violations
    
    public_crypto :
    Variables shouldn't be declared in conditionnal statement, as it is
    confusing. Afterwards, it's checked in scalar context so it should be OK if it
    is defined but empty.
---
 bin/openpgp-applet | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/openpgp-applet b/bin/openpgp-applet
index 7fcd7ac..710c103 100755
--- a/bin/openpgp-applet
+++ b/bin/openpgp-applet
@@ -651,7 +651,7 @@ sub public_crypto {
     my $chosen = choose_keys(\@priv_keys, \@pub_keys);
     my $signer = $chosen->{signer};
     my $recipients_ref = $chosen->{recipients};
-    my @recipients = @{$recipients_ref} if defined $recipients_ref;
+    my @recipients; @recipients = @{$recipients_ref} if defined $recipients_ref;
     my $always_trust = $chosen->{always_trust};
     my $hide_recipients = $chosen->{hide_recipients};
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/openpgp-applet.git



More information about the Pkg-perl-cvs-commits mailing list