[libio-event-perl] 01/03: Patch the test suite to fix undeterministic test failures in t/forked2.t

Niko Tyni ntyni at moszumanska.debian.org
Sat Dec 12 09:59:56 UTC 2015


This is an automated email from the git hooks/post-receive script.

ntyni pushed a commit to branch master
in repository libio-event-perl.

commit 0564ed2706165087fd9b71edb29fa5a6fce5dfd8
Author: Niko Tyni <ntyni at debian.org>
Date:   Sat Dec 12 11:33:34 2015 +0200

    Patch the test suite to fix undeterministic test failures in t/forked2.t
    
    Closes: #730908
---
 ...eterministic-test-failures-in-t-forked2.t.patch | 35 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 2 files changed, 36 insertions(+)

diff --git a/debian/patches/0001-Fix-undeterministic-test-failures-in-t-forked2.t.patch b/debian/patches/0001-Fix-undeterministic-test-failures-in-t-forked2.t.patch
new file mode 100644
index 0000000..0691b51
--- /dev/null
+++ b/debian/patches/0001-Fix-undeterministic-test-failures-in-t-forked2.t.patch
@@ -0,0 +1,35 @@
+From e11dc91080151bb59d73e72c3c0a3409c1b999ef Mon Sep 17 00:00:00 2001
+From: Niko Tyni <ntyni at debian.org>
+Date: Sat, 12 Dec 2015 11:33:34 +0200
+Subject: [PATCH] Fix undeterministic test failures in t/forked2.t
+
+The parent process may get both the eof event from an old connection
+and the connect event from a new connection at the same time, and in an
+unpredictable order. If the connect event comes first, the handler may
+decrement the test counter to zero and make the eof handler think the
+testing is already over.
+
+Having the child synchronize on the eof event before making a new
+connection fixes this race.
+
+Bug-Debian: https://bugs.debian.org/730908
+Bug: https://rt.cpan.org/Ticket/Display.html?id=92200
+---
+ t/forked.tt | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/t/forked.tt b/t/forked.tt
+index e56c7fa..0d9ce18 100755
+--- a/t/forked.tt
++++ b/t/forked.tt
+@@ -265,6 +265,7 @@ if ($child = fork()) {
+ 		}
+ 		print "# CHILD closing\n";
+ 		close($s);
++		syncto("e");
+ 	}
+ } else {
+ 	die "fork: $!";
+-- 
+2.6.2
+
diff --git a/debian/patches/series b/debian/patches/series
index 682701d..35ee80f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 pod-error.patch
+0001-Fix-undeterministic-test-failures-in-t-forked2.t.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libio-event-perl.git



More information about the Pkg-perl-cvs-commits mailing list