[libmarc-lint-perl] 01/02: Fix test failures due to Business::ISBN version mess

Niko Tyni ntyni at moszumanska.debian.org
Wed Dec 30 10:37:30 UTC 2015


This is an automated email from the git hooks/post-receive script.

ntyni pushed a commit to branch master
in repository libmarc-lint-perl.

commit 5ab9e042e4da4a4623320101b563587f5b522e6b
Author: Niko Tyni <ntyni at debian.org>
Date:   Sun Dec 27 17:02:33 2015 +0200

    Fix test failures due to Business::ISBN version mess
    
    Business::ISBN changed its version from 2.09 to 2.010,
    breaking the version comparisons in MARC::Lint.
    
    Closes: #809100
---
 debian/control                                     |  4 +--
 ...ailures-due-to-Business-ISBN-version-mess.patch | 38 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 3 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 227a6b4..a777754 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Section: perl
 Priority: optional
 Build-Depends: debhelper (>= 8)
 Build-Depends-Indep: perl,
-                     libbusiness-isbn-perl,
+                     libbusiness-isbn-perl (>= 2.010),
                      libmarc-record-perl
 Standards-Version: 3.9.6
 Vcs-Browser: https://anonscm.debian.org/cgit/pkg-perl/packages/libmarc-lint-perl.git
@@ -22,7 +22,7 @@ Package: libmarc-lint-perl
 Architecture: all
 Depends: ${perl:Depends},
          ${misc:Depends},
-         libbusiness-isbn-perl,
+         libbusiness-isbn-perl (>= 2.010),
          libmarc-record-perl
 Description: Perl extension for checking validity of MARC records
  MARC::Lint is a Perl module for checking the validity of MARC records. Most
diff --git a/debian/patches/0001-Fix-test-failures-due-to-Business-ISBN-version-mess.patch b/debian/patches/0001-Fix-test-failures-due-to-Business-ISBN-version-mess.patch
new file mode 100644
index 0000000..563e4e5
--- /dev/null
+++ b/debian/patches/0001-Fix-test-failures-due-to-Business-ISBN-version-mess.patch
@@ -0,0 +1,38 @@
+From b8ff6d68cecb3bc2ff0f3d7bf0eb2aad541e796a Mon Sep 17 00:00:00 2001
+From: Niko Tyni <ntyni at debian.org>
+Date: Sun, 27 Dec 2015 17:02:33 +0200
+Subject: [PATCH] Fix test failures due to Business::ISBN version mess
+
+Business::ISBN changed its version from 2.09 to 2.010,
+breaking the version comparisons in MARC::Lint.
+
+Bug-Debian: https://bugs.debian.org/809100
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=110568
+---
+ lib/MARC/Lint.pm | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/lib/MARC/Lint.pm b/lib/MARC/Lint.pm
+index d96e78b..c401622 100755
+--- a/lib/MARC/Lint.pm
++++ b/lib/MARC/Lint.pm
+@@ -319,14 +319,14 @@ sub check_020 {
+             else {
+                 if ((length ($isbnno) == 10)) {
+ 
+-                    if ($Business::ISBN::VERSION gt '2.02_01') {
++                    if ($Business::ISBN::VERSION ge '2.010') {
+                         $self->warn( "020: Subfield a has bad checksum, $data." ) if (Business::ISBN::valid_isbn_checksum($isbnno) != 1); 
+                     } #if Business::ISBN version higher than 2.02_01
+                     elsif ($Business::ISBN::VERSION lt '2') {
+                         $self->warn( "020: Subfield a has bad checksum, $data." ) if (Business::ISBN::is_valid_checksum($isbnno) != 1); 
+                     } #elsif Business::ISBN version lower than 2
+                     else {
+-                        $self->warn( "Business::ISBN version must be below 2 or above 2.02_02." );
++                        $self->warn( "Business::ISBN version must be below 2 or at least 2.010." );
+                     } #else Business::ISBN version between 2 and 2.02_02
+                 } #if 10 digit ISBN has invalid check digit
+                 # do validation check for 13 digit isbn
+-- 
+2.6.4
+
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..0fda545
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Fix-test-failures-due-to-Business-ISBN-version-mess.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libmarc-lint-perl.git



More information about the Pkg-perl-cvs-commits mailing list