[carton] 59/472: Do not display warnings if one of the deps are not found in lock

[Lucas Kanashiro]

This is an automated email from the git hooks/post-receive script.

kanashiro-guest pushed a commit to branch master
in repository carton.

commit 3ad211789d5adfd0cbdf55e9dce9ec51a67268da
Author: Tatsuhiko Miyagawa <miyagawa at bulknews.net>
Date:   Sun Jun 26 22:13:32 2011 -0400

    Do not display warnings if one of the deps are not found in lock
    
    This happens if you have 'URI' in build file and then install LWP
    ad-hoc. URI is removed from the %pool so the tree is incomplete. In
    this case simply ignore the modules that are not found.
---
 TODO              | 1 +
 lib/Carton.pm     | 4 ++--
 lib/Carton/CLI.pm | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/TODO b/TODO
index 54641e2..9df5410 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,5 @@
 # 1.0
+Fix non-intuitive errors when Makefile.PL is not valid (in showdeps)
 carton config / .carton/config
 carton update
 clean uninstall?
diff --git a/lib/Carton.pm b/lib/Carton.pm
index e8629db..67dd933 100644
--- a/lib/Carton.pm
+++ b/lib/Carton.pm
@@ -171,7 +171,7 @@ sub is_core {
 };
 
 sub walk_down_tree {
-    my($self, $tree, $cb) = @_;
+    my($self, $tree, $cb, $no_warn) = @_;
 
     my %seen;
     $tree->walk_down(sub {
@@ -180,7 +180,7 @@ sub walk_down_tree {
 
         if ($node->metadata->{dist}) {
             $cb->($node->metadata, $depth);
-        } elsif (!$self->is_core($node->key, 0)) {
+        } elsif (!$self->is_core($node->key, 0) && !$no_warn) {
             warn "Couldn't find ", $node->key, "\n";
         }
     });
diff --git a/lib/Carton/CLI.pm b/lib/Carton/CLI.pm
index e7e44c5..6038522 100644
--- a/lib/Carton/CLI.pm
+++ b/lib/Carton/CLI.pm
@@ -219,7 +219,7 @@ sub cmd_check {
             my($module, $depth) = @_;
             print "  " x $depth;
             print "$module->{dist}\n";
-        });
+        }, 1);
         $ok = 0;
     }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/carton.git