[carton] 178/472: Ignore 'perl' key for now

Lucas Kanashiro kanashiro-guest at moszumanska.debian.org
Fri Jul 24 00:38:45 UTC 2015


This is an automated email from the git hooks/post-receive script.

kanashiro-guest pushed a commit to branch master
in repository carton.

commit 50848ff8f878e01e28a7ead2411fae77a2c72cb2
Author: Tatsuhiko Miyagawa <miyagawa at bulknews.net>
Date:   Sat Mar 30 14:41:26 2013 -0700

    Ignore 'perl' key for now
---
 lib/Carton.pm |  6 ++++--
 xt/cli/perl.t | 26 ++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/lib/Carton.pm b/lib/Carton.pm
index d11bb3f..705305c 100644
--- a/lib/Carton.pm
+++ b/lib/Carton.pm
@@ -52,10 +52,12 @@ sub list_dependencies {
 
     my $reqs = CPAN::Meta::Requirements->new;
     $reqs->add_requirements($prereq->requirements_for($_, 'requires'))
-        for qw( configure build runtime);
+        for qw( configure build runtime ); # add test
 
     my $hash = $reqs->as_string_hash;
-    return map "$_~$hash->{$_}", keys %$hash; # TODO refactor to not rely on string representation
+    # TODO refactor to not rely on string representation
+    # TODO actually check 'perl' version
+    return map "$_~$hash->{$_}", grep { $_ ne 'perl' } keys %$hash;
 }
 
 sub dedupe_modules {
diff --git a/xt/cli/perl.t b/xt/cli/perl.t
new file mode 100644
index 0000000..ddd9477
--- /dev/null
+++ b/xt/cli/perl.t
@@ -0,0 +1,26 @@
+use strict;
+use Test::More;
+use xt::CLI;
+use Cwd;
+
+my $cwd = Cwd::cwd();
+
+{
+    my $app = cli();
+
+    $app->dir->touch("cpanfile", <<EOF);
+requires 'perl', '5.8.5';
+requires 'Hash::MultiValue';
+EOF
+
+    $app->run("install");
+    like $app->output, qr/Complete/;
+
+    $app->run("list");
+    like $app->output, qr/Hash-MultiValue-/;
+}
+
+done_testing;
+
+
+

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/carton.git



More information about the Pkg-perl-cvs-commits mailing list