[carton] 217/472: added TODO test for #83

Lucas Kanashiro kanashiro-guest at moszumanska.debian.org
Fri Jul 24 00:38:48 UTC 2015


This is an automated email from the git hooks/post-receive script.

kanashiro-guest pushed a commit to branch master
in repository carton.

commit 5c5d0bf8843ceaf777315ee1596e04c7760c07a5
Author: Tatsuhiko Miyagawa <miyagawa at bulknews.net>
Date:   Fri May 31 01:22:21 2013 +0900

    added TODO test for #83
---
 lib/Carton/Index.pm |  2 +-
 xt/cli/json_pp.t    | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/lib/Carton/Index.pm b/lib/Carton/Index.pm
index cbcd15b..456e2b1 100644
--- a/lib/Carton/Index.pm
+++ b/lib/Carton/Index.pm
@@ -8,7 +8,7 @@ sub new {
 
 sub add_package {
     my($self, $package) = @_;
-    $self->{packages}{$package->name} ||= $package;
+    $self->{packages}{$package->name} = $package; # XXX ||=
 }
 
 sub count {
diff --git a/xt/cli/json_pp.t b/xt/cli/json_pp.t
new file mode 100644
index 0000000..246f07b
--- /dev/null
+++ b/xt/cli/json_pp.t
@@ -0,0 +1,28 @@
+use strict;
+use Test::More;
+use xt::CLI;
+
+use File::Path qw(rmtree);
+
+plan skip_all => "perl <= 5.14" if $] >= 5.015;
+
+{
+    my $app = cli();
+
+    $app->dir->touch("cpanfile", <<EOF);
+requires 'JSON';
+requires 'CPAN::Meta', '2.12';
+EOF
+
+    $app->run("install");
+    rmtree($app->dir . "/local", 1);
+
+    TODO: {
+        local $TODO = "collect installs";
+        $app->run("install", "--deployment");
+        unlike $app->system_error, qr/JSON::PP is not in range/;
+    }
+}
+
+done_testing;
+

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/carton.git



More information about the Pkg-perl-cvs-commits mailing list