[libanyevent-rabbitmq-perl] 01/05: Revert (possibly) ill-adviced changes to copyright file

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to branch master
in repository libanyevent-rabbitmq-perl.

commit 88753aead068d814d83cae5a30e94a7b83b401fd
Author: Jonas Smedegaard <dr at jones.dk>
Date:   Fri Jul 24 11:29:26 2015 +0200

    Revert (possibly) ill-adviced changes to copyright file
    
    Commit consisted of several changes, vaguely described as "Improve it":
    
     a) Switch of "Upstream-Contact" from issue tracker to personal email
     b) Removal of alternative upstream source URL
     c) Removal of repackaging notice from Source field
     d) Move of verbatim licensing from Files section to License section
     e) Indentation change from single space to vertically aligned
    
    Regarding a):
    
    The "Upstream-Contact" field is for listing the preferred form of
    contact.  Generally I consider that to be the first available of these:
    
     * contact form explicitly stated as such by upstream
     * upstream issue tracker
     * upstream developers' mailinglist
     * upstream general mailinglist
     * personal email of main upstream author
    
    Regarding b):
    
    I see no need for or improvement in removing alternative source URL.
    
    Regarding c):
    
    Machine-readable file format mandates Source field to include mention of
    repackaging.
    
    Regarding d):
    
    The "...same as Perl..." statement common for perl modules is a
    licensing statement and should therefore be included verbatim, but it is
    not a license (neither GPL nor Artistic specifically) so does not belong
    in a License section.  See bug#786450 for more recent and less confusing
    pattern addressing this.
    
    Regarding e):
    
    Indentation style is subjective.  I prefer avoiding excess space except
    left-most for indentation (where I prefer TAB over space when allowed).
    
    I see no need for or improvement in changing indentation style, and find
    it wrong to do so without coordination with peer package maintainers
    (i.e. those listed in Uploaders field in control file).
    
    For each of above, if insisting on the change then please re-commit each
    logic change _separately_ with _descriptive_ commit message (single-line
    commit message ok but virtually empty message is rarely if ever fine).
    
    This reverts commit c254e2437dd7e156da3c4d98511561d7c9c631b6.
---
 debian/changelog |  1 -
 debian/copyright | 21 ++++++++++++++-------
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 3b14597..05c679d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,7 +3,6 @@ libanyevent-rabbitmq-perl (1.19-1) unstable; urgency=medium
   * Team upload.
   * Imported Upstream version 1.19
   * debian/control: Bump standard version
-  * debian/copyright: Improve it
 
  -- Lucas Kanashiro <kanashiro.duarte at gmail.com>  Thu, 23 Jul 2015 00:52:19 -0300
 
diff --git a/debian/copyright b/debian/copyright
index 9e781a7..6e7604a 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,7 +1,10 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: AnyEvent::RabbitMQ
-Upstream-Contact: Dave Lambley <dlambley at cpan.org>
+Upstream-Contact: http://rt.cpan.org/NoAuth/Bugs.html?Dist=AnyEvent-RabbitMQ
 Source: https://metacpan.org/release/AnyEvent-RabbitMQ
+ git://github.com/bobtfish/AnyEvent-RabbitMQ
+ .
+ Repackaged, excluding non-DFSG files
 Files-Excluded:
  share/fixed_amqp0-8.xml
  share/fixed_amqp0-9-1.xml
@@ -10,13 +13,20 @@ Files: *
 Copyright: 2010, Masahito Ikuta <cooldaemon at gmail.com>
 License: Artistic or GPL-1+
 Comment:
+ License:
+ .
+ This library is free software; you can redistribute it and/or modify it
+ under the same terms as Perl itself.
+ .
+ Comment:
+ .
  Perl 5 is licensed under either the 'Artistic license' or the 'GNU
  General Public License' version 1 or later.
 
 Files: inc/Module/Install*
-Copyright: 2001-2006,      Audrey Tang <autrijus at autrijus.org>
-           2002-2004,      Brian Ingerson <ingy at cpan.org>
-           2006,2008-2012, Adam Kennedy <adamk at cpan.org>
+Copyright: 2001-2006, Audrey Tang <autrijus at autrijus.org>
+  2002-2004, Brian Ingerson <ingy at cpan.org>
+  2006,2008-2012, Adam Kennedy <adamk at cpan.org>
 License: Artistic or GPL-1+
 Comment:
  Mangled convenience copy of Module::Install.
@@ -29,12 +39,9 @@ Comment:
 
 Files: debian/*
 Copyright: 2013-2014, Jonas Smedegaard <dr at jones.dk>
-           2015,      Lucas Kanashiro <kanashiro.duarte at gmail.com>
 License: GPL-3+
 
 License: Artistic
- This library is free software; you can redistribute it and/or modify it
- under the same terms as Perl itself.
  Comment:
  .
  On Debian systems the 'Artistic License' is located in

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libanyevent-rabbitmq-perl.git