[libnet-dbus-perl] 309/335: Treat org.freedesktop.DBus.Error.NoReply as fatal when introspecting

Intrigeri intrigeri at moszumanska.debian.org
Sat Mar 21 01:08:14 UTC 2015


This is an automated email from the git hooks/post-receive script.

intrigeri pushed a commit to branch experimental
in repository libnet-dbus-perl.

commit 670a728781e1aca2ce68a14d50bc5a97c55eec06
Author: Vitaliy Gusev <gusev.vitaliy at nexenta.com>
Date:   Mon Nov 28 20:56:47 2011 +0000

    Treat org.freedesktop.DBus.Error.NoReply as fatal when introspecting
    
    When a connection to dbus is lost, introspecting will return
    org.freedesktop.DBus.Error.NoReply after timing out. If we ignore
    this error, there will then be another timeout when we try to
    invoke the method. Treating org.freedesktop.DBus.Error.NoReply
    as fatal ensures we push this fatal problem back to the client
    app as soon as possible
---
 lib/Net/DBus/RemoteObject.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Net/DBus/RemoteObject.pm b/lib/Net/DBus/RemoteObject.pm
index dc08bc5..2f5715d 100644
--- a/lib/Net/DBus/RemoteObject.pm
+++ b/lib/Net/DBus/RemoteObject.pm
@@ -204,7 +204,8 @@ sub _net_dbus_introspector {
 	};
 	if ($@) {
 	    if (UNIVERSAL::isa($@, "Net::DBus::Error") &&
-		$@->{name} eq "org.freedesktop.DBus.Error.ServiceUnknown") {
+		($@->{name} eq "org.freedesktop.DBus.Error.ServiceUnknown" ||
+		$@->{name} eq "org.freedesktop.DBus.Error.NoReply")) {
 		die $@;
 	    } else {
 		# Ignore other failures, since its probably

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libnet-dbus-perl.git



More information about the Pkg-perl-cvs-commits mailing list