[libglib-perl] 01/02: sort_podify_signals: new patch, that makes the generated signals POD not randomly ordered. Thanks to akira <marivalenm at gmail.com>! (Closes: #777289)

Intrigeri intrigeri at moszumanska.debian.org
Sat May 2 13:01:19 UTC 2015


This is an automated email from the git hooks/post-receive script.

intrigeri pushed a commit to branch master
in repository libglib-perl.

commit a09454007d7ab6d742cae9f38aa6b9b057201d5f
Author: intrigeri <intrigeri at boum.org>
Date:   Sat May 2 12:42:03 2015 +0000

    sort_podify_signals: new patch, that makes the generated signals POD not randomly ordered. Thanks to akira <marivalenm at gmail.com>! (Closes: #777289)
---
 debian/patches/series              |  1 +
 debian/patches/sort_podify_signals | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/debian/patches/series b/debian/patches/series
index 57e5a8e..8c2c9ac 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 fix-gtks-whatis
 remove-version-checking
 fix-man-pages
+sort_podify_signals
diff --git a/debian/patches/sort_podify_signals b/debian/patches/sort_podify_signals
new file mode 100644
index 0000000..491e71c
--- /dev/null
+++ b/debian/patches/sort_podify_signals
@@ -0,0 +1,22 @@
+Description: sort the output of podify_signals
+ The output of Glib::Type->list_signals is unsorted. This results in the 
+ generated pod files to be in random order which makes packages using signals 
+ compile not reproducibly [1]. It was suggested to Glib upstream [2] to sort
+ the output of g_signal_list_ids but it got rejected. Thus the change has to 
+ be made here. 
+ [1] https://wiki.debian.org/ReproducibleBuilds/About
+ [2] https://bugzilla.gnome.org/show_bug.cgi?id=743863  
+Author: akira <marivalenm at gmail.com>
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=748796
+
+--- libglib-perl-1.305.orig/lib/Glib/GenPod.pm
++++ libglib-perl-1.305/lib/Glib/GenPod.pm
+@@ -716,7 +716,7 @@ sub podify_signals {
+ 	my @sigs = Glib::Type->list_signals (shift);
+ 	return undef unless @sigs;
+ 	$str = "=over\n\n";
+-	foreach (@sigs) {
++	foreach (sort {$a->{signal_name} cmp $b->{signal_name} } @sigs) {
+ 		$str .= '=item ';
+ 		$str .= convert_type ($_->{return_type}).' = '
+ 			if exists $_->{return_type};

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libglib-perl.git



More information about the Pkg-perl-cvs-commits mailing list