[libdbix-safe-perl] 06/11: Revert direct changes to upstream code.

gregor herrmann gregoa at debian.org
Sat May 2 19:09:47 UTC 2015


This is an automated email from the git hooks/post-receive script.

gregoa pushed a commit to branch master
in repository libdbix-safe-perl.

commit 24f40a64cbadc5e08190f261fd1b4f7222c2b50b
Author: gregor herrmann <gregoa at debian.org>
Date:   Sat May 2 21:04:11 2015 +0200

    Revert direct changes to upstream code.
---
 Safe.pm.html     | 18 +++++++-----------
 t/02perlcritic.t | 10 ++++++++++
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/Safe.pm.html b/Safe.pm.html
index 72c55b4..5fef4f5 100644
--- a/Safe.pm.html
+++ b/Safe.pm.html
@@ -9,10 +9,8 @@
 
 <body style="background-color: white">
 
-
-<!-- INDEX BEGIN -->
-<div name="index">
 <p><a name="__index__"></a></p>
+<!-- INDEX BEGIN -->
 
 <ul>
 
@@ -48,11 +46,9 @@
 	<li><a href="#author">AUTHOR</a></li>
 	<li><a href="#license_and_copyright">LICENSE AND COPYRIGHT</a></li>
 </ul>
-
-<hr name="index" />
-</div>
 <!-- INDEX END -->
 
+<hr />
 <p>
 </p>
 <hr />
@@ -90,7 +86,7 @@ rather than simply passing it a raw database handle through DBI. DBIx::Safe acts
 a wrapper to the database, by only allowing through the commands you tell it to. It 
 filters all things related to the database handle - methods and attributes.</p>
 <p>The typical usage is for your application to create a database handle via a normal 
-DBI call to <code>new()</code>, then pass that to DBIx::Safe-><code>new()</code>, which will return you a 
+DBI call to new(), then pass that to DBIx::Safe->new(), which will return you a 
 DBIx::Safe object. After specifying exactly what is and what is not allowed, you can 
 pass the object to the untrusted application. The object will act very similar to a 
 DBI database handle, and in most cases can be used interchangeably.</p>
@@ -121,15 +117,15 @@ semicolons).</p>
 <h2><a name="deciding_what_attributes_to_allow">Deciding what attributes to allow</a></h2>
 <p>Database handle attributes are controlled by a single list of allowed keys. If the 
 key is allowed, the underlying database handle value is returned or changed (or both). 
-Note that the attribute "AutoCommit" is never allowed to be changed.</p>
+Note that the attribute ``AutoCommit'' is never allowed to be changed.</p>
 <p>
 </p>
 <h2><a name="methods">Methods</a></h2>
 <p>
 </p>
 <h3><a name="new__"><code>new()</code></a></h3>
-<p>Creates a new DBIx::Safe object. Requires a mandatory "dbh" argument containing an active database 
-handle. Optional arguments are "allow_command", "allow_regex", "deny_regex", and "allow_attribute".</p>
+<p>Creates a new DBIx::Safe object. Requires a mandatory ``dbh'' argument containing an active database 
+handle. Optional arguments are ``allow_command'', ``allow_regex'', ``deny_regex'', and ``allow_attribute''.</p>
 <p>
 </p>
 <h3><a name="allow_command__"><code>allow_command()</code></a></h3>
@@ -152,7 +148,7 @@ or an arrayref of regular expressions. Returns the current list.</p>
 <p>
 </p>
 <h3><a name="deny_regex__"><code>deny_regex()</code></a></h3>
-<p>Specifies regular expressions which are NOT allowed to run. Arguments and return the same as <code>allow_regex()</code>.</p>
+<p>Specifies regular expressions which are NOT allowed to run. Arguments and return the same as allow_regex().</p>
 <p>
 </p>
 <h3><a name="undeny_regex__">undeny <code>regex()</code></a></h3>
diff --git a/t/02perlcritic.t b/t/02perlcritic.t
index 5bc479a..4d2ebec 100644
--- a/t/02perlcritic.t
+++ b/t/02perlcritic.t
@@ -36,3 +36,13 @@ if (! -e $CODE) {
 plan tests => 1;
 Test::Perl::Critic->import( -profile => $PROFILE );
 critic_ok($CODE);
+#all_critic_ok();
+
+__DATA__
+
+plan tests => 1;
+my $critic = Perl::Critic->new(-profile => $PROFILE);
+my @problems = $critic->critique($CODE);
+is(@problems, 0, "Passed Perl::Critic run");
+use Data::Dumper;
+

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libdbix-safe-perl.git



More information about the Pkg-perl-cvs-commits mailing list