[libhtml-strip-perl] 01/03: Clean away an unused double DESTROY method. (Closes: #785032)

Niko Tyni ntyni at moszumanska.debian.org
Sun May 24 12:25:32 UTC 2015


This is an automated email from the git hooks/post-receive script.

ntyni pushed a commit to branch master
in repository libhtml-strip-perl.

commit c6398a9cad3150dd6b5cefb049ab26fe6e81f571
Author: Niko Tyni <ntyni at debian.org>
Date:   Sun May 24 15:11:43 2015 +0300

    Clean away an unused double DESTROY method. (Closes: #785032)
    
    Bug: https://rt.cpan.org/Public/Bug/Display.html?id=104379
    Bug-Debian: https://bugs.debian.org/785032
    
    There are DESTROY methods in both the XS and the Perl parts,
    and the former overrides the latter. Explicitly patch away
    the former one to squelch the justified warning.
    
    This may leave a small memory leak, but that isn't a regression
    as the code never got called anyway.
---
 debian/patches/double-destroy.patch | 24 ++++++++++++++++++++++++
 debian/patches/series               |  1 +
 2 files changed, 25 insertions(+)

diff --git a/debian/patches/double-destroy.patch b/debian/patches/double-destroy.patch
new file mode 100644
index 0000000..9be0fbb
--- /dev/null
+++ b/debian/patches/double-destroy.patch
@@ -0,0 +1,24 @@
+Subject: clean away an unused double DESTROY method
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=104379
+Bug-Debian: https://bugs.debian.org/785032
+
+There are DESTROY methods in both the XS and the Perl parts,
+and the former overrides the latter. Explicitly patch away
+the former one to squelch the justified warning.
+
+This may leave a small memory leak, but that isn't a regression
+as the code never got called anyway.
+
+--- libhtml-strip-perl.orig/Strip.pm
++++ libhtml-strip-perl/Strip.pm
+@@ -66,10 +66,6 @@
+         return $filter_of{0+$self}
+     }
+ 
+-    sub DESTROY {
+-        my $self = shift;
+-        delete $filter_of{0+$self};
+-    }
+ }
+ 
+ # $decoded_string = $self->filter_entities( $string )
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..685a70a
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+double-destroy.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libhtml-strip-perl.git



More information about the Pkg-perl-cvs-commits mailing list