[license-reconcile] 01/02: Code reviewed: bin/license-reconcile [in progress]

Nicholas Bamber periapt at moszumanska.debian.org
Tue Nov 10 23:13:44 UTC 2015 

This is an automated email from the git hooks/post-receive script.

periapt pushed a commit to branch master
in repository license-reconcile.

commit 01477d4f77e9d252d0952e5cdb2bdab3ef857b36
Author: Nicholas Bamber <nicholas at periapt.co.uk>
Date:   Sun Nov 8 00:06:19 2015 +0000

    Code reviewed: bin/license-reconcile [in progress]
---
 bin/license-reconcile                                | 17 ++++++++++++-----
 debian/changelog                                     |  6 ++++++
 lib/Debian/LicenseReconcile.pm                       |  4 ++--
 lib/Debian/LicenseReconcile/App.pm                   |  4 ++--
 lib/Debian/LicenseReconcile/CopyrightDatum.pm        |  4 ++--
 lib/Debian/LicenseReconcile/CopyrightDatum/Holder.pm |  4 ++--
 lib/Debian/LicenseReconcile/CopyrightTarget.pm       |  4 ++--
 lib/Debian/LicenseReconcile/Errors.pm                |  4 ++--
 lib/Debian/LicenseReconcile/Filter.pm                |  4 ++--
 lib/Debian/LicenseReconcile/Filter/ChangeLog.pm      |  4 ++--
 lib/Debian/LicenseReconcile/Filter/Rules.pm          |  4 ++--
 lib/Debian/LicenseReconcile/Filter/Shebang.pm        |  4 ++--
 lib/Debian/LicenseReconcile/Filter/Std.pm            |  4 ++--
 lib/Debian/LicenseReconcile/FormatSpec.pm            |  4 ++--
 lib/Debian/LicenseReconcile/LicenseCheck.pm          |  4 ++--
 lib/Debian/LicenseReconcile/Utils.pm                 |  4 ++--
 16 files changed, 46 insertions(+), 33 deletions(-)

diff --git a/bin/license-reconcile b/bin/license-reconcile
index 8c7f9ce..d57c111 100755
--- a/bin/license-reconcile
+++ b/bin/license-reconcile
@@ -5,11 +5,19 @@ use Getopt::Long;
 use Pod::Usage;
 use Debian::LicenseReconcile::App;
 
+# Command line options for documentation
 my $man = 0;
 my $help = 0;
+
+# If this is set we don't actually report errors
+# at all, but merely succeed or fail.
+# TODO: abstract output to allow flexibility of reporting
 my $quiet = 0;
+
+# TODO: What's this again?
 my $display_mapping = 0;
-my $directory = ".";
+my $check_copyright = 1;
+my $format_spec = 1;
 
 # Ordered list of filters used to process the code
 # Rules:	config driven set of rules
@@ -19,13 +27,12 @@ my $directory = ".";
 # Default:	last chance rules, Rules code renamed to Default
 my @filters = qw(Rules ChangeLog Std Shebang Default~Rules);
 my @filters_override = ();
+
+# Defaut location of various files
 my $config_file = 'debian/license-reconcile.yml';
 my $changelog_file = 'debian/changelog';
-
+my $directory = ".";
 my $copyright_file = 'debian/copyright';
-my $check_copyright = 1;
-
-my $format_spec = 1;
 
 GetOptions(
     'help|?' => \$help,
diff --git a/debian/changelog b/debian/changelog
index b46ba73..8d4c505 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+license-reconcile (0.9) UNRELEASED; urgency=medium
+
+  * Code reviewed: bin/license-reconcile [in progress]
+
+ -- Nicholas Bamber <nicholas at periapt.co.uk>  Sat, 07 Nov 2015 23:55:16 +0000
+
 license-reconcile (0.8) unstable; urgency=medium
 
   [ gregor herrmann ]
diff --git a/lib/Debian/LicenseReconcile.pm b/lib/Debian/LicenseReconcile.pm
index 1abad88..1230d3e 100644
--- a/lib/Debian/LicenseReconcile.pm
+++ b/lib/Debian/LicenseReconcile.pm
@@ -50,11 +50,11 @@ Debian::LicenseReconcile - compare actual and required copyright and license
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/App.pm b/lib/Debian/LicenseReconcile/App.pm
index 90e35c7..08f8f08 100644
--- a/lib/Debian/LicenseReconcile/App.pm
+++ b/lib/Debian/LicenseReconcile/App.pm
@@ -209,11 +209,11 @@ Debian::LicenseReconcile::App - encapsulate the application code
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/CopyrightDatum.pm b/lib/Debian/LicenseReconcile/CopyrightDatum.pm
index 4fb32b5..9ce5ee0 100644
--- a/lib/Debian/LicenseReconcile/CopyrightDatum.pm
+++ b/lib/Debian/LicenseReconcile/CopyrightDatum.pm
@@ -211,11 +211,11 @@ Debian::LicenseReconcile::CopyrightDatum - copyright data as an object
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 =head1 DESCRIPTION
 
diff --git a/lib/Debian/LicenseReconcile/CopyrightDatum/Holder.pm b/lib/Debian/LicenseReconcile/CopyrightDatum/Holder.pm
index 514c659..cc58a8d 100644
--- a/lib/Debian/LicenseReconcile/CopyrightDatum/Holder.pm
+++ b/lib/Debian/LicenseReconcile/CopyrightDatum/Holder.pm
@@ -61,11 +61,11 @@ Debian::LicenseReconcile::CopyrightDatum::Holder - encapsulate pair
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/CopyrightTarget.pm b/lib/Debian/LicenseReconcile/CopyrightTarget.pm
index 76cad86..2abebd0 100644
--- a/lib/Debian/LicenseReconcile/CopyrightTarget.pm
+++ b/lib/Debian/LicenseReconcile/CopyrightTarget.pm
@@ -100,11 +100,11 @@ Debian::LicenseReconcile::CopyrightTarget - file patterns mapped to Debian copyr
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Errors.pm b/lib/Debian/LicenseReconcile/Errors.pm
index 362d990..927dc78 100644
--- a/lib/Debian/LicenseReconcile/Errors.pm
+++ b/lib/Debian/LicenseReconcile/Errors.pm
@@ -29,11 +29,11 @@ Debian::LicenseReconcile::Errors - list of license reconciliation errors
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Filter.pm b/lib/Debian/LicenseReconcile/Filter.pm
index b21fa72..c60d63b 100644
--- a/lib/Debian/LicenseReconcile/Filter.pm
+++ b/lib/Debian/LicenseReconcile/Filter.pm
@@ -91,11 +91,11 @@ Debian::LicenseReconcile::Filter - abstract interface to license info
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Filter/ChangeLog.pm b/lib/Debian/LicenseReconcile/Filter/ChangeLog.pm
index eaf6920..4bd6ff4 100644
--- a/lib/Debian/LicenseReconcile/Filter/ChangeLog.pm
+++ b/lib/Debian/LicenseReconcile/Filter/ChangeLog.pm
@@ -96,11 +96,11 @@ Debian::LicenseReconcile::Filter::ChangeLog - parses changelog
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Filter/Rules.pm b/lib/Debian/LicenseReconcile/Filter/Rules.pm
index 98c808d..fbe990e 100644
--- a/lib/Debian/LicenseReconcile/Filter/Rules.pm
+++ b/lib/Debian/LicenseReconcile/Filter/Rules.pm
@@ -57,11 +57,11 @@ Debian::LicenseReconcile::Filter::Rules - applies licensecheck to get data
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Filter/Shebang.pm b/lib/Debian/LicenseReconcile/Filter/Shebang.pm
index bc5a4df..0c4e31d 100644
--- a/lib/Debian/LicenseReconcile/Filter/Shebang.pm
+++ b/lib/Debian/LicenseReconcile/Filter/Shebang.pm
@@ -32,11 +32,11 @@ Debian::LicenseReconcile::Filter::Shebang - applies licensecheck to probable scr
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Filter/Std.pm b/lib/Debian/LicenseReconcile/Filter/Std.pm
index 61efdce..f8f004a 100644
--- a/lib/Debian/LicenseReconcile/Filter/Std.pm
+++ b/lib/Debian/LicenseReconcile/Filter/Std.pm
@@ -17,11 +17,11 @@ Debian::LicenseReconcile::Filter::Std - applies licensecheck to get data
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/FormatSpec.pm b/lib/Debian/LicenseReconcile/FormatSpec.pm
index 1d697e9..6715598 100644
--- a/lib/Debian/LicenseReconcile/FormatSpec.pm
+++ b/lib/Debian/LicenseReconcile/FormatSpec.pm
@@ -19,11 +19,11 @@ Debian::LicenseReconcile::FormatSpec - check format is recognized
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/LicenseCheck.pm b/lib/Debian/LicenseReconcile/LicenseCheck.pm
index cf0b1f9..b489a78 100644
--- a/lib/Debian/LicenseReconcile/LicenseCheck.pm
+++ b/lib/Debian/LicenseReconcile/LicenseCheck.pm
@@ -184,11 +184,11 @@ Debian::LicenseReconcile::LicenseCheck - wrapper around licensecheck
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS
diff --git a/lib/Debian/LicenseReconcile/Utils.pm b/lib/Debian/LicenseReconcile/Utils.pm
index c493531..6e44dfe 100644
--- a/lib/Debian/LicenseReconcile/Utils.pm
+++ b/lib/Debian/LicenseReconcile/Utils.pm
@@ -25,11 +25,11 @@ Debian::LicenseReconcile::Utils - various just about describable utilities
 
 =head1 VERSION
 
-Version 0.8
+Version 0.9
 
 =cut
 
-our $VERSION = '0.8';
+our $VERSION = '0.9';
 
 
 =head1 SYNOPSIS

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/license-reconcile.git

More information about the Pkg-perl-cvs-commits mailing list