[libmodule-build-perl] 04/06: Sort file lists generated by rscan_dir()
Florian Schlichting
fsfs at moszumanska.debian.org
Thu Sep 10 11:32:28 UTC 2015
This is an automated email from the git hooks/post-receive script.
fsfs pushed a commit to branch master
in repository libmodule-build-perl.
commit d28504672acb111f292f0f5dc662120a01d23df6
Author: Niko Tyni <ntyni at debian.org>
Date: Tue Sep 1 22:05:27 2015 +0300
Sort file lists generated by rscan_dir()
The rscan_dir() function traverses a directory with File::Find,
which returns files in readdir() order. This order is nondeterministic
and depends on the file system.
The lists are used, among other things, to find C files to compile
(in process_support_files()) and later to link (in c_link()).
The linking order affects the generated binary, essentially rendering
it nondeterministic and breaking reproducibility.
Notes:
Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=106813
Patch-Name: 0002-Sort-file-lists-generated-by-rscan_dir.patch
---
lib/Module/Build/Base.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Module/Build/Base.pm b/lib/Module/Build/Base.pm
index a6189a8..b323a46 100644
--- a/lib/Module/Build/Base.pm
+++ b/lib/Module/Build/Base.pm
@@ -5255,7 +5255,7 @@ sub rscan_dir {
die "Unknown pattern type";
File::Find::find({wanted => $subr, no_chdir => 1}, $dir);
- return \@result;
+ return [ sort @result ];
}
sub delete_filetree {
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libmodule-build-perl.git
More information about the Pkg-perl-cvs-commits
mailing list