[libnet-citadel-perl] 01/03: Imported Upstream version 0.23
Robert James Clay
jame at rocasa.us
Wed Aug 31 16:16:50 UTC 2016
This is an automated email from the git hooks/post-receive script.
jame-guest pushed a commit to branch master
in repository libnet-citadel-perl.
commit 37c2f696f31b60d173e17aaeffdbd7098890745f
Author: Robert James Clay <jame at rocasa.us>
Date: Wed Aug 31 11:25:44 2016 -0400
Imported Upstream version 0.23
---
Changes | 10 ++++++++++
META.json | 2 +-
META.yml | 2 +-
Makefile.PL | 1 +
lib/Net/Citadel.pm | 6 +++---
lib/Net/Citadel/ToDo.pod | 38 ++++++++++++++++++++------------------
t/00pods.t | 5 +++--
t/test.yaml | 2 +-
8 files changed, 40 insertions(+), 26 deletions(-)
diff --git a/Changes b/Changes
index 63c12ea..b01e22e 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,16 @@
Revision history for Perl extension Net::Citadel.
+0.23 13:55 25 August 2016
+ - Change the default IP in t/test.yaml to be '127.0.0.1'.
+ - Add "lib/Net/Citadel/ToDo.pod" to the PODs being checked in t/00pods.t.
+
+0.22 18:46 22 August 2016
+ - Add line missing from the 0.21 Changes regarding the MANIFEST file.
+ - Correct spelling of 'formated' to 'formatted' in lib/Net/Citadel.pm.
+ - Add a "dist" line including a 'ZIPFLAGS' option to the Makefile.PL file.
+
0.21 14:44 16 August 2016
+ - Add 'META.json' to the MANIFEST file.
- Set MIN_PERL_VERSION in Makefile.PL to '5.6.0'.
0.20 10:55 5 June 2013
diff --git a/META.json b/META.json
index a4aefab..8a9ce98 100644
--- a/META.json
+++ b/META.json
@@ -45,6 +45,6 @@
"url" : "https://github.com/jame/Net-Citadel"
}
},
- "version" : "0.21",
+ "version" : "0.23",
"x_serialization_backend" : "JSON::PP version 2.27300"
}
diff --git a/META.yml b/META.yml
index 3ddfb18..df32046 100644
--- a/META.yml
+++ b/META.yml
@@ -24,5 +24,5 @@ requires:
perl: '5.006000'
resources:
repository: https://github.com/jame/Net-Citadel
-version: '0.21'
+version: '0.23'
x_serialization_backend: 'CPAN::Meta::YAML version 0.018'
diff --git a/Makefile.PL b/Makefile.PL
index 91bc639..14ab64a 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -22,6 +22,7 @@ WriteMakefile(
repository => 'https://github.com/jame/Net-Citadel',
},
},
+ dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', ZIPFLAGS => '-or9',},
clean => { FILES => 'Net-Citadel-*' },
);
diff --git a/lib/Net/Citadel.pm b/lib/Net/Citadel.pm
index 83e3ac7..430d481 100644
--- a/lib/Net/Citadel.pm
+++ b/lib/Net/Citadel.pm
@@ -21,11 +21,11 @@ Net::Citadel - Citadel.org protocol coverage
=head1 VERSION
-Version 0.21
+Version 0.23
=cut
-our $VERSION = '0.21';
+our $VERSION = '0.23';
=head1 SYNOPSIS
@@ -778,7 +778,7 @@ Higest message number on the system. Only returned for type C<messages>.
=item SystemUptime
-The uptime for the system formated as days, hours, minutes.
+The uptime for the system formatted as days, hours, minutes.
=item SystemName
diff --git a/lib/Net/Citadel/ToDo.pod b/lib/Net/Citadel/ToDo.pod
index 014f39a..5111707 100644
--- a/lib/Net/Citadel/ToDo.pod
+++ b/lib/Net/Citadel/ToDo.pod
@@ -9,8 +9,6 @@ Net::Citadel::ToDo - To Do items for the Net::Citadel Perl extension.
=head2 General
-Add a ZIPFLAGS configuration item for dist/zipdist in Makefile.PL?
-
Add a note in the documentation about the Net::Citadel repository and home page
at GitHub? Also include a reference to where it is available at the C<gitpan>
CPAN mirror at GitHub?
@@ -28,27 +26,27 @@ There are some numbers being used that are actually constants; change to
using Readonly to define them for use in the code, unless there are other
standard constants that can be used, like those for the flock operations.
-Add a paragraph to the documentation after the CONSTANTS header.
-
-Add a paragraph to the documentation after the 'Results Code' header, perhaps
-including a link to the online status codes page in Citadel Documentation.
-
-Add a paragraph to the documentation after the 'Room Access' header, perhaps
-including a link to the online page in Citadel Documentation that refers to
-them.
-
A "000" string constant is used quite often by Citadel but is not defined in the
module.
There is a set of follow up reply codes noted in the documentation that are not
yet in the module.
+Add a link to the online documentation for the status codes:
+http://www.citadel.org/doku.php?id=documentation:appproto:statuscodes
+
A C<NO_SUCH_USER> return code is mentioned in the command documentation (for
-the USER command, for instance,) but the module doesn't currently appear to
+the USER command, for instance,) but the module does not currently appear to
define it.
-Add a link to the online documentation for the status codes:
-http://www.citadel.org/doku.php?id=documentation:appproto:statuscodes
+Add a paragraph to the documentation after the CONSTANTS header.
+
+Add a paragraph to the documentation after the 'Results Code' header, perhaps
+including a link to the online status codes page in Citadel Documentation.
+
+Add a paragraph to the documentation after the 'Room Access' header, perhaps
+including a link to the online page in Citadel Documentation that refers to
+them.
=head2 Functions
@@ -97,7 +95,7 @@ from the TIME command: C<1347624956|-14400>. The Citadel TIME command itself
actually returns a line like this: C<200 1347625545|-14400|1|1347537300>,
with the '200' being the OK code and the rest being the four fields that it
returns (which also needs to be documented). So as currently written, the
-function doesn't return the daylight savings time indication and the actual
+function does not return the daylight savings time indication and the actual
citadel server start information. Function first needs to be changed to at
least return all parameters.
@@ -111,7 +109,7 @@ to reflect the changes.
=item C<citadel_echo> function
It appears to test if what was sent, was actually received back but it only
-returns true if it doesn't fail because there is no match. Add an explicit
+returns true if it does not fail because there is no match. Add an explicit
return of the value returned from the ECHO command?
=back
@@ -125,6 +123,10 @@ of the module?
=head2 Testing
+Will the differences with the newer Citadels justify or neccessitate checking
+the version of the Citadel being tested and doing different tests depending
+on that version?
+
Change the names of the test floors and rooms to something like C<Test Floor>
and C<Test Room>?
@@ -155,7 +157,7 @@ Use Config::YAML::Tiny instead of Config::YAML? (Does not appear to be in
Debian as yet, although YAML::Tiny is.)
Use something like Test::MockObject to do at least basic testing of the
-various functions. And/or Test::TCP?
+various functions. And/or Test::TCP?
Testing of the citadel_info function currently just checks the number of
information lines returned by the server. That could change over time and
@@ -175,7 +177,7 @@ Robert James Clay, C<< <jame at rocasa.us> >>
=head1 COPYRIGHT AND LICENSE
-Copyright 2013 Robert James Clay, all rights reserved.
+Copyright 2016 Robert James Clay, all rights reserved.
This program is free software; you can redistribute it and/or modify it
under the same terms as Perl itself.
diff --git a/t/00pods.t b/t/00pods.t
index e1be1ed..a59fcf4 100644
--- a/t/00pods.t
+++ b/t/00pods.t
@@ -12,8 +12,9 @@ eval "use Test::Pod 1.00";
plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
my @PODs = qw(
- lib/Net/Citadel.pm
- );
+ lib/Net/Citadel.pm
+ lib/Net/Citadel/ToDo.pod
+ );
plan tests => scalar @PODs;
map {
diff --git a/t/test.yaml b/t/test.yaml
index 6ae039b..88bcab4 100644
--- a/t/test.yaml
+++ b/t/test.yaml
@@ -1,4 +1,4 @@
-host : 192.168.0.9
+host : 127.0.0.1
account :
username : Administrator
password : xxx
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libnet-citadel-perl.git
More information about the Pkg-perl-cvs-commits
mailing list