[libcgi-test-perl] 06/24: Attempt at fixing a nasty bug with Fcntl shared object loading when running tests

Axel Beckert abe at deuxchevaux.org
Mon Jan 11 00:38:06 UTC 2016


This is an automated email from the git hooks/post-receive script.

abe pushed a commit to annotated tag 0.50
in repository libcgi-test-perl.

commit 386ab4bfc2fd7556b0c27a232698b9d21f145e1e
Author: Alexander Tokarev <tokarev at cpan.org>
Date:   Mon Nov 21 00:23:59 2011 +0300

    Attempt at fixing a nasty bug with Fcntl shared object loading when running tests
---
 Changes         | 18 ++++++++++++++++++
 Makefile.PL     |  2 +-
 README          |  2 +-
 lib/CGI/Test.pm |  2 +-
 t/browse.pl     | 11 +++++++++++
 5 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/Changes b/Changes
index 316ea4d..e278007 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,21 @@
+Mon Nov 21 00:17:38 MSD 2011    Alexander Tokarev <tokarev at cpan.org>
+
+        Version 0.2.3
+
+        Made an attempt to fix a nasty bug that manifests itself
+        with custom Perl builds: test suite fails saying that it
+        can't load Fcntl shared object. I don't think this is
+        exactly *my* problem but it seems that majority of CPAN
+        testers are using customized Perl builds so FAIL to PASS
+        rate is like 2:1, which is clearly not good.
+
+        The fix is quite simple: I'm adding path to Perl executable
+        to PATH environment variable before anything else. This
+        seems to fix the problem on my machine, will see how it
+        fares with CPAN testers.
+
+        No other changes were made.
+
 Sun Oct 16 23:46:11 MSD 2011    Alexander Tokarev <tokarev at cpan.org>
 
         Version 0.2.2
diff --git a/Makefile.PL b/Makefile.PL
index 43a95c3..c7d4a42 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -1,5 +1,5 @@
 #
-# $Id: Makefile.PL,v 1.2 2003/10/04 14:26:05 mshiltonj Exp $
+# $Id$
 #
 #  Copyright (c) 2001, Raphael Manfredi
 #
diff --git a/README b/README
index a3c6b2a..d8e7fc8 100644
--- a/README
+++ b/README
@@ -1,4 +1,4 @@
-                           CGI::Test 0.2
+                           CGI::Test 0.2.3
                  Copyright (c) 2001, Raphael Manfredi
 
 ------------------------------------------------------------------------
diff --git a/lib/CGI/Test.pm b/lib/CGI/Test.pm
index 99efc81..8385fc6 100644
--- a/lib/CGI/Test.pm
+++ b/lib/CGI/Test.pm
@@ -23,7 +23,7 @@ use File::Basename;
 require Exporter;
 use vars qw($VERSION @ISA @EXPORT);
 
-$VERSION = '0.2.2';
+$VERSION = '0.2.3';
 @ISA     = qw(Exporter);
 @EXPORT  = qw(ok);
 
diff --git a/t/browse.pl b/t/browse.pl
index 9523c63..8e8603d 100644
--- a/t/browse.pl
+++ b/t/browse.pl
@@ -43,6 +43,17 @@
 use CGI::Test;
 use Getargs::Long;
 
+use Config;
+
+#
+# This is a fix for nasty Fcntl loading problem: it seems that
+# custom-built Perl fails to allocate some kind of resources, or
+# just tries to load wrong shared object. This results in tests
+# failing miserably; considering that custom builds are very common
+# among CPAN testers, it is a serious problem.
+#
+$ENV{PATH} = $Config{bin} . ':' . $ENV{PATH};
+
 sub browse {
 	my ($method, $enctype) = getargs(@_, [qw(method enctype)]);
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libcgi-test-perl.git



More information about the Pkg-perl-cvs-commits mailing list