[libauthen-krb5-perl] 01/01: add patch removing references to obsolete krb5_{get, free}_krbhst

Damyan Ivanov dmn at moszumanska.debian.org
Tue Jul 12 09:08:28 UTC 2016


This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository libauthen-krb5-perl.

commit 3558a417d93db006bc0d2f30034638590d98631e
Author: Damyan Ivanov <dmn at debian.org>
Date:   Tue Jul 12 09:08:20 2016 +0000

    add patch removing references to obsolete krb5_{get,free}_krbhst
    
    Thanks to Sergio Gelato. Closes: #830844
---
 debian/patches/obsolete-krb_get,free_krbhst.patch | 51 +++++++++++++++++++++++
 debian/patches/series                             |  1 +
 2 files changed, 52 insertions(+)

diff --git a/debian/patches/obsolete-krb_get,free_krbhst.patch b/debian/patches/obsolete-krb_get,free_krbhst.patch
new file mode 100644
index 0000000..66bfe71
--- /dev/null
+++ b/debian/patches/obsolete-krb_get,free_krbhst.patch
@@ -0,0 +1,51 @@
+Description: remove references to obsolete krb5_{get,free}_krbhst
+ These routines were internal and are removed from krb5.
+ They aren't used anyway and only cause module load failures when
+ PERL_DL_NONLAZY is set.
+ Thanks to Sergio Gelato
+ https://codesearch.debian.net/search?q=krb5_get_krbhst shows no relevant usage
+Bug-Debian: https://bugs.debian.org/830844
+--- a/Krb5.xs
++++ b/Krb5.xs
+@@ -47,14 +47,6 @@ static krb5_error_code err;
+ static krb5_keytab_entry keytab_entry_init;
+ 
+ /*
+- * These are internal Kerberos library functions that aren't prototyped and
+- * that we probably shouldn't be calling.  Prototype them with the arguments
+- * we expect and leave them for now pending an API cleanup.
+- */
+-krb5_error_code krb5_free_krbhst(krb5_context, char * const *);
+-krb5_error_code krb5_get_krbhst(krb5_context, const krb5_data *, char ***);
+-
+-/*
+  * The following three routines implement a "safehouse" for nested Kerberos
+  * data structures which shouldn't be freed before their parent data
+  * structures are freed.  Without this, "Bad free() ignored" errors as well
+@@ -181,26 +173,6 @@ krb5_get_host_realm(host)
+ 	}
+ 	krb5_free_host_realm(context,realmlist);
+ 
+-void
+-krb5_get_krbhst(realm)
+-	char *realm
+-
+-	PREINIT:
+-	krb5_data realm_data;
+-	char **hostlist;
+-	int i;
+-
+-	PPCODE:
+-	realm_data.data = realm;
+-	realm_data.length = strlen(realm);
+-	err = krb5_get_krbhst(context,&realm_data,&hostlist);
+-	if (err || !hostlist) XSRETURN_UNDEF;
+-	for (i = 0; hostlist[i]; i++) {
+-		XPUSHs(sv_2mortal(newSVpv(hostlist[i],
+-			strlen(hostlist[i]))));
+-	}
+-	krb5_free_krbhst(context,hostlist);
+-
+ Authen::Krb5::Principal
+ krb5_build_principal_ext(p)
+ 	Authen::Krb5::Principal p
diff --git a/debian/patches/series b/debian/patches/series
index 4ce8426..891f4f9 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 better-compiler-flags
 fix_pod
 fix-init_context.patch
+obsolete-krb_get,free_krbhst.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libauthen-krb5-perl.git



More information about the Pkg-perl-cvs-commits mailing list