[libconfig-crontab-perl] 01/04: Revert "Patch the test suite to not check for crontab(1) unnecessarily"
Niko Tyni
ntyni at moszumanska.debian.org
Mon Sep 19 20:02:19 UTC 2016
This is an automated email from the git hooks/post-receive script.
ntyni pushed a commit to branch master
in repository libconfig-crontab-perl.
commit eac373f53ee327999b6d0bfb9cfdd7ab20cb3460
Author: Niko Tyni <ntyni at debian.org>
Date: Mon Sep 19 21:55:59 2016 +0300
Revert "Patch the test suite to not check for crontab(1) unnecessarily"
Upstream considers this a safety feature, even though the test suite
doesn't directly manipulate user crontabs.
See https://rt.cpan.org/Ticket/Display.html?id=117922
This reverts commit 5cd2cc2b7f73b4de1d963e7773dd46dabbc38fcb.
---
...-for-crontab-1-unnecessarily-in-the-test-.patch | 30 ----------------------
debian/patches/series | 1 -
2 files changed, 31 deletions(-)
diff --git a/debian/patches/0001-Don-t-check-for-crontab-1-unnecessarily-in-the-test-.patch b/debian/patches/0001-Don-t-check-for-crontab-1-unnecessarily-in-the-test-.patch
deleted file mode 100644
index 249b2b7..0000000
--- a/debian/patches/0001-Don-t-check-for-crontab-1-unnecessarily-in-the-test-.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 122dbf7cc964d47c9f1e895258fdac0f7158d4ec Mon Sep 17 00:00:00 2001
-From: Niko Tyni <ntyni at debian.org>
-Date: Sat, 17 Sep 2016 13:27:41 +0300
-Subject: [PATCH] Don't check for crontab(1) unnecessarily in the test suite
-
-The test suite doesn't actually use crontab(1), and the exit code
-handling is broken. Rather than build depend on cron, hardwire the
-check to always return true.
-
-Bug-Debian: https://bugs.debian.org/838089
----
- t/setup.pl | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/t/setup.pl b/t/setup.pl
-index 492716f..349f9e8 100644
---- a/t/setup.pl
-+++ b/t/setup.pl
-@@ -2,6 +2,8 @@ use strict;
- use warnings;
-
- sub have_crontab {
-+ # see https://bugs.debian.org/838089
-+ return 1;
- eval 'system("crontab -l 2>/dev/null")';
- return ($? >> 8 == 1);
- }
---
-2.9.3
-
diff --git a/debian/patches/series b/debian/patches/series
index aedb94a..90a9b88 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1 @@
0001-Make-the-test-suite-work-without-cwd-in-INC.patch
-0001-Don-t-check-for-crontab-1-unnecessarily-in-the-test-.patch
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libconfig-crontab-perl.git
More information about the Pkg-perl-cvs-commits
mailing list