[boxer] 08/33: Run perlcritic with tidyall, and test both (not only perlcritic) in TEST_AUTHOR mode.

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to annotated tag debian/1.1.5-1
in repository boxer.

commit 8adb9af4738b273278ffdd7f458ab67fd2b1bced
Author: Jonas Smedegaard <dr at jones.dk>
Date:   Wed Jun 29 22:25:03 2016 +0200

    Run perlcritic with tidyall, and test both (not only perlcritic) in TEST_AUTHOR mode.
---
 .tidyallrc         |  5 ++---
 meta/makefile.pret |  1 -
 xt/perlcritic.t    | 25 -------------------------
 xt/perlcriticrc    |  3 ---
 xt/tidyall.t       | 12 ++++++++++++
 5 files changed, 14 insertions(+), 32 deletions(-)

diff --git a/.tidyallrc b/.tidyallrc
index 3af1148..dcc2585 100644
--- a/.tidyallrc
+++ b/.tidyallrc
@@ -2,6 +2,5 @@
 select = **/*.{pl,pm,t}
 argv = --profile=$ROOT/.perltidyrc
 
-;[PerlCritic]
-;select = lib/**/*.pm
-;argv = -severity 3
+[PerlCritic]
+select = lib/**/*.pm
diff --git a/meta/makefile.pret b/meta/makefile.pret
index 5bb8c11..1a90aa1 100644
--- a/meta/makefile.pret
+++ b/meta/makefile.pret
@@ -16,7 +16,6 @@
 	:runtime-requirement  [ :on "MooX::Role::Logger 0"^^:CpanId ];
 	:runtime-requirement  [ :on "Log::Any::Adapter::Screen 0"^^:CpanId ];
 	:runtime-requirement  [ :on "namespace::clean 0"^^:CpanId ];
-	:runtime-requirement  [ :on "Path::Class 0"^^:CpanId ];
 	:runtime-requirement  [ :on "MooX::Types::MooseLike::Base 0"^^:CpanId ];
 	:runtime-requirement  [ :on "Path::Tiny 0"^^:CpanId ];
 	:runtime-requirement  [ :on "Role::Commons 0"^^:CpanId ];
diff --git a/xt/perlcritic.t b/xt/perlcritic.t
deleted file mode 100644
index a4d9559..0000000
--- a/xt/perlcritic.t
+++ /dev/null
@@ -1,25 +0,0 @@
-#!/usr/bin/perl
-
-use v5.14;
-use utf8;
-use strictures 2;
-
-use File::Spec;
-use Test::More;
-use English qw(-no_match_vars);
-
-if ( not $ENV{TEST_AUTHOR} ) {
-	my $msg = 'Author test.  Set $ENV{TEST_AUTHOR} to a true value to run.';
-	plan( skip_all => $msg );
-}
-
-eval { require Test::Perl::Critic; };
-
-if ($EVAL_ERROR) {
-	my $msg = 'Test::Perl::Critic required to criticise code';
-	plan( skip_all => $msg );
-}
-
-my $rcfile = File::Spec->catfile( 'xt', 'perlcriticrc' );
-Test::Perl::Critic->import( -profile => $rcfile );
-all_critic_ok();
diff --git a/xt/perlcriticrc b/xt/perlcriticrc
deleted file mode 100644
index efd6da9..0000000
--- a/xt/perlcriticrc
+++ /dev/null
@@ -1,3 +0,0 @@
-# we (literally) use strictures undetected by Perl::Critic
-[TestingAndDebugging::RequireUseStrict]
-severity = 2
diff --git a/xt/tidyall.t b/xt/tidyall.t
new file mode 100644
index 0000000..39cdb1d
--- /dev/null
+++ b/xt/tidyall.t
@@ -0,0 +1,12 @@
+#!/usr/bin/perl
+
+use v5.14;
+use utf8;
+use strictures 2;
+
+use Test::More;
+use Test::Code::TidyAll;
+
+tidyall_ok();
+
+done_testing();

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/boxer.git