[libcoro-perl] 01/03: drop the patch stopping disabling of FORTIFY_SOURCE

Damyan Ivanov dmn at moszumanska.debian.org
Sun Oct 29 15:15:17 UTC 2017


This is an automated email from the git hooks/post-receive script.

dmn pushed a commit to branch master
in repository libcoro-perl.

commit 06718c9285ef7931e2fa51b0b02d8e0df7ad0384
Author: Damyan Ivanov <dmn at debian.org>
Date:   Sun Oct 29 15:11:48 2017 +0000

    drop the patch stopping disabling of FORTIFY_SOURCE
    
    FORTIFY_SOURCE makes Coro segfault during tests
    it is disabled only when setjump/longjump implementation is used
    (all but hurd-i386 (uses uctx) and x86 variants on
    linux and freebsd (use asm))
    
    it is unfortunate that FORTIFY_SOURCE needs to be disabled
    for Coro to work when using setjump/longjump, but this is how
    much pkg-perl maintainers can interfere, being neither upstream
    of Coro, nor glibc gurus.
---
 debian/changelog                                   |  1 -
 debian/patches/do-not-disable-fortify-source.patch | 30 ----------------------
 debian/patches/series                              |  1 -
 3 files changed, 32 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 1d99f7b..5e787af 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,7 +9,6 @@ libcoro-perl (6.514-1) UNRELEASED; urgency=medium
   * drop coro-5.24.patch, applied upstream
   * drop coro-5.26.patch, applied upstream
   * refresh spelling.patch, almost all applied upstream
-  * add a patch reverting the disabling of FORTIFY_SOURCE in the hope that current libc is no longer problematic
 
  -- Damyan Ivanov <dmn at debian.org>  Sun, 29 Oct 2017 00:05:43 +0300
 
diff --git a/debian/patches/do-not-disable-fortify-source.patch b/debian/patches/do-not-disable-fortify-source.patch
deleted file mode 100644
index 07aec40..0000000
--- a/debian/patches/do-not-disable-fortify-source.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-Description: Experimental patch enabling FORTIFY_SOURCE
- FIXME: this needs to be tested on architectures that use the
- setjump/longjump implementation
-Author: Damyan Ivanov <dmn at debian.org>
-
---- a/Coro/Makefile.PL
-+++ b/Coro/Makefile.PL
-@@ -219,7 +219,6 @@ if ($iface eq "u") {
-    print "\nUsing ucontext implementation\n\n";
-    conftest ("TEST_makecontext");
- } elsif ($iface eq "s") {
--   $DEFINE .= " -D_FORTIFY_SOURCE=0";
-    $DEFINE .= " -DCORO_SJLJ";
-    print "\nUsing setjmp/longjmp/sigaltstack implementation\n\n";
-    conftest ("TEST_sigaltstack");
---- a/Coro/libcoro/coro.h
-+++ b/Coro/libcoro/coro.h
-@@ -342,12 +342,6 @@ struct coro_context
- #  define _GNU_SOURCE /* for glibc */
- # endif
- 
--/* try to disable well-meant but buggy checks in some libcs */
--# ifdef _FORTIFY_SOURCE
--#  undef _FORTIFY_SOURCE
--#  undef __USE_FORTIFY_LEVEL /* helps some more when too much has been included already */
--# endif
--
- # if !CORO_LOSER
- #  include <unistd.h>
- # endif
diff --git a/debian/patches/series b/debian/patches/series
index aa7db98..d63b0d0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,4 +1,3 @@
 fix-wrong-path-for-interpreter.patch
 whatis.patch
 spelling.patch
-do-not-disable-fortify-source.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libcoro-perl.git



More information about the Pkg-perl-cvs-commits mailing list