Bug#401065: [php-maint] Bug#401065: php4: Please patch PHP to add a mail header when sending mail

[Alberto Gonzalez Iniesta]

On Thu, Nov 30, 2006 at 06:47:55PM +0100, Ondřej Surý wrote:
> Hi agi,
> 
> Alberto Gonzalez Iniesta píše v Čt 30. 11. 2006 v 18:10 +0100:
> > There's a patch [1] that adds and extra header to the mails sent from
> > PHP, with all the info required (server name, script name, remote addr)
> > to track the origin of the mail. This patch will help A LOT Debian
> > admins/users with PHP scripts that send mail.
> > 
> > Please consider adding this patch to PHP4/5 for etch.
> 
> idea in the patch is perfect, but I have two objections for adding this
> patch to debian PHP.
> 
> Firstly I consider this as big intrusion into privacy of users, so I
> think it has to be configurable and it has to default to off, so it's up
> to each individual administrator to enable/disable this feature.
> 
> My second objection is that I do not consider programming style of:
> 
[snip]
> 
> appropriate for C code and I think it needs rewrite to some more normal
> programming style.  PHP is broken enough as is.
> 
> After that I would be more then happy to add this patch to both php4 and
> php5 in debian.

Hi Ondřej,

Thanks for your quick answer. I understand your points. My C skills are
not very good, but I'll try to take a closer look at the code and maybe
rewrite those patches, again as time permits.

Regards,

Alberto

-- 
Alberto Gonzalez Iniesta    | Formación, consultoría y soporte técnico
agi@(inittab.org|debian.org)| en GNU/Linux y software libre
Encrypted mail preferred    | http://inittab.com

Key fingerprint = 9782 04E7 2B75 405C F5E9  0C81 C514 AF8E 4BA4 01C3