[php-maint] Bug#346550: bug still present in php5-5.1.2

[David Mosberger-Tang]

This bug is still present.  The problem is that while this patch:

  debian/patches/106-strptime_xopen.patch

is well-intentioned, it doesn't work.  The problem with this:

-----------------
+#include "php.h"
 #if HAVE_STRPTIME
 #define _XOPEN_SOURCE
 #endif
   :
 #include <time.h>
-----------------

is that php.h itself includes <time.h> so by the time _XOPEN_SOURCE is
set, it's too late, since the latere inclusion of <time.h> won't have
any effect anymore.

The attached patch fixes the problem and should have no ill effect on
other platforms.  Note that both _XOPEN_SOURCE and _BSD_SOURCE need to
be defined because with _XOPEN_SOURCE alone, type "ulong" does NOT get
declared, which then causes problems in zend_hash.h.  Fun, fun.

Regards,

  --david
--
Mosberger Consulting LLC, http://www.mosberger-consulting.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: datetime.diff
Type: text/x-patch
Size: 414 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20060320/d67d5ef9/datetime-0001.bin