Bug#401065: [php-maint] Bug#401065: php4: Please patch PHP to add a mail header when sending mail

[Ondřej Surý]

Hi agi,

Alberto Gonzalez Iniesta píše v Čt 30. 11. 2006 v 18:10 +0100:
> Package: php4
> Severity: wishlist
> Tags: patch
> 
> 
> We all know PHP is (ab)used by many developers with not all the care and
> experience one would want. Since PHP under Debian is widely used in
> multi hosting enviroments, one of the common headaches of these sites
> sysadmins is controling which site is being abused to send SPAM.
> 
> There's a patch [1] that adds and extra header to the mails sent from
> PHP, with all the info required (server name, script name, remote addr)
> to track the origin of the mail. This patch will help A LOT Debian
> admins/users with PHP scripts that send mail.
> 
> Please consider adding this patch to PHP4/5 for etch.

idea in the patch is perfect, but I have two objections for adding this
patch to debian PHP.

Firstly I consider this as big intrusion into privacy of users, so I
think it has to be configurable and it has to default to off, so it's up
to each individual administrator to enable/disable this feature.

My second objection is that I do not consider programming style of:

while (1) {
 if (condition)
   break;
 if (condition)
   break;
}

appropriate for C code and I think it needs rewrite to some more normal
programming style.  PHP is broken enough as is.

After that I would be more then happy to add this patch to both php4 and
php5 in debian.

However I am unable to promise that I will make time and rewrite this
patch to include those two things.

Ondrej.
-- 
Ondřej Surý <ondrej at sury.org> ^_^ http://blog.rfc1925.org/