[php-maint] Bug#447764: Bug#447764: libapache2-mod-php5: updated debdiff
Steve Langasek
vorlon at debian.org
Mon Jan 7 09:39:01 UTC 2008
Hi Jamie,
On Fri, Dec 21, 2007 at 03:43:51PM -0500, Jamie Strandboge wrote:
> Package: libapache2-mod-php5
> Version: 5.2.4-2
> Followup-For: Bug #447764
> Attached is an updated debdiff for 5.2.4-2.
I have just a few small comments/questions about this patch:
- The page includes a message explaining how to install libapache2-mod-php5.
If that's the package that ships this page, why should that be given as
part of the instructions for getting php working? Perhaps that should be
omitted?
- Should the static content perhaps list mysql and postgresql as "not
tested" rather than "not working", so users aren't prematurely led to
think they need to debug a sql server problem?
- The page checks extension_loaded() without also trying to load the modules
with dl(). I know upstream's approach to extension loading is irrevocably
broken, but it would IMHO still be nice if the page would this way detect
the "php5-mysql installed, but not globally enabled" case.
- Any chance of a bit more color for the table? :-)
Overall, I think this is a reasonable thing to add to the package. Sean,
are you ok with it?
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek at ubuntu.com vorlon at debian.org
More information about the pkg-php-maint
mailing list