[php-maint] Bug#440634: Revisiting an Old PHP Problem in PHP 5.2.0

[sean finney]

hi ralph, andi, et al.

On Tuesday 06 May 2008 10:27:46 pm Ralph Schindler wrote:
> Just curious if you had time to follow up with this.  A patch was found and
> supplied, but I think at some point this thread died out.
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=440634#10

i've spent a bit of time looking at the patch, and unfortunately parts of it 
do not apply:

rangda[/home/sean/debian/build-area/php5-5.2.0] patch --dry-run -p1 < 
~/overloaded_array_properties.patch                :)
(Stripping trailing CRs from patch.)
patching file Zend/zend_compile.c
Hunk #1 succeeded at 3634 (offset -43 lines).
Hunk #2 succeeded at 3647 (offset -43 lines).
Hunk #3 succeeded at 3660 (offset -43 lines).
Hunk #4 succeeded at 3675 (offset -43 lines).
Hunk #5 succeeded at 3694 (offset -43 lines).
Hunk #6 succeeded at 3706 (offset -43 lines).
Hunk #7 succeeded at 3737 (offset -43 lines).
(Stripping trailing CRs from patch.)
patching file Zend/zend_compile.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_execute.c
Hunk #1 FAILED at 1163.
1 out of 1 hunk FAILED -- saving rejects to file Zend/zend_execute.c.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_execute.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_hash.c
Hunk #1 succeeded at 992 (offset -14 lines).
(Stripping trailing CRs from patch.)
patching file Zend/zend_hash.h
(Stripping trailing CRs from patch.)
patching file Zend/zend_language_parser.y
(Stripping trailing CRs from patch.)
patching file Zend/zend_object_handlers.c
Hunk #1 FAILED at 334.
1 out of 1 hunk FAILED -- saving rejects to file 
Zend/zend_object_handlers.c.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_vm_def.h
Hunk #1 succeeded at 3198 (offset -9 lines).
Hunk #2 succeeded at 3243 (offset -9 lines).
Hunk #3 FAILED at 3255.
Hunk #4 succeeded at 3265 (offset -11 lines).
Hunk #5 succeeded at 3274 (offset -11 lines).
1 out of 5 hunks FAILED -- saving rejects to file Zend/zend_vm_def.h.rej
(Stripping trailing CRs from patch.)
patching file Zend/zend_vm_execute.h
Hunk #1 succeeded at 2255 (offset -1 lines).
Hunk #2 succeeded at 4795 (offset -2 lines).
Hunk #3 succeeded at 7917 (offset -11 lines).
Hunk #4 succeeded at 7962 (offset -11 lines).
Hunk #5 FAILED at 7974.
Hunk #6 succeeded at 7984 (offset -13 lines).
Hunk #7 succeeded at 7993 (offset -13 lines).
Hunk #8 succeeded at 19967 (offset -22 lines).
1 out of 8 hunks FAILED -- saving rejects to file Zend/zend_vm_execute.h.rej
(Stripping trailing CRs from patch.)
patching file Zend/tests/bug38146.phpt
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file Zend/tests/bug38146.phpt.rej
rangda[/home/sean/debian/build-area/php5-5.2.0]                         [1] :(



and the first failed hunk does indeed seem nontrivial (seems the surrounding 
logic hash changed enough that someone who knows the code should review the 
change).  i've stopped there, so i don't know if it's the same for the rest 
of the failures.

fwiw, i've reattached the patch in question, in which i've made the following 
modificaitons:

- removed NEWS changes
- removed cvs id related changes
- s,ZendEngine2,foo/Zend, in patch references, so the whole patch applies 
cleanly to an unpacked php5 tarball at -p1.


if someone wants to comment on what should be done (or beter, provide a patch 
that applies against 5.2.0), i can take the next step of providing updated 
packages for testing.

thanks,
	sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: overloaded_array_properties.patch
Type: text/x-diff
Size: 17152 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20080515/71a2efe2/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20080515/71a2efe2/attachment.pgp