[php-maint] pre-approval of new upload of php5:(was: [RFC] Gentoo patches)

[Raphael Geissert]

Hi,

Sorry for the late response, it is until now that I'm resuming my work on php.

2008/12/30 Thijs Kinkhorst <thijs at debian.org>:
> On Fri, December 5, 2008 04:07, Raphael Geissert wrote:
>> There are a couple of issues in php5 that need to be fixed soonish, so
>> it would be great if others could comment on whether I should commit the
>> changes/patches or not (targeted at lenny).
>
> While I don't judge the individual merits of each patch, I'm not so sure
> we should be applying all these changes so close before the so called
> "deep freeze". There are many possible patches to PHP, be it those from
> gentoo, or bugfixes applied between 5.2.6 and 5.2.8 upstream but we have
> to be very picky at this point in applying new stuff.

They are all bug fixes applied by upstream in following releases (say
5.6.7) which were included in  the gentoo package because of bug
reports received at their tracker. This doesn't only mean that are not
corner cases and that we would not be the only player to include them.
And most of them are fixes for crashes, not just any kind of bug.

>
> Patches that do whitespace reformatting are definately out of the
> question, in my opinion.

If you take a look at the patch with a smart patch viewer you will
notice that the code changes are actually minimal, and leave the
re-indentation apart.

>
>> I'm aware of pcre's shlibs bump and the need of a t-p-u to get the
>> bugs fixed (the DFSG-freeness one, a security issue, and a couple of other
>> minor bugs); but it would be great if the only two differences between the
>> versions in lenny and sid are a changelog entry and the dependencies of
>> the built binaries.
>
> I'm not sure what advantage that would bring us. Why not upload 5.2.8 to
> sid since it will never migrate to lenny anymore anyway due to the pcre
> issue? Why would we want to keep the two in sync?
>

The idea was to diverge as less as possible, for better handling of
bug reports.

Completely offtopic: what about moving to git?

>
> Thijs
>
>

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net

Joe E. Lewis  - "There's only one thing money won't buy, and that is poverty."