[php-maint] RFS: php-gearman
thomas at goirand.fr
Mon Aug 2 19:39:21 UTC 2010
Clint Byrum wrote:
> - dget http://mentors.debian.net/debian/pool/main/p/php-gearman/php-gearman_0.7.0-1.dsc
I'm not willing to sponsor, as I'm quite busy and I'm quite a newb DD
(my acct was added in June), and as I never used Gearman and wouldn't be
able to test without spending a lot of time reading docs, but I had a
quick look at your package in order to help.
First of all, on your RFS, it would have been great to have a longer
definition of your package, and some explanations on why you think it's
useful and such. I had to search to see what gearman was, this isn't
normal, it should show on your RFS. Your motivation isn't quite
Few remarks on your package now. Standards-Version: is an old one,
please bump to the actual one (8.9.1 AFAIK), and test using the latest
lintian from SID (I believe that currently, the Lenny backport of
lintian is up to date as well, but this isn't a rule at all, sometimes
the backport of lintian takes a long time to do...).
Your package long description is too short. Less than 3 lines, and
lintian will complain, yet you wrote "The package appears to be lintian
clean". Please run lintian with the -Ii flags. It'd be great if you
could also describe (shortly) what gearman is. Just by reading your
package description, nobody will be able to know why it's useful or what
it does. In this regard, the upstream README file has a lot more
information, you could cut/past from it or take text from gearman, IMHO
(I always think it's best to cut/past from the description from
upstream, rather than writing something of your own which could be wrong).
It seems you want to upload in unstable, however, the author ships a
file called "EXPERIMENTAL" explaining that the API may change. Are you
sure it's a good fit for SID/squeeze? (just asking, nothing more, please
just describe your experience with the package...)
The CREDITS file from upstream lists James and Eric, yet, your
debian/copyright only lists one of them. I didn't go further (eg:
reading all files and hunting for authorship, as I have been strongly
requested for many of my new packages recently (shame on me)), but this
already deserves some modifications in debian/copyright.
That's about it for the moment. There isn't much, as I didn't even try
to build your package (and of course, didn't even test using it). I hope
this will help you to improve your package and find a sponsor for it faster.
More information about the pkg-php-maint